FAQ
Skipped content of type multipart/alternative-------------- next part --------------
A non-text attachment was scrubbed...
Name: configurable_cookie_domain.diff
Type: application/octet-stream
Size: 1431 bytes
Desc: not available
Url : http://lists.scsys.co.uk/pipermail/catalyst/attachments/20090609/6c426f10/configurable_cookie_domain.obj

Search Discussions

  • Tomas Doran at Jun 9, 2009 at 5:41 pm

    Fayland Lam wrote:
    hey, it's a patch for Catalyst::Plugin::Session::Store::Cookie. to make
    cookie_domain more configurable.

    __PACKAGE__->config->{session}->{cookie_domain} = sub {
    my $c = shift;
    if ( $c->req->uri->host =~ /xxx\.com/ ) {
    return '.xxx.com <http://xxx.com>';
    } else {
    return '.yyy.com <http://yyy.com>';
    }
    };

    if it's acceptable, I'll provide a .t for that.
    Er, I don't see the value of putting code refs into config - that's
    fairly insane.. Code != config.

    What are you actually trying to achieve here (i.e. what are some example
    use cases)?

    But yes, patches to improve flexibility with tests would be generally
    welcome.

    Cheers
    t0m
  • Jay Shirley at Jun 9, 2009 at 6:19 pm

    On Tue, Jun 9, 2009 at 10:41 AM, Tomas Doran wrote:

    Fayland Lam wrote:
    hey, it's a patch for Catalyst::Plugin::Session::Store::Cookie. to make
    cookie_domain more configurable.

    __PACKAGE__->config->{session}->{cookie_domain} = sub {
    my $c = shift;
    if ( $c->req->uri->host =~ /xxx\.com/ ) {
    return '.xxx.com <http://xxx.com>';
    } else {
    return '.yyy.com <http://yyy.com>';
    }
    };

    if it's acceptable, I'll provide a .t for that.
    Er, I don't see the value of putting code refs into config - that's fairly
    insane.. Code != config.

    What are you actually trying to achieve here (i.e. what are some example
    use cases)?

    But yes, patches to improve flexibility with tests would be generally
    welcome.

    Cheers
    t0m

    I can't speak to the method, but the desire is something I would like to
    have. If an application is accessible via different domains, it is nice to
    be able to change the cookie name.

    A simple, and contrived but real world example, is this:

    Production application lives on secure.domainname.com, but shares auth
    cookies with www.domainname.com

    As such, you set cookie_domain => '.domainname.com'

    However, in development without special modification (local config having
    cookie_domain => 'localhost') you can't login anymore.

    Being able to specify the session cookie name based on the request would be
    useful for edge cases.

    -J
    -------------- next part --------------
    An HTML attachment was scrubbed...
    URL: http://lists.scsys.co.uk/pipermail/catalyst/attachments/20090609/521977e9/attachment.htm
  • Tomas Doran at Jun 9, 2009 at 8:15 pm

    On 9 Jun 2009, at 19:19, J. Shirley wrote:
    Being able to specify the session cookie name based on the request
    would be useful for edge cases.
    I totally agree.

    How would something like a 'cookie_name_stash_key' configuration
    parameter sit with you?

    If not provided, we do what we do now, if provided then that stash
    key will be used if present and defined, otherwise the default
    handling will be used.

    Cheers
    t0m
  • Jay Shirley at Jun 9, 2009 at 8:29 pm
    On Tue, Jun 9, 2009 at 1:15 PM, Tomas Doran wrote:
    On 9 Jun 2009, at 19:19, J. Shirley wrote:

    Being able to specify the session cookie name based on the request would
    be useful for edge cases.
    I totally agree.

    How would something like a 'cookie_name_stash_key' configuration parameter
    sit with you?

    If not provided, we do what we do now, if provided then that stash key will
    be used if present and defined, otherwise the default handling will be used.
    If it can understand nested keys in the stash, I'm all in favor of it.

    Something like $c->stash->{page}->{cookie_domain} would fit inline with what
    I currently do for similar things.

    -J
    -------------- next part --------------
    An HTML attachment was scrubbed...
    URL: http://lists.scsys.co.uk/pipermail/catalyst/attachments/20090609/7149c931/attachment.htm
  • Tomas Doran at Jun 9, 2009 at 8:42 pm

    On 9 Jun 2009, at 21:29, J. Shirley wrote:

    On Tue, Jun 9, 2009 at 1:15 PM, Tomas Doran wrote:

    How would something like a 'cookie_name_stash_key' configuration
    parameter sit with you?

    If not provided, we do what we do now, if provided then that stash
    key will be used if present and defined, otherwise the default
    handling will be used.

    If it can understand nested keys in the stash, I'm all in favor of it.

    Something like $c->stash->{page}->{cookie_domain} would fit inline
    with what I currently do for similar things.
    I guess if cookie_name_stash_key is a non ref scalar, then it's
    treated as a sting ($c->stash->{$cookie_name_stash_key}), otherwise
    it's treated as a set of keys (e.g. cookie_name_stash_key => [qw/page
    cookie_domain/] does your example above.

    Cheers
    t0m

    -------------- next part --------------
    An HTML attachment was scrubbed...
    URL: http://lists.scsys.co.uk/pipermail/catalyst/attachments/20090609/5b951f19/attachment.htm

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupcatalyst @
categoriescatalyst, perl
postedJun 9, '09 at 6:26a
activeJun 9, '09 at 8:42p
posts6
users3
websitecatalystframework.org
irc#catalyst

People

Translate

site design / logo © 2022 Grokbase