[Mailman-Users] List-Archive URL for private archives broken

hello,

somehow, the patch in the attachment did not appear in the mailing list, sending
it here as plaintext:

diff -up mailman-2.1.12/Mailman/Handlers/CookHeaders.py.privurl mailman-2.1.12/Mailman/Handlers/CookHeaders.py
--- mailman-2.1.12/Mailman/Handlers/CookHeaders.py.privurl 2009-03-30 15:03:58.000000000 +0200
+++ mailman-2.1.12/Mailman/Handlers/CookHeaders.py 2009-03-30 15:06:45.000000000 +0200
@@ -215,7 +215,7 @@ def process(mlist, msg, msgdata):
# Add this header if we're archiving
if mlist.archive:
archiveurl = mlist.GetBaseArchiveURL()
- if archiveurl.endswith('/'):
+ if archiveurl.endswith('/') and archiveurl.find("private") == -1:
archiveurl = archiveurl[:-1]
headers['List-Archive'] = '<%s>' % archiveurl
# First we delete any pre-existing headers because the RFC permits only

This list's content filtering removes attachments which have MIME types
other than text/plain.

I don't know. It's been there since the beginning of Mailman 2.1, but I
don't know why.


Neither am I sure what it was for. It doesn't matter much either way
for the public 'pipermail' URLs because the browser knows whether it
is serving a file or an index document and informs the browser, but it
does matter for private URLs.

In fact, I have a bigger problem with users typing archive URLs without
the slash, so I have in Apache

RewriteEngine on
RewriteCond %{REQUEST_URI} ![.][^/]+$
RewriteRule ^/mailman/(private/.*[^/])$ http://%{HTTP_HOST}/mailman/$1/
[L,R]

to append a slash to the end of any /mailman/private/* url that doesn't
end with a slash or a file extension.

At present, there are no more 2.1.x releases planned, but I'll stop
removing the slash for 2.2.

That should have been "... the web server knows ..."