Tom Lane wrote:
Andrew Dunstan <andrew@dunslane.net> writes:
Actually, it appears to me that we have a 100% solution.
Yeah --- "friends don't let friends use Windows" ...

Is there any part of this discussion that does not amount to documenting
Redmond's bugs?

I'm perfectly happy to back out the slash-to-backslash conversion I
committed a bit ago, but I'm worried about what else is coming down
the pike.
I did enough tests to realize that we have done the best we can with
Win32 COPY. It is OK with forward slashes in the second argument but
not the first.

The attached applied patch cleans up our implementation and documents
its purpose. I also added some examples for 'archive_command'.

--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

Search Discussions

  • Tom Lane at Aug 12, 2004 at 6:38 pm

    Bruce Momjian writes:
    The attached applied patch cleans up our implementation and documents
    its purpose. I also added some examples for 'archive_command'.
    If you're going to do that, do it in both places ... you missed
    pgarch.c.

    Also, I would say that the large block comment belongs with
    make_native_path, not with its caller.
    ! #
    # If archive_command is '' then archiving is disabled. Otherwise, set it
    ! # to a command to copy a file to the proper place. Any %p in the string
    ! # is replaced by the absolute path of the file to archive, while any %f is
    ! # replaced by the file name only. NOTE: it is important for the command to
    ! # return zero exit status only if it succeeds.
    ! #
    ! # Examples:
    ! # archive_command = 'cp "%p" /mnt/server/archivedir/"%f"'
    ! # archive_command = 'copy "%p" /mnt/server/archivedir/"%f"' # Win32
    !
    This text should probably be removed from postgresql.conf.sample
    altogether; we are not in the habit of providing more than one-line
    documentation there. I stuck it in there as a quick and dirty thing
    because we didn't have archive_command in the SGML docs at the time.
    But now we do, and I'd say this info should be moved to runtime.sgml.

    regards, tom lane
  • Bruce Momjian at Aug 12, 2004 at 7:05 pm
    OK, patch attached and applied.

    ---------------------------------------------------------------------------

    Tom Lane wrote:
    Bruce Momjian <pgman@candle.pha.pa.us> writes:
    The attached applied patch cleans up our implementation and documents
    its purpose. I also added some examples for 'archive_command'.
    If you're going to do that, do it in both places ... you missed
    pgarch.c.

    Also, I would say that the large block comment belongs with
    make_native_path, not with its caller.
    ! #
    # If archive_command is '' then archiving is disabled. Otherwise, set it
    ! # to a command to copy a file to the proper place. Any %p in the string
    ! # is replaced by the absolute path of the file to archive, while any %f is
    ! # replaced by the file name only. NOTE: it is important for the command to
    ! # return zero exit status only if it succeeds.
    ! #
    ! # Examples:
    ! # archive_command = 'cp "%p" /mnt/server/archivedir/"%f"'
    ! # archive_command = 'copy "%p" /mnt/server/archivedir/"%f"' # Win32
    !
    This text should probably be removed from postgresql.conf.sample
    altogether; we are not in the habit of providing more than one-line
    documentation there. I stuck it in there as a quick and dirty thing
    because we didn't have archive_command in the SGML docs at the time.
    But now we do, and I'd say this info should be moved to runtime.sgml.

    regards, tom lane
    --
    Bruce Momjian | http://candle.pha.pa.us
    pgman@candle.pha.pa.us | (610) 359-1001
    + If your life is a hard drive, | 13 Roberts Road
    + Christ can be your backup. | Newtown Square, Pennsylvania 19073

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
grouppgsql-patches @
categoriespostgresql
postedAug 12, '04 at 6:30p
activeAug 12, '04 at 7:05p
posts3
users2
websitepostgresql.org
irc#postgresql

2 users in discussion

Bruce Momjian: 2 posts Tom Lane: 1 post

People

Translate

site design / logo © 2021 Grokbase