Here is a first patch to slightly refactor the type and typmod lookups
with the aim of making it easier to possibly changing the nature or
representation of typmods in the future and making it easier to merge
the collation patch.

I split the typenameTypeId function into two. Most call sites only care
about the type OID; a second function typenameTypeIdAndMod returns type
ID and typmod. So it is more explicit about which places care about
what. It also cuts down on the unholy interface design of returning
half the return value via function result and the other half via an
argument pointer.

Search Discussions

  • Tom Lane at Oct 24, 2010 at 8:53 pm

    Peter Eisentraut writes:
    Here is a first patch to slightly refactor the type and typmod lookups
    with the aim of making it easier to possibly changing the nature or
    representation of typmods in the future and making it easier to merge
    the collation patch.
    The comment for typenameTypeIdAndMod could use a bit of adjustment
    maybe (it's not "only handing back the OID"); otherwise seems fine.

    regards, tom lane

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
grouppgsql-hackers @
categoriespostgresql
postedOct 24, '10 at 7:42p
activeOct 24, '10 at 8:53p
posts2
users2
websitepostgresql.org...
irc#postgresql

2 users in discussion

Peter Eisentraut: 1 post Tom Lane: 1 post

People

Translate

site design / logo © 2022 Grokbase