[Pig-dev] [jira] Created: (PIG-1852) Packaging antlr jar with pig.jar

[ https://issues.apache.org/jira/browse/PIG-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard Ding updated PIG-1852:
------------------------------

Attachment: PIG-1852.patch

[ https://issues.apache.org/jira/browse/PIG-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12993688#comment-12993688 ]

Ashutosh Chauhan commented on PIG-1852:
---------------------------------------

antlr shouldn't be pig-withouthadoop.jar since its a client side dependency. pig-withouthadoop.jar gets shipped to task nodes, we should not add anything in it which is not needed in backend.

[ https://issues.apache.org/jira/browse/PIG-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12993692#comment-12993692 ]

Ashutosh Chauhan commented on PIG-1852:
---------------------------------------

Also, antlr.jar is required only while compiling pig, antlr-runtime.jar should be used instead in pig.jar

[ https://issues.apache.org/jira/browse/PIG-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12993728#comment-12993728 ]

Richard Ding commented on PIG-1852:
-----------------------------------

Ashutosh, you're right. But the antlr-3.2.jar Pig uses now is actually antlr[all].jar. What Pig needs is to pull the various antlr jars from apache maven repository (PIG-1583).

[ https://issues.apache.org/jira/browse/PIG-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12993734#comment-12993734 ]

Daniel Dai commented on PIG-1852:
---------------------------------

Ideally we should pack antlr-runtime.jar only. However, it seems antlr-runtime.jar is not enough, we have problem in running pig if we only pack antlr-runtime.jar. For now, we can pack antlr.jar so Pig can run. Later we can figure out how to optimize antlr.jar.

[ https://issues.apache.org/jira/browse/PIG-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard Ding resolved PIG-1852.
-------------------------------

Resolution: Fixed
Hadoop Flags: [Reviewed]

patch committed to trunk