[Pig-dev] [jira] Created: (PIG-1566) Support globbing for registering jars in pig script.

[ https://issues.apache.org/jira/browse/PIG-1566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olga Natkovich updated PIG-1566:
--------------------------------

Fix Version/s: 0.9.0
(was: 0.8.0)

It is too late to do this for 0.8 since we are about to branch. We can consider this for 0.9 especially if we have volunteers for this work

[ https://issues.apache.org/jira/browse/PIG-1566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olga Natkovich reassigned PIG-1566:
-----------------------------------

Assignee: niraj rai

[ https://issues.apache.org/jira/browse/PIG-1566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

niraj rai updated PIG-1566:
---------------------------

Attachment: PIG_1566_0.patch

Patch to support globbing.

[ https://issues.apache.org/jira/browse/PIG-1566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925093#action_12925093 ]

Olga Natkovich commented on PIG-1566:
-------------------------------------

please, remember to add release notes to the ticket so that the information can be included in 0.9 documentation

[ https://issues.apache.org/jira/browse/PIG-1566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925987#action_12925987 ]

Daniel Dai commented on PIG-1566:
---------------------------------

Some comments:
1. What does line 440: "final String jName = tempJarName.replaceAll("\\*", ".*");" mean?
2. If "register /homes/aaa/*.jar", the patch will also register all jars in classpath, which is wrong. We shall still use ClassLoader.getSystemResources.
3. Use Apache format: no tab, always space

[ https://issues.apache.org/jira/browse/PIG-1566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

niraj rai updated PIG-1566:
---------------------------

Attachment: PIG_1566_1.patch

Modified based on daniel comment.

[ https://issues.apache.org/jira/browse/PIG-1566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai updated PIG-1566:
----------------------------

Description:
Currently user can not register pig jars with globing.

For example following register script will fail.

{quote}
register /etc/jars/*.jar
{quote}

It will be great if we can support such globing for registering jars.

Release notes:
We allow globbing in register statement. User can use "*" to denote a globbing, eg:
register key*.jar
register /home/jarpath/key*.jar
register jars/key*.jar

The path can be absolute path or relative path start with working directory.

Note globbing does not further search in classpath as non-globbing case does, eg:
"register key1234.jar" works if key1234.jar in classpath, but not in working directory, however,
"register key*.jar" will not locate key1234.jar in this case.


was:
Currently user can not register pig jars with globing.

For example following register script will fail.

{quote}
register /etc/jars/*.jar
{quote}

It will be great if we can support such globing for registering jars.