Grokbase Groups Pig dev August 2010
FAQ
Incorrect assert statements in operator evaluation
--------------------------------------------------

Key: PIG-1546
URL: https://issues.apache.org/jira/browse/PIG-1546
Project: Pig
Issue Type: Bug
Components: impl
Affects Versions: 0.7.0
Reporter: Ajay Kidave
Assignee: Ajay Kidave
Priority: Minor
Fix For: 0.8.0


The physical operator evaluation code path for <, <=, > and >= have incorrect assert statements. These asserts fail if the jvm have asserts enabled.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Search Discussions

  • Ajay Kidave (JIRA) at Aug 16, 2010 at 10:30 pm
    [ https://issues.apache.org/jira/browse/PIG-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12899140#action_12899140 ]

    Ajay Kidave commented on PIG-1546:
    ----------------------------------

    The failure stack trace is

    junit] java.lang.AssertionError [junit] at org.apache.pig.backend.hadoop.executionengine.physicalLayer.expressionOperators.GreaterThanExpr.doComparison(GreaterThanExpr.java:150)
    [junit] at org.apache.pig.backend.hadoop.executionengine.physicalLayer.expressionOperators.GreaterThanExpr.getNext(GreaterThanExpr.java:104)
    [junit] at org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POFilter.getNext(POFilter.java:148)
    [junit] at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigMapBase.runPipeline(PigMapBase.java:232)
    [junit] at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigMapBase.map(PigMapBase.java:227)
    [junit] at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer

    Incorrect assert statements in operator evaluation
    --------------------------------------------------

    Key: PIG-1546
    URL: https://issues.apache.org/jira/browse/PIG-1546
    Project: Pig
    Issue Type: Bug
    Components: impl
    Affects Versions: 0.7.0
    Reporter: Ajay Kidave
    Assignee: Ajay Kidave
    Priority: Minor
    Fix For: 0.8.0


    The physical operator evaluation code path for <, <=, > and >= have incorrect assert statements. These asserts fail if the jvm have asserts enabled.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Ajay Kidave (JIRA) at Aug 16, 2010 at 10:41 pm
    [ https://issues.apache.org/jira/browse/PIG-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Ajay Kidave updated PIG-1546:
    -----------------------------

    Attachment: pig_1546.patch

    Patch fixing the incorrect asserts and adding a test case. The test case is valid only if hadoop processes are run under a jvm having asserts enabled. So enabled asserts for all test cases as part of this patch.
    Incorrect assert statements in operator evaluation
    --------------------------------------------------

    Key: PIG-1546
    URL: https://issues.apache.org/jira/browse/PIG-1546
    Project: Pig
    Issue Type: Bug
    Components: impl
    Affects Versions: 0.7.0
    Reporter: Ajay Kidave
    Assignee: Ajay Kidave
    Priority: Minor
    Fix For: 0.8.0

    Attachments: pig_1546.patch


    The physical operator evaluation code path for <, <=, > and >= have incorrect assert statements. These asserts fail if the jvm have asserts enabled.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Ajay Kidave (JIRA) at Aug 16, 2010 at 10:43 pm
    [ https://issues.apache.org/jira/browse/PIG-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Ajay Kidave updated PIG-1546:
    -----------------------------

    Status: Patch Available (was: Open)

    Patch attached.
    Incorrect assert statements in operator evaluation
    --------------------------------------------------

    Key: PIG-1546
    URL: https://issues.apache.org/jira/browse/PIG-1546
    Project: Pig
    Issue Type: Bug
    Components: impl
    Affects Versions: 0.7.0
    Reporter: Ajay Kidave
    Assignee: Ajay Kidave
    Priority: Minor
    Fix For: 0.8.0

    Attachments: pig_1546.patch


    The physical operator evaluation code path for <, <=, > and >= have incorrect assert statements. These asserts fail if the jvm have asserts enabled.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Pradeep Kamath (JIRA) at Aug 17, 2010 at 8:37 pm
    [ https://issues.apache.org/jira/browse/PIG-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12899566#action_12899566 ]

    Pradeep Kamath commented on PIG-1546:
    -------------------------------------

    Results from running the "test-patch" ant target
    [exec] +1 overall.
    [exec]
    [exec] +1 @author. The patch does not contain any @author tags.
    [exec]
    [exec] +1 tests included. The patch appears to include 3 new or modified tests.
    [exec]
    [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
    [exec]
    [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
    [exec]
    [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
    [exec]
    [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.

    Incorrect assert statements in operator evaluation
    --------------------------------------------------

    Key: PIG-1546
    URL: https://issues.apache.org/jira/browse/PIG-1546
    Project: Pig
    Issue Type: Bug
    Components: impl
    Affects Versions: 0.7.0
    Reporter: Ajay Kidave
    Assignee: Ajay Kidave
    Priority: Minor
    Fix For: 0.8.0

    Attachments: pig_1546.patch


    The physical operator evaluation code path for <, <=, > and >= have incorrect assert statements. These asserts fail if the jvm have asserts enabled.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Ajay Kidave (JIRA) at Aug 17, 2010 at 8:39 pm
    [ https://issues.apache.org/jira/browse/PIG-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12899569#action_12899569 ]

    Ajay Kidave commented on PIG-1546:
    ----------------------------------

    All the units tests were run and passed.
    Incorrect assert statements in operator evaluation
    --------------------------------------------------

    Key: PIG-1546
    URL: https://issues.apache.org/jira/browse/PIG-1546
    Project: Pig
    Issue Type: Bug
    Components: impl
    Affects Versions: 0.7.0
    Reporter: Ajay Kidave
    Assignee: Ajay Kidave
    Priority: Minor
    Fix For: 0.8.0

    Attachments: pig_1546.patch


    The physical operator evaluation code path for <, <=, > and >= have incorrect assert statements. These asserts fail if the jvm have asserts enabled.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Pradeep Kamath (JIRA) at Aug 17, 2010 at 8:43 pm
    [ https://issues.apache.org/jira/browse/PIG-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Pradeep Kamath updated PIG-1546:
    --------------------------------

    Status: Resolved (was: Patch Available)
    Hadoop Flags: [Reviewed]
    Resolution: Fixed

    Patch committed - thanks Ajay!
    Incorrect assert statements in operator evaluation
    --------------------------------------------------

    Key: PIG-1546
    URL: https://issues.apache.org/jira/browse/PIG-1546
    Project: Pig
    Issue Type: Bug
    Components: impl
    Affects Versions: 0.7.0
    Reporter: Ajay Kidave
    Assignee: Ajay Kidave
    Priority: Minor
    Fix For: 0.8.0

    Attachments: pig_1546.patch


    The physical operator evaluation code path for <, <=, > and >= have incorrect assert statements. These asserts fail if the jvm have asserts enabled.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupdev @
categoriespig, hadoop
postedAug 16, '10 at 10:30p
activeAug 17, '10 at 8:43p
posts7
users1
websitepig.apache.org

1 user in discussion

Pradeep Kamath (JIRA): 7 posts

People

Translate

site design / logo © 2022 Grokbase