[Pig-dev] [jira] Commented: (PIG-348) -j command line option doesn't work

[ https://issues.apache.org/jira/browse/PIG-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889408#action_12889408 ]

Olga Natkovich commented on PIG-348:
------------------------------------

I am ok with this approach. Given that the option has been broken fo a while, I don't think we would be breaking backward compatibility.

[ https://issues.apache.org/jira/browse/PIG-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12891795#action_12891795 ]

Richard Ding commented on PIG-348:
----------------------------------

I'll first remove the -j option from source code.

[ https://issues.apache.org/jira/browse/PIG-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12891820#action_12891820 ]

Olga Natkovich commented on PIG-348:
------------------------------------

+1, changes look good

[ https://issues.apache.org/jira/browse/PIG-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12891827#action_12891827 ]

Richard Ding commented on PIG-348:
----------------------------------


test-patch results:

{code}
[exec] +1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 3 new or modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
[exec]
{code}

[ https://issues.apache.org/jira/browse/PIG-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892663#action_12892663 ]

Hadoop QA commented on PIG-348:
-------------------------------

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12450362/PIG-348.path
against trunk revision 979503.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 3 new or modified tests.

-1 patch. The patch command could not apply the patch.

Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h8.grid.sp2.yahoo.net/357/console

This message is automatically generated.

[ https://issues.apache.org/jira/browse/PIG-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892844#action_12892844 ]

Richard Ding commented on PIG-348:
----------------------------------

committed the patch to trunk.

[ https://issues.apache.org/jira/browse/PIG-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892842#action_12892842 ]

Richard Ding commented on PIG-348:
----------------------------------

Manually ran and passed core tests.