Grokbase Groups Pig dev May 2010
FAQ
Make PigServer can handle files with parameters
-----------------------------------------------

Key: PIG-1410
URL: https://issues.apache.org/jira/browse/PIG-1410
Project: Pig
Issue Type: Improvement
Reporter: Jeff Zhang
Assignee: Jeff Zhang
Fix For: 0.8.0


The current PigServer only support handle files without parameters, this task is to extend PigServer's API.
Add there public methods:

{code}
public void registerScript(String fileName, Map<String,String> params) // put the parameters in the Map data datastructure
public void registerScript(String fileName, List<String> paramsFiles) // put the parameters in the files
public void registerScript(String fileName, Map<String,String> params,List<String> paramsFiles) // put the parameter both in files and Map, the Map should override the parameter file if they have the same parameters
{code}

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Search Discussions

  • Jeff Zhang (JIRA) at May 10, 2010 at 4:54 am
    [ https://issues.apache.org/jira/browse/PIG-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Jeff Zhang updated PIG-1410:
    ----------------------------

    Attachment: Pig_1410.patch
    Make PigServer can handle files with parameters
    -----------------------------------------------

    Key: PIG-1410
    URL: https://issues.apache.org/jira/browse/PIG-1410
    Project: Pig
    Issue Type: Improvement
    Affects Versions: 0.8.0
    Reporter: Jeff Zhang
    Assignee: Jeff Zhang
    Fix For: 0.8.0

    Attachments: Pig_1410.patch


    The current PigServer only support handle files without parameters, this task is to extend PigServer's API.
    Add there public methods:

    {code}
    public void registerScript(String fileName, Map<String,String> params) // put the parameters in the Map data datastructure
    public void registerScript(String fileName, List<String> paramsFiles) // put the parameters in the files
    public void registerScript(String fileName, Map<String,String> params,List<String> paramsFiles) // put the parameter both in files and Map, the Map should override the parameter file if they have the same parameters
    {code}
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Jeff Zhang (JIRA) at May 10, 2010 at 4:54 am
    [ https://issues.apache.org/jira/browse/PIG-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Jeff Zhang updated PIG-1410:
    ----------------------------

    Status: Patch Available (was: Open)
    Affects Version/s: 0.8.0
    Make PigServer can handle files with parameters
    -----------------------------------------------

    Key: PIG-1410
    URL: https://issues.apache.org/jira/browse/PIG-1410
    Project: Pig
    Issue Type: Improvement
    Affects Versions: 0.8.0
    Reporter: Jeff Zhang
    Assignee: Jeff Zhang
    Fix For: 0.8.0

    Attachments: Pig_1410.patch


    The current PigServer only support handle files without parameters, this task is to extend PigServer's API.
    Add there public methods:

    {code}
    public void registerScript(String fileName, Map<String,String> params) // put the parameters in the Map data datastructure
    public void registerScript(String fileName, List<String> paramsFiles) // put the parameters in the files
    public void registerScript(String fileName, Map<String,String> params,List<String> paramsFiles) // put the parameter both in files and Map, the Map should override the parameter file if they have the same parameters
    {code}
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Hadoop QA (JIRA) at May 10, 2010 at 10:29 am
    [ https://issues.apache.org/jira/browse/PIG-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12865722#action_12865722 ]

    Hadoop QA commented on PIG-1410:
    --------------------------------

    +1 overall. Here are the results of testing the latest attachment
    http://issues.apache.org/jira/secure/attachment/12444081/Pig_1410.patch
    against trunk revision 941976.

    +1 @author. The patch does not contain any @author tags.

    +1 tests included. The patch appears to include 11 new or modified tests.

    +1 javadoc. The javadoc tool did not generate any warning messages.

    +1 javac. The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs. The patch does not introduce any new Findbugs warnings.

    +1 release audit. The applied patch does not increase the total number of release audit warnings.

    +1 core tests. The patch passed core unit tests.

    +1 contrib tests. The patch passed contrib unit tests.

    Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/321/testReport/
    Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/321/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
    Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/321/console

    This message is automatically generated.
    Make PigServer can handle files with parameters
    -----------------------------------------------

    Key: PIG-1410
    URL: https://issues.apache.org/jira/browse/PIG-1410
    Project: Pig
    Issue Type: Improvement
    Affects Versions: 0.8.0
    Reporter: Jeff Zhang
    Assignee: Jeff Zhang
    Fix For: 0.8.0

    Attachments: Pig_1410.patch


    The current PigServer only support handle files without parameters, this task is to extend PigServer's API.
    Add there public methods:

    {code}
    public void registerScript(String fileName, Map<String,String> params) // put the parameters in the Map data datastructure
    public void registerScript(String fileName, List<String> paramsFiles) // put the parameters in the files
    public void registerScript(String fileName, Map<String,String> params,List<String> paramsFiles) // put the parameter both in files and Map, the Map should override the parameter file if they have the same parameters
    {code}
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Alan Gates (JIRA) at May 10, 2010 at 10:51 pm
    [ https://issues.apache.org/jira/browse/PIG-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12865967#action_12865967 ]

    Alan Gates commented on PIG-1410:
    ---------------------------------

    Comments:

    # The catch blocks in registerScript(String, Map<String, String>, List<String>) need to be filled out. They shouldn't be dumping stack traces to standard out but instead should use the logging mechanism.
    # The existing registerScript(String) should be rewritten in terms of registerScript(String, Map<String, String>, List<String>). That way there is only one "real" method doing hte work.
    # (this one's a nitpick) registerScript(String, Map<String, String>) and registerScript(String, List<String>) create empty lists and maps, and then the real registerScript checks if those are empty and then treats them as null. Why not just pass nulls?
    Make PigServer can handle files with parameters
    -----------------------------------------------

    Key: PIG-1410
    URL: https://issues.apache.org/jira/browse/PIG-1410
    Project: Pig
    Issue Type: Improvement
    Affects Versions: 0.8.0
    Reporter: Jeff Zhang
    Assignee: Jeff Zhang
    Fix For: 0.8.0

    Attachments: Pig_1410.patch


    The current PigServer only support handle files without parameters, this task is to extend PigServer's API.
    Add there public methods:

    {code}
    public void registerScript(String fileName, Map<String,String> params) // put the parameters in the Map data datastructure
    public void registerScript(String fileName, List<String> paramsFiles) // put the parameters in the files
    public void registerScript(String fileName, Map<String,String> params,List<String> paramsFiles) // put the parameter both in files and Map, the Map should override the parameter file if they have the same parameters
    {code}
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Jeff Zhang (JIRA) at May 11, 2010 at 1:25 am
    [ https://issues.apache.org/jira/browse/PIG-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Jeff Zhang updated PIG-1410:
    ----------------------------

    Status: Open (was: Patch Available)
    Make PigServer can handle files with parameters
    -----------------------------------------------

    Key: PIG-1410
    URL: https://issues.apache.org/jira/browse/PIG-1410
    Project: Pig
    Issue Type: Improvement
    Affects Versions: 0.8.0
    Reporter: Jeff Zhang
    Assignee: Jeff Zhang
    Fix For: 0.8.0

    Attachments: Pig_1410.patch


    The current PigServer only support handle files without parameters, this task is to extend PigServer's API.
    Add there public methods:

    {code}
    public void registerScript(String fileName, Map<String,String> params) // put the parameters in the Map data datastructure
    public void registerScript(String fileName, List<String> paramsFiles) // put the parameters in the files
    public void registerScript(String fileName, Map<String,String> params,List<String> paramsFiles) // put the parameter both in files and Map, the Map should override the parameter file if they have the same parameters
    {code}
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Jeff Zhang (JIRA) at May 11, 2010 at 1:25 am
    [ https://issues.apache.org/jira/browse/PIG-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Jeff Zhang updated PIG-1410:
    ----------------------------

    Attachment: Pig_1410_2.patch

    Alan, thanks for your comments. I've updated the patch.
    Make PigServer can handle files with parameters
    -----------------------------------------------

    Key: PIG-1410
    URL: https://issues.apache.org/jira/browse/PIG-1410
    Project: Pig
    Issue Type: Improvement
    Affects Versions: 0.8.0
    Reporter: Jeff Zhang
    Assignee: Jeff Zhang
    Fix For: 0.8.0

    Attachments: Pig_1410.patch, Pig_1410_2.patch


    The current PigServer only support handle files without parameters, this task is to extend PigServer's API.
    Add there public methods:

    {code}
    public void registerScript(String fileName, Map<String,String> params) // put the parameters in the Map data datastructure
    public void registerScript(String fileName, List<String> paramsFiles) // put the parameters in the files
    public void registerScript(String fileName, Map<String,String> params,List<String> paramsFiles) // put the parameter both in files and Map, the Map should override the parameter file if they have the same parameters
    {code}
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Jeff Zhang (JIRA) at May 11, 2010 at 1:29 am
    [ https://issues.apache.org/jira/browse/PIG-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Jeff Zhang updated PIG-1410:
    ----------------------------

    Status: Patch Available (was: Open)
    Make PigServer can handle files with parameters
    -----------------------------------------------

    Key: PIG-1410
    URL: https://issues.apache.org/jira/browse/PIG-1410
    Project: Pig
    Issue Type: Improvement
    Affects Versions: 0.8.0
    Reporter: Jeff Zhang
    Assignee: Jeff Zhang
    Fix For: 0.8.0

    Attachments: Pig_1410.patch, Pig_1410_2.patch


    The current PigServer only support handle files without parameters, this task is to extend PigServer's API.
    Add there public methods:

    {code}
    public void registerScript(String fileName, Map<String,String> params) // put the parameters in the Map data datastructure
    public void registerScript(String fileName, List<String> paramsFiles) // put the parameters in the files
    public void registerScript(String fileName, Map<String,String> params,List<String> paramsFiles) // put the parameter both in files and Map, the Map should override the parameter file if they have the same parameters
    {code}
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Alan Gates (JIRA) at May 11, 2010 at 6:38 pm
    [ https://issues.apache.org/jira/browse/PIG-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12866262#action_12866262 ]

    Alan Gates commented on PIG-1410:
    ---------------------------------

    Looks good. +1
    Make PigServer can handle files with parameters
    -----------------------------------------------

    Key: PIG-1410
    URL: https://issues.apache.org/jira/browse/PIG-1410
    Project: Pig
    Issue Type: Improvement
    Affects Versions: 0.8.0
    Reporter: Jeff Zhang
    Assignee: Jeff Zhang
    Fix For: 0.8.0

    Attachments: Pig_1410.patch, Pig_1410_2.patch


    The current PigServer only support handle files without parameters, this task is to extend PigServer's API.
    Add there public methods:

    {code}
    public void registerScript(String fileName, Map<String,String> params) // put the parameters in the Map data datastructure
    public void registerScript(String fileName, List<String> paramsFiles) // put the parameters in the files
    public void registerScript(String fileName, Map<String,String> params,List<String> paramsFiles) // put the parameter both in files and Map, the Map should override the parameter file if they have the same parameters
    {code}
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Jeff Zhang (JIRA) at May 12, 2010 at 4:45 pm
    [ https://issues.apache.org/jira/browse/PIG-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12866623#action_12866623 ]

    Jeff Zhang commented on PIG-1410:
    ---------------------------------

    patch committed
    Make PigServer can handle files with parameters
    -----------------------------------------------

    Key: PIG-1410
    URL: https://issues.apache.org/jira/browse/PIG-1410
    Project: Pig
    Issue Type: Improvement
    Affects Versions: 0.8.0
    Reporter: Jeff Zhang
    Assignee: Jeff Zhang
    Fix For: 0.8.0

    Attachments: Pig_1410.patch, Pig_1410_2.patch


    The current PigServer only support handle files without parameters, this task is to extend PigServer's API.
    Add there public methods:

    {code}
    public void registerScript(String fileName, Map<String,String> params) // put the parameters in the Map data datastructure
    public void registerScript(String fileName, List<String> paramsFiles) // put the parameters in the files
    public void registerScript(String fileName, Map<String,String> params,List<String> paramsFiles) // put the parameter both in files and Map, the Map should override the parameter file if they have the same parameters
    {code}
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Olga Natkovich (JIRA) at May 12, 2010 at 5:21 pm
    [ https://issues.apache.org/jira/browse/PIG-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Olga Natkovich updated PIG-1410:
    --------------------------------

    Status: Resolved (was: Patch Available)
    Resolution: Fixed

    Thanks, Jeff!
    Make PigServer can handle files with parameters
    -----------------------------------------------

    Key: PIG-1410
    URL: https://issues.apache.org/jira/browse/PIG-1410
    Project: Pig
    Issue Type: Improvement
    Affects Versions: 0.8.0
    Reporter: Jeff Zhang
    Assignee: Jeff Zhang
    Fix For: 0.8.0

    Attachments: Pig_1410.patch, Pig_1410_2.patch


    The current PigServer only support handle files without parameters, this task is to extend PigServer's API.
    Add there public methods:

    {code}
    public void registerScript(String fileName, Map<String,String> params) // put the parameters in the Map data datastructure
    public void registerScript(String fileName, List<String> paramsFiles) // put the parameters in the files
    public void registerScript(String fileName, Map<String,String> params,List<String> paramsFiles) // put the parameter both in files and Map, the Map should override the parameter file if they have the same parameters
    {code}
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupdev @
categoriespig, hadoop
postedMay 10, '10 at 4:52a
activeMay 12, '10 at 5:21p
posts11
users1
websitepig.apache.org

1 user in discussion

Olga Natkovich (JIRA): 11 posts

People

Translate

site design / logo © 2022 Grokbase