Grokbase Groups Pig dev April 2009
FAQ
Do not support UDF not providing parameter
------------------------------------------

Key: PIG-753
URL: https://issues.apache.org/jira/browse/PIG-753
Project: Pig
Issue Type: Improvement
Reporter: Jeff Zhang


Pig do not support UDF without parameters, it force me provide a parameter.

like the following statement:

B = FOREACH A GENERATE bagGenerator(); this will generate error. I have to provide a parameter like following

B = FOREACH A GENERATE bagGenerator($0);





--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Search Discussions

  • David Ciemiewicz (JIRA) at Apr 8, 2009 at 5:32 pm
    [ https://issues.apache.org/jira/browse/PIG-753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12697108#action_12697108 ]

    David Ciemiewicz commented on PIG-753:
    --------------------------------------

    I think Jeff means that Pig does not support UDFs without parameters, but should.

    I agree.
    Do not support UDF not providing parameter
    ------------------------------------------

    Key: PIG-753
    URL: https://issues.apache.org/jira/browse/PIG-753
    Project: Pig
    Issue Type: Improvement
    Reporter: Jeff Zhang

    Pig do not support UDF without parameters, it force me provide a parameter.
    like the following statement:
    B = FOREACH A GENERATE bagGenerator(); this will generate error. I have to provide a parameter like following
    B = FOREACH A GENERATE bagGenerator($0);
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • David Ciemiewicz (JIRA) at Jun 1, 2009 at 5:30 am
    [ https://issues.apache.org/jira/browse/PIG-753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    David Ciemiewicz updated PIG-753:
    ---------------------------------

    Summary: Provide support for UDFs without parameters (was: Do not support UDF not providing parameter)
    Provide support for UDFs without parameters
    -------------------------------------------

    Key: PIG-753
    URL: https://issues.apache.org/jira/browse/PIG-753
    Project: Pig
    Issue Type: Improvement
    Reporter: Jeff Zhang

    Pig do not support UDF without parameters, it force me provide a parameter.
    like the following statement:
    B = FOREACH A GENERATE bagGenerator(); this will generate error. I have to provide a parameter like following
    B = FOREACH A GENERATE bagGenerator($0);
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Jeff Zhang (JIRA) at Jun 1, 2009 at 2:47 pm
    [ https://issues.apache.org/jira/browse/PIG-753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Jeff Zhang updated PIG-753:
    ---------------------------

    Attachment: Pig_753_Patch.txt

    attach the patch
    Provide support for UDFs without parameters
    -------------------------------------------

    Key: PIG-753
    URL: https://issues.apache.org/jira/browse/PIG-753
    Project: Pig
    Issue Type: Improvement
    Reporter: Jeff Zhang
    Attachments: Pig_753_Patch.txt


    Pig do not support UDF without parameters, it force me provide a parameter.
    like the following statement:
    B = FOREACH A GENERATE bagGenerator(); this will generate error. I have to provide a parameter like following
    B = FOREACH A GENERATE bagGenerator($0);
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Jeff Zhang (JIRA) at Jun 1, 2009 at 2:49 pm
    [ https://issues.apache.org/jira/browse/PIG-753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Jeff Zhang updated PIG-753:
    ---------------------------

    Fix Version/s: 0.3.0
    Affects Version/s: 0.3.0
    Status: Patch Available (was: Open)

    Submit the patch.
    Now we do not have to provider a parameter for UDF, zero-parameters UDF is also OK too.


    Provide support for UDFs without parameters
    -------------------------------------------

    Key: PIG-753
    URL: https://issues.apache.org/jira/browse/PIG-753
    Project: Pig
    Issue Type: Improvement
    Affects Versions: 0.3.0
    Reporter: Jeff Zhang
    Fix For: 0.3.0

    Attachments: Pig_753_Patch.txt


    Pig do not support UDF without parameters, it force me provide a parameter.
    like the following statement:
    B = FOREACH A GENERATE bagGenerator(); this will generate error. I have to provide a parameter like following
    B = FOREACH A GENERATE bagGenerator($0);
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Alan Gates (JIRA) at Jun 2, 2009 at 12:07 am
    [ https://issues.apache.org/jira/browse/PIG-753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12715312#action_12715312 ]

    Alan Gates commented on PIG-753:
    --------------------------------

    The patch should include a unit tests that to test whether a pig script will parse with a udf that has no parameters, and whether the backend will properly execute a udf that takes no parameters.
    Provide support for UDFs without parameters
    -------------------------------------------

    Key: PIG-753
    URL: https://issues.apache.org/jira/browse/PIG-753
    Project: Pig
    Issue Type: Improvement
    Affects Versions: 0.3.0
    Reporter: Jeff Zhang
    Fix For: 0.3.0

    Attachments: Pig_753_Patch.txt


    Pig do not support UDF without parameters, it force me provide a parameter.
    like the following statement:
    B = FOREACH A GENERATE bagGenerator(); this will generate error. I have to provide a parameter like following
    B = FOREACH A GENERATE bagGenerator($0);
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Alan Gates (JIRA) at Jun 2, 2009 at 12:07 am
    [ https://issues.apache.org/jira/browse/PIG-753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Alan Gates updated PIG-753:
    ---------------------------

    Status: Open (was: Patch Available)
    Provide support for UDFs without parameters
    -------------------------------------------

    Key: PIG-753
    URL: https://issues.apache.org/jira/browse/PIG-753
    Project: Pig
    Issue Type: Improvement
    Affects Versions: 0.3.0
    Reporter: Jeff Zhang
    Fix For: 0.3.0

    Attachments: Pig_753_Patch.txt


    Pig do not support UDF without parameters, it force me provide a parameter.
    like the following statement:
    B = FOREACH A GENERATE bagGenerator(); this will generate error. I have to provide a parameter like following
    B = FOREACH A GENERATE bagGenerator($0);
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Jeff Zhang (JIRA) at Jun 13, 2009 at 10:29 am
    [ https://issues.apache.org/jira/browse/PIG-753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Jeff Zhang updated PIG-753:
    ---------------------------

    Attachment: (was: Pig_753_Patch.txt)
    Provide support for UDFs without parameters
    -------------------------------------------

    Key: PIG-753
    URL: https://issues.apache.org/jira/browse/PIG-753
    Project: Pig
    Issue Type: Improvement
    Affects Versions: 0.3.0
    Reporter: Jeff Zhang
    Fix For: 0.3.0


    Pig do not support UDF without parameters, it force me provide a parameter.
    like the following statement:
    B = FOREACH A GENERATE bagGenerator(); this will generate error. I have to provide a parameter like following
    B = FOREACH A GENERATE bagGenerator($0);
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Jeff Zhang (JIRA) at Jun 13, 2009 at 10:31 am
    [ https://issues.apache.org/jira/browse/PIG-753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Jeff Zhang updated PIG-753:
    ---------------------------

    Attachment: Pig_753_Patch.txt

    attach the patch including the testcase
    Provide support for UDFs without parameters
    -------------------------------------------

    Key: PIG-753
    URL: https://issues.apache.org/jira/browse/PIG-753
    Project: Pig
    Issue Type: Improvement
    Affects Versions: 0.3.0
    Reporter: Jeff Zhang
    Fix For: 0.3.0

    Attachments: Pig_753_Patch.txt


    Pig do not support UDF without parameters, it force me provide a parameter.
    like the following statement:
    B = FOREACH A GENERATE bagGenerator(); this will generate error. I have to provide a parameter like following
    B = FOREACH A GENERATE bagGenerator($0);
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Alan Gates (JIRA) at Jun 13, 2009 at 5:02 pm
    [ https://issues.apache.org/jira/browse/PIG-753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Alan Gates updated PIG-753:
    ---------------------------

    Status: Patch Available (was: Open)

    Marking patch submitted so that hudson will pick it up.
    Provide support for UDFs without parameters
    -------------------------------------------

    Key: PIG-753
    URL: https://issues.apache.org/jira/browse/PIG-753
    Project: Pig
    Issue Type: Improvement
    Affects Versions: 0.3.0
    Reporter: Jeff Zhang
    Fix For: 0.3.0

    Attachments: Pig_753_Patch.txt


    Pig do not support UDF without parameters, it force me provide a parameter.
    like the following statement:
    B = FOREACH A GENERATE bagGenerator(); this will generate error. I have to provide a parameter like following
    B = FOREACH A GENERATE bagGenerator($0);
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Hadoop QA (JIRA) at Jun 15, 2009 at 10:13 am
    [ https://issues.apache.org/jira/browse/PIG-753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719501#action_12719501 ]

    Hadoop QA commented on PIG-753:
    -------------------------------

    -1 overall. Here are the results of testing the latest attachment
    http://issues.apache.org/jira/secure/attachment/12410538/Pig_753_Patch.txt
    against trunk revision 784333.

    +1 @author. The patch does not contain any @author tags.

    +1 tests included. The patch appears to include 7 new or modified tests.

    +1 javadoc. The javadoc tool did not generate any warning messages.

    +1 javac. The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs. The patch does not introduce any new Findbugs warnings.

    -1 release audit. The applied patch generated 162 release audit warnings (more than the trunk's current 160 warnings).

    -1 core tests. The patch failed core unit tests.

    +1 contrib tests. The patch passed contrib unit tests.

    Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/80/testReport/
    Release audit warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/80/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt
    Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/80/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
    Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/80/console

    This message is automatically generated.
    Provide support for UDFs without parameters
    -------------------------------------------

    Key: PIG-753
    URL: https://issues.apache.org/jira/browse/PIG-753
    Project: Pig
    Issue Type: Improvement
    Affects Versions: 0.3.0
    Reporter: Jeff Zhang
    Fix For: 0.3.0

    Attachments: Pig_753_Patch.txt


    Pig do not support UDF without parameters, it force me provide a parameter.
    like the following statement:
    B = FOREACH A GENERATE bagGenerator(); this will generate error. I have to provide a parameter like following
    B = FOREACH A GENERATE bagGenerator($0);
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Alan Gates (JIRA) at Jun 15, 2009 at 4:14 pm
    [ https://issues.apache.org/jira/browse/PIG-753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719616#action_12719616 ]

    Alan Gates commented on PIG-753:
    --------------------------------

    The test failures are in bzip tests, which I doubt are affected by this. I'll run them myself with the patch to check. But the release audit warnings are real. The two new test files need to have apache headers put on them. You can grab the header from any of the other java files.
    Provide support for UDFs without parameters
    -------------------------------------------

    Key: PIG-753
    URL: https://issues.apache.org/jira/browse/PIG-753
    Project: Pig
    Issue Type: Improvement
    Affects Versions: 0.3.0
    Reporter: Jeff Zhang
    Fix For: 0.3.0

    Attachments: Pig_753_Patch.txt


    Pig do not support UDF without parameters, it force me provide a parameter.
    like the following statement:
    B = FOREACH A GENERATE bagGenerator(); this will generate error. I have to provide a parameter like following
    B = FOREACH A GENERATE bagGenerator($0);
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Alan Gates (JIRA) at Jun 15, 2009 at 4:14 pm
    [ https://issues.apache.org/jira/browse/PIG-753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Alan Gates updated PIG-753:
    ---------------------------

    Status: Open (was: Patch Available)
    Provide support for UDFs without parameters
    -------------------------------------------

    Key: PIG-753
    URL: https://issues.apache.org/jira/browse/PIG-753
    Project: Pig
    Issue Type: Improvement
    Affects Versions: 0.3.0
    Reporter: Jeff Zhang
    Fix For: 0.3.0

    Attachments: Pig_753_Patch.txt


    Pig do not support UDF without parameters, it force me provide a parameter.
    like the following statement:
    B = FOREACH A GENERATE bagGenerator(); this will generate error. I have to provide a parameter like following
    B = FOREACH A GENERATE bagGenerator($0);
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Alan Gates (JIRA) at Jun 18, 2009 at 11:45 pm
    [ https://issues.apache.org/jira/browse/PIG-753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12721559#action_12721559 ]

    Alan Gates commented on PIG-753:
    --------------------------------

    +1

    I tested the patch, and the issue was just with the bzip tests.

    I'd like to have Santosh's opinion on this as he is the expert in the logical plan and type checker area where these changes are.
    Provide support for UDFs without parameters
    -------------------------------------------

    Key: PIG-753
    URL: https://issues.apache.org/jira/browse/PIG-753
    Project: Pig
    Issue Type: Improvement
    Affects Versions: 0.3.0
    Reporter: Jeff Zhang
    Attachments: Pig_753_Patch.txt


    Pig do not support UDF without parameters, it force me provide a parameter.
    like the following statement:
    B = FOREACH A GENERATE bagGenerator(); this will generate error. I have to provide a parameter like following
    B = FOREACH A GENERATE bagGenerator($0);
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Santhosh Srinivasan (JIRA) at Jun 18, 2009 at 11:53 pm
    [ https://issues.apache.org/jira/browse/PIG-753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12721564#action_12721564 ]

    Santhosh Srinivasan commented on PIG-753:
    -----------------------------------------

    +1 for the code changes. The license header and the unit tests that failed have to be checked.
    Provide support for UDFs without parameters
    -------------------------------------------

    Key: PIG-753
    URL: https://issues.apache.org/jira/browse/PIG-753
    Project: Pig
    Issue Type: Improvement
    Affects Versions: 0.3.0
    Reporter: Jeff Zhang
    Attachments: Pig_753_Patch.txt


    Pig do not support UDF without parameters, it force me provide a parameter.
    like the following statement:
    B = FOREACH A GENERATE bagGenerator(); this will generate error. I have to provide a parameter like following
    B = FOREACH A GENERATE bagGenerator($0);
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Alan Gates (JIRA) at Jun 19, 2009 at 4:17 am
    [ https://issues.apache.org/jira/browse/PIG-753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Alan Gates resolved PIG-753.
    ----------------------------

    Resolution: Fixed
    Fix Version/s: 0.4.0

    I added headers to the two test files. I reran the unit tests and the bzip (and all other) unit tests passed.

    Patch checked in. Thanks Jeff.
    Provide support for UDFs without parameters
    -------------------------------------------

    Key: PIG-753
    URL: https://issues.apache.org/jira/browse/PIG-753
    Project: Pig
    Issue Type: Improvement
    Affects Versions: 0.3.0
    Reporter: Jeff Zhang
    Fix For: 0.4.0

    Attachments: Pig_753_Patch.txt


    Pig do not support UDF without parameters, it force me provide a parameter.
    like the following statement:
    B = FOREACH A GENERATE bagGenerator(); this will generate error. I have to provide a parameter like following
    B = FOREACH A GENERATE bagGenerator($0);
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Hudson (JIRA) at Jun 19, 2009 at 11:43 am
    [ https://issues.apache.org/jira/browse/PIG-753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12721748#action_12721748 ]

    Hudson commented on PIG-753:
    ----------------------------

    Integrated in Pig-trunk #479 (See [http://hudson.zones.apache.org/hudson/job/Pig-trunk/479/])
    Allow UDFs with no parameters.

    Provide support for UDFs without parameters
    -------------------------------------------

    Key: PIG-753
    URL: https://issues.apache.org/jira/browse/PIG-753
    Project: Pig
    Issue Type: Improvement
    Affects Versions: 0.3.0
    Reporter: Jeff Zhang
    Fix For: 0.4.0

    Attachments: Pig_753_Patch.txt


    Pig do not support UDF without parameters, it force me provide a parameter.
    like the following statement:
    B = FOREACH A GENERATE bagGenerator(); this will generate error. I have to provide a parameter like following
    B = FOREACH A GENERATE bagGenerator($0);
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Alan Gates (JIRA) at Nov 12, 2009 at 1:53 am
    [ https://issues.apache.org/jira/browse/PIG-753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Alan Gates reassigned PIG-753:
    ------------------------------

    Assignee: Jeff Zhang
    Provide support for UDFs without parameters
    -------------------------------------------

    Key: PIG-753
    URL: https://issues.apache.org/jira/browse/PIG-753
    Project: Pig
    Issue Type: Improvement
    Affects Versions: 0.3.0
    Reporter: Jeff Zhang
    Assignee: Jeff Zhang
    Fix For: 0.4.0

    Attachments: Pig_753_Patch.txt


    Pig do not support UDF without parameters, it force me provide a parameter.
    like the following statement:
    B = FOREACH A GENERATE bagGenerator(); this will generate error. I have to provide a parameter like following
    B = FOREACH A GENERATE bagGenerator($0);
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupdev @
categoriespig, hadoop
postedApr 4, '09 at 12:25p
activeNov 12, '09 at 1:53a
posts18
users1
websitepig.apache.org

1 user in discussion

Alan Gates (JIRA): 18 posts

People

Translate

site design / logo © 2021 Grokbase