[Pig-dev] [jira] Created: (PIG-647) memory sized passed on pig command line does not get propagated to JobConf

[ https://issues.apache.org/jira/browse/PIG-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668291#action_12668291 ]

Olga Natkovich commented on PIG-647:
------------------------------------

if we pass this on command line, we still see -Dmapred.child.java.opts="-Xmx1024m"' , we don't see this reflected in JobConf passed to hadoop.

[ https://issues.apache.org/jira/browse/PIG-647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olga Natkovich reassigned PIG-647:
----------------------------------

Assignee: Santhosh Srinivasan

[ https://issues.apache.org/jira/browse/PIG-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668374#action_12668374 ]

Arun C Murthy commented on PIG-647:
-----------------------------------

Can we consider using org.apache.hadoop.uti.Tool (http://hadoop.apache.org/core/docs/r0.18.2/mapred_tutorial.html#Tool) ? You'd get all this for free...

[ https://issues.apache.org/jira/browse/PIG-647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Santhosh Srinivasan updated PIG-647:
------------------------------------

Attachment: PIG-647.patch

Attached patch fixes the issue with not passing the command line parameters to job configuration. The root cause of the issue was not overriding HOD's parameters with the command line parameters. There are no unit test cases as HOD testing is not covered in unit tests. Manual tests were performed to verify the fix.

[ https://issues.apache.org/jira/browse/PIG-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668743#action_12668743 ]

Alan Gates commented on PIG-647:
--------------------------------

+1

[ https://issues.apache.org/jira/browse/PIG-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668748#action_12668748 ]

Santhosh Srinivasan commented on PIG-647:
-----------------------------------------

All unit tests passed.

[ https://issues.apache.org/jira/browse/PIG-647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Santhosh Srinivasan resolved PIG-647.
-------------------------------------

Resolution: Fixed
Hadoop Flags: [Reviewed]

Patch has been committed.