FAQ

On Thu, May 15, 2014 at 8:17 PM, Ferenc Kovacs wrote:

On Wed, May 14, 2014 at 9:49 AM, Ferenc Kovacs wrote:



On Mon, May 12, 2014 at 8:35 AM, Yasuo Ohgaki wrote:

Commit: 2f9766fd02c061e89ae757760c2f2a432f1fe3a2
Author: Yasuo Ohgaki <yohgaki@php.net> Mon, 12 May 2014
14:56:11 +0900
Parents: 89798f57d4a6552b08efeee24bf54079b072c771
Branches: PHP-5.6 master

Link:
http://git.php.net/?p=php-src.git;a=commitdiff;h=2f9766fd02c061e89ae757760c2f2a432f1fe3a2

Log:
Update UPGRADING according to bug fix

Changed paths:
M UPGRADING


Diff:
diff --git a/UPGRADING b/UPGRADING
index faf66d1..7a174c4 100755
--- a/UPGRADING
+++ b/UPGRADING
@@ -476,3 +476,5 @@ PHP 5.6 UPGRADE NOTES
input_encoding
output_encoding

+ The mb_regex_encoding() default setting is changed from EUC-JP to
UTF-8.
+


--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
shouldn't mb_regex_encoding default to php.input_encoding instead of
'UTF-8'?
while testing this, I also noticed, that internal_encoding doesn't
defaults to default_charset, althought according to my understanding of the
original rfc, this should be the case:

[tyrael@ferencs-mbp-135 php-src.git (PHP-5.6 ✗)]$ ./sapi/cli/php -n -r
'var_dump(ini_get("internal_encoding"));'
string(0) ""
bringing this to internals@ for visibility.

ps: if somebody wonders, this is related to
https://wiki.php.net/rfc/default_encoding

--
Ferenc Kovács
@Tyr43l - http://tyrael.hu
aaand I've just forgot to actually cc internals@ in the previous mail.

--
Ferenc Kovács
@Tyr43l - http://tyrael.hu

Search Discussions

  • Ferenc Kovacs at May 17, 2014 at 6:09 am

    On Thu, May 15, 2014 at 8:17 PM, Ferenc Kovacs wrote:

    On Thu, May 15, 2014 at 8:17 PM, Ferenc Kovacs wrote:



    On Wed, May 14, 2014 at 9:49 AM, Ferenc Kovacs wrote:



    On Mon, May 12, 2014 at 8:35 AM, Yasuo Ohgaki wrote:

    Commit: 2f9766fd02c061e89ae757760c2f2a432f1fe3a2
    Author: Yasuo Ohgaki <yohgaki@php.net> Mon, 12 May 2014
    14:56:11 +0900
    Parents: 89798f57d4a6552b08efeee24bf54079b072c771
    Branches: PHP-5.6 master

    Link:
    http://git.php.net/?p=php-src.git;a=commitdiff;h=2f9766fd02c061e89ae757760c2f2a432f1fe3a2

    Log:
    Update UPGRADING according to bug fix

    Changed paths:
    M UPGRADING


    Diff:
    diff --git a/UPGRADING b/UPGRADING
    index faf66d1..7a174c4 100755
    --- a/UPGRADING
    +++ b/UPGRADING
    @@ -476,3 +476,5 @@ PHP 5.6 UPGRADE NOTES
    input_encoding
    output_encoding

    + The mb_regex_encoding() default setting is changed from EUC-JP to
    UTF-8.
    +


    --
    PHP CVS Mailing List (http://www.php.net/)
    To unsubscribe, visit: http://www.php.net/unsub.php
    shouldn't mb_regex_encoding default to php.input_encoding instead of
    'UTF-8'?
    while testing this, I also noticed, that internal_encoding doesn't
    defaults to default_charset, althought according to my understanding of the
    original rfc, this should be the case:

    [tyrael@ferencs-mbp-135 php-src.git (PHP-5.6 ✗)]$ ./sapi/cli/php -n -r
    'var_dump(ini_get("internal_encoding"));'
    string(0) ""
    bringing this to internals@ for visibility.

    ps: if somebody wonders, this is related to
    https://wiki.php.net/rfc/default_encoding

    --
    Ferenc Kovács
    @Tyr43l - http://tyrael.hu
    aaand I've just forgot to actually cc internals@ in the previous mail.
    could anybody verify this?

    --
    Ferenc Kovács
    @Tyr43l - http://tyrael.hu
  • Yasuo Ohgaki at May 19, 2014 at 12:23 am
    Hi Ferenc,
    On Sat, May 17, 2014 at 3:09 PM, Ferenc Kovacs wrote:

    could anybody verify this?

    It was hardcoded default. Therefore, I changed the default according to RFC.
    I don't mind make it use internal encoding at all.
    In fact, I prefer to use internal encoding rather than using hardcoded
    default.

    Regards,

    --
    Yasuo Ohgaki
    yohgaki@ohgaki.net
  • Yasuo Ohgaki at May 19, 2014 at 12:41 am

    On Mon, May 19, 2014 at 9:22 AM, Yasuo Ohgaki wrote:
    On Sat, May 17, 2014 at 3:09 PM, Ferenc Kovacs wrote:

    could anybody verify this?

    It was hardcoded default. Therefore, I changed the default according to
    RFC.
    I don't mind make it use internal encoding at all.
    In fact, I prefer to use internal encoding rather than using hardcoded
    default.
    I should mention that there is one issue.
    Encodings that are supported by Oniguruma and libmbfl differs.
    libmbfl supports more encodings than Oniguruma. Users may
    experience errors/wrong behaviors when they use unsupported encoding.
    The same applies to iconv also.

    Therefore, it may be safer using hardcoded default and encourage
    users to use proper encoding with mb regex. I prefer setting mb regex
    encoding to internal encoding, though.

    Currently, mb regex does not have automatic encoding conversion.
    It may be better to convert encoding to hardcoded default or user
    setting.

    There is no perfect & feasible solution now.

    Regards,

    --
    Yasuo Ohgaki
    yohgaki@ohgaki.net

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupphp-internals @
categoriesphp
postedMay 15, '14 at 6:17p
activeMay 19, '14 at 12:41a
posts4
users2
websitephp.net

2 users in discussion

Yasuo Ohgaki: 2 posts Ferenc Kovacs: 2 posts

People

Translate

site design / logo © 2022 Grokbase