On 10/28/2013 11:45 AM, Joe Watkins wrote: On 10/28/2013 11:42 AM, Julien Pauli wrote:http://lxr.php.net/search?q=&defs=&refs=php_log_err&path=&hist=&project=PHP_5_5 On Mon, Oct 28, 2013 at 12:11 PM, Joe Watkins wrote: On 10/28/2013 10:50 AM, Julien Pauli wrote:
On Sun, Oct 27, 2013 at 7:14 AM, Joe Watkins <email@example.com
On 10/26/2013 11:54 PM, Yasuo Ohgaki wrote:
On Sun, Oct 27, 2013 at 7:48 AM, Yasuo Ohgaki <firstname.lastname@example.org
On Sat, Oct 26, 2013 at 2:38 PM, Joe Watkins
<email@example.com >>>>> wrote:
Mail is not yet handled, TCP/IP is not supported any more,
streams are binary safe.
The SAPI and default error logging mechanism are all that
The patch is not final and doesn't include a fix for every
implementation of SAPI.
I don't see the need for confusion ??
Generally speaking, I'm not against making functions/features
There are many implementations of syslog/SAPI and not sure
is good for all.
It could cause BC issue also. For example, application like
possible intrusion by analyzing logs. Patching SAPI may break
I'm not against applying your patch to master, but it's not for
We needs UPGRADE note if the patch is applied.
I think it's good for master.
Do you have commit karma?
If not, I'm willing to merge your patch unless there are not
I don't have karma ...
There are lots of SAPI's, but this patch wasn't meant to implement
all, only to provide a route whereby they can implement binary safe
log_message in the shape of log_message_ex.
The patch implements binsafe log for cli and cgi, do we need to
any more ??
Joe: Why do you use strlen() ? This leads to the same not binary safe
string, am I wrong ??https://github.com/krakjoe/**php-src/commit/**
(sorry if you got this twice, my interweb is playing up)
The binary safe logging interface for SAPI is log_message_ex
the binary safe logging function for php is php_log_err_ex
The old function must remain, and use string length just as
I see, that means that the actual patch does not turn logging to binary
safe logs, but gives functions for that.
Turning logs to binary safe would then mean tracking every unsafe log
function (php_log_err()) and turn it to php_log_err_ex() with an explicit
Not the enormous task you imagine it to be :)
Actually, looking at the one occurrence of php_err_log in mysqlnd, it
doesn't need updating because it's not being used, the call to
mysqlnd_get_backtrace is wrong ...
When it is in use, the backtrace provides a length and so we can switch
to php_err_log_ex easily.
So, there isn't anything else to change, or not neceesarily ...
What there is to consider is Apache and FPM:
Apaches logging functions don't accept a length because they are
I'm reluctant to touch apache logging at all, it could be a massive BC
APR has functions for logging data that do accept a length and would be
binary safe, however, I've never used them, we want an apache geek
really to look at that ...
FPM has a custom logging interface (zlog) that doesn't accept a length
either, I've not looked too deeply into FPM, I'm not sure, do we have an
"fpm" expert to turn to, it never really comes up ??
Theese should be updated to use binary safe logging (log_message_ex),
I've looked into the most popular, updated the cli and cgi versions for
Oh an the mail function, php_mail, also doesn't accept a length ...
Not sure where to go from here ...