[PHP-INTERNALS] Adding new MIME types for the CLI web server

Hi,

Christopher Jones wrote:
FYI that's not the correct mime type for mp4 -
http://www.rfc-editor.org/rfc/rfc4337.txt

The exact mime type depends on the content of the file, but
'video/mp4' would be more appropriate than 'video/mpeg'.

cheers
Dan

On Fri, Oct 25, 2013 at 7:55 PM, Christopher Jones
wrote:

My mistake. Thanks for picking it up.

Chris

I had feedback from one person who suggested adding these:

          { "3gp", "video/3gpp" }, //This is standard video format used for MMS in phones
          { "apk", "application/vnd.android.package-archive" },
          { "avi", "video/x-msvideo" },
          { "bmp", "image/x-ms-bmp" },
          { "csv", "text/comma-separated-values" },
          { "doc", "application/msword" },
          { "docx", "application/msword" },
          { "flac", "audio/flac" },
          { "gz", "application/x-gzip" },
          { "gzip", "application/x-gzip" },
          { "ics", "text/calendar" },
          { "kml", "application/vnd.google-earth.kml+xml" },
          { "kmz", "application/vnd.google-earth.kmz" },
          { "m4a", "audio/mp4" },
          { "mp3", "audio/mpeg" },
          { "mp4", "video/mp4" },
          { "mpg", "video/mpeg" },
          { "mpeg", "video/mpeg" },
          { "mov", "video/quicktime" },
          { "odp", "application/vnd.oasis.opendocument.presentation" },
          { "ods", "application/vnd.oasis.opendocument.spreadsheet" },
          { "odt", "application/vnd.oasis.opendocument.text" },
          { "oga", "audio/ogg" },
          { "pdf", "application/pdf" },
          { "pptx", "application/vnd.ms-powerpoint" },
          { "pps", "application/vnd.ms-powerpoint" },
          { "qt", "video/quicktime" },
          { "swf", "application/x-shockwave-flash" },
          { "tar", "application/x-tar" },
          { "text", "text/plain" },
          { "tif", "image/tiff" },
          { "wav", "audio/wav" },
          { "wmv", "video/x-ms-wmv" },
          { "xls", "application/vnd.ms-excel" },
          { "xlsx", "application/vnd.ms-excel" },
          { "zip", "application/x-zip-compressed"


The PHP CLI web server 5.5 currrently supports these MIME types natively:

  { "html", "text/html" },
  { "htm", "text/html" },
  { "js", "text/javascript" },
  { "css", "text/css" },
  { "gif", "image/gif" },
  { "jpg", "image/jpeg" },
  { "jpeg", "image/jpeg" },
  { "jpe", "image/jpeg" },
  { "png", "image/png" },
  { "svg", "image/svg+xml" },
  { "txt", "text/plain" },
  { "webm", "video/webm" },
  { "ogv", "video/ogg" },
  { "ogg", "audio/ogg" },


Final comments anyone, before I commit next week?

Chris

Isn't there a reason why you can't use the fileinfo extension/code for
this instead? Hardcoding it seems rather strange?

cheers,
Derick

I looked at the manual and mime_content_type() is deprecated and tells
me to use the Fileinfo PECL extension. From which I am led back to the
parent section, which is for the built-in Fileinfo extension. Looks like
the manual is out-of-date.

Anyhow, looks like finfo_file() works as we'd want, though I feel uneasy
about guessing filetypes this way. Perhaps we should have several
explicitly specified ones (.txt as text/plain, .html as text/html,
etc.), and guess the rest? Especially for ones which it would not
correctly guess.

Thanks.

Hi!
It looks strange that we have to hardcode so many mimetypes in the code,
and doesn't sound a scalable solution. Can't we make it use data from
fileinfo or some other customizeable table so we don't have to keep all
MIME types hardcoded in the code? Maybe some ability to use Apache's
mime.types file?

It isn't scalable, but users can always use a router script to add
additional types so there isn't a real world problem in missing
uncommon extensions.

My idea was to add common extensions to the existing look-up list. A
quick and straight-forward solution to making the CLI web-server
handle the 80-20 rule.

If someone (ajf?) wants to work on a more comprehensive solution
instead, I have no objection.

Chris

Chris,

What is wrong with a more common magic file which fileinfo utilizes? I
understand the concept of adding common extensions but only as a fallback
to distro behavior.

Regards,

Mike

There's nothing wrong that I know of. If you have time to implement it,
go ahead.

Chris

hi,

On Sat, Nov 23, 2013 at 5:39 AM, Christopher Jones
wrote:
There is nothing wrong but it may not as easy as it looks.

This file must be available when fiinfo is not enabled (build time) or
loaded. fileinfo ma be shared too (as far as I remember almost all
distros provide it optionally and shared). That's something to keep in
mind while implementing a patch.

Cheers,