FAQ

On Fri, 18 Mar 2011, Ondřej Surý wrote:
On Thu, Feb 10, 2011 at 13:37, Ondřej Surý wrote:
On Thu, Feb 10, 2011, Derick wrote:

I know it doesn't; I was asking for making it detectable. Perhaps
instead of LFS, you could use DEBIAN as "ZEND_BUILD_EXTRA"
instead then? Or perhaps include flags with that, that show all the
different Debian flags/options/or perhaps a debian specific version nr
as well; such as DEBIAN1, DEBIAN2 etc...
Seems reasonable to me, but I am not sure if we don't break other
stuff by introducing this. But right now it's a right time to do it,
since the new development cycle has just started.
I have tested your patch, but since this changes the ability to load
existing modules, there's a need to plan a transition and coordinate
it with the release team. It would probably also be good thing to
coordinate this either with other major distributions (so the LFS flag
is same everywhere) or move this logic directly to PHP upstream.
Yes, that makes sense.
What do you (and other pkg-php maintainers) think? My guess would be
that best solution would be to move this to upstream, so it's
consistent even for local custom builds with _FILE_OFFSET_BITS == 64.
I think this makes sense to me. Adding LFS to out ZEND_BUILDIN_EXTRA
stuff alongside with the ZTS and DEBUG flags makes a lot of sense.
I am cc-ing php internals here. As a reference, this is the issue:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=612743

regards,
Derick

--
http://derickrethans.nl | http://xdebug.org
Like Xdebug? Consider a donation: http://xdebug.org/donate.php
twitter: @derickr and @xdebug

Search Discussions

  • Ferenc Kovacs at Jul 28, 2012 at 8:02 pm

    On Fri, Mar 18, 2011 at 5:08 PM, Derick Rethans wrote:
    On Fri, 18 Mar 2011, Ondřej Surý wrote:
    On Thu, Feb 10, 2011 at 13:37, Ondřej Surý wrote:
    On Thu, Feb 10, 2011, Derick wrote:

    I know it doesn't; I was asking for making it detectable. Perhaps
    instead of LFS, you could use DEBIAN as "ZEND_BUILD_EXTRA"
    instead then? Or perhaps include flags with that, that show all the
    different Debian flags/options/or perhaps a debian specific version nr
    as well; such as DEBIAN1, DEBIAN2 etc...
    Seems reasonable to me, but I am not sure if we don't break other
    stuff by introducing this. But right now it's a right time to do it,
    since the new development cycle has just started.
    I have tested your patch, but since this changes the ability to load
    existing modules, there's a need to plan a transition and coordinate
    it with the release team. It would probably also be good thing to
    coordinate this either with other major distributions (so the LFS flag
    is same everywhere) or move this logic directly to PHP upstream.
    Yes, that makes sense.
    What do you (and other pkg-php maintainers) think? My guess would be
    that best solution would be to move this to upstream, so it's
    consistent even for local custom builds with _FILE_OFFSET_BITS == 64.
    I think this makes sense to me. Adding LFS to out ZEND_BUILDIN_EXTRA
    stuff alongside with the ZTS and DEBUG flags makes a lot of sense.
    I am cc-ing php internals here. As a reference, this is the issue:
    http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=612743

    regards,
    Derick

    --
    http://derickrethans.nl | http://xdebug.org
    Like Xdebug? Consider a donation: http://xdebug.org/donate.php
    twitter: @derickr and @xdebug

    --
    PHP Internals - PHP Runtime Development Mailing List
    To unsubscribe, visit: http://www.php.net/unsub.php
    is this still something that we want to pursue?

    --
    Ferenc Kovács
    @Tyr43l - http://tyrael.hu
  • Derick Rethans at Aug 6, 2012 at 10:43 am

    On Sat, 28 Jul 2012, Ferenc Kovacs wrote:
    On Fri, Mar 18, 2011 at 5:08 PM, Derick Rethans wrote:
    On Fri, 18 Mar 2011, Ondřej Surý wrote:
    On Thu, Feb 10, 2011 at 13:37, Ondřej Surý wrote:
    On Thu, Feb 10, 2011, Derick wrote:

    I know it doesn't; I was asking for making it detectable. Perhaps
    instead of LFS, you could use DEBIAN as "ZEND_BUILD_EXTRA"
    instead then? Or perhaps include flags with that, that show all the
    different Debian flags/options/or perhaps a debian specific version nr
    as well; such as DEBIAN1, DEBIAN2 etc...
    Seems reasonable to me, but I am not sure if we don't break other
    stuff by introducing this. But right now it's a right time to do it,
    since the new development cycle has just started.
    I have tested your patch, but since this changes the ability to load
    existing modules, there's a need to plan a transition and coordinate
    it with the release team. It would probably also be good thing to
    coordinate this either with other major distributions (so the LFS flag
    is same everywhere) or move this logic directly to PHP upstream.
    Yes, that makes sense.
    What do you (and other pkg-php maintainers) think? My guess would be
    that best solution would be to move this to upstream, so it's
    consistent even for local custom builds with _FILE_OFFSET_BITS == 64.
    I think this makes sense to me. Adding LFS to out ZEND_BUILDIN_EXTRA
    stuff alongside with the ZTS and DEBUG flags makes a lot of sense.
    I am cc-ing php internals here. As a reference, this is the issue:
    http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=612743
    is this still something that we want to pursue?
    Yes I think so!

    cheers,
    Derick

    --
    http://derickrethans.nl | http://xdebug.org
    Like Xdebug? Consider a donation: http://xdebug.org/donate.php
    twitter: @derickr and @xdebug

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupphp-internals @
categoriesphp
postedMar 18, '11 at 4:08p
activeAug 6, '12 at 10:43a
posts3
users3
websitephp.net

People

Translate

site design / logo © 2022 Grokbase