FAQ
Hello Frank,

can you please sync HEAD which seems completely outdated beside that it
has const designatures which are somehow missing in 5.3. Anyway, this
commit makes ming at least compile with the latest available version
0.4rc1. Eitherway, if 0.4 is not coming out during alpha1 and no support
for 0.3 is available I fear we have to move ming to PECL.

marcus

Sunday, July 27, 2008, 11:32:48 PM, you wrote:
helly Sun Jul 27 21:32:48 2008 UTC
Modified files: (Branch: PHP_5_3)
/php-src/ext/ming config.m4 ming.c
Log:
- Allow building with ming-0.4rc1 (the latest available ming)
# Necessary to get gcov.php.net working again


http://cvs.php.net/viewvc.cgi/php-src/ext/ming/config.m4?r1=1.22.2.6.2.4&r2=1.22.2.6.2.4.2.1&diff_format=u
Index: php-src/ext/ming/config.m4
diff -u php-src/ext/ming/config.m4:1.22.2.6.2.4
php-src/ext/ming/config.m4:1.22.2.6.2.4.2.1
--- php-src/ext/ming/config.m4:1.22.2.6.2.4 Tue Mar 6 10:13:40 2007
+++ php-src/ext/ming/config.m4 Sun Jul 27 21:32:48 2008
@@ -1,5 +1,5 @@
dnl
-dnl $Id: config.m4,v 1.22.2.6.2.4 2007/03/06 10:13:40 tony2001 Exp $
+dnl $Id: config.m4,v 1.22.2.6.2.4.2.1 2008/07/27 21:32:48 helly Exp $
dnl

PHP_ARG_WITH(ming, for MING support,
@@ -40,9 +40,12 @@
PHP_ADD_INCLUDE($MING_INC_DIR)
PHP_ADD_LIBRARY_WITH_PATH(ming, $MING_DIR/$PHP_LIBDIR, MING_SHARED_LIBADD)

- PHP_CHECK_LIBRARY(ming, SWFPrebuiltClip, [
AC_DEFINE(HAVE_SWFPREBUILTCLIP, 1, [ ]) ], [], [])
- PHP_CHECK_LIBRARY(ming, SWFMovie_namedAnchor, [
AC_DEFINE(HAVE_SWFMOVIE_NAMEDANCHOR, 1, [ ]) ], [], [])
- PHP_CHECK_LIBRARY(ming, Ming_setSWFCompression, [
AC_DEFINE(HAVE_MING_SETSWFCOMPRESSION, 1, [ ]) ], [], [])
+ PHP_CHECK_LIBRARY(ming, SWFPrebuiltClip, [
AC_DEFINE(HAVE_SWFPREBUILTCLIP, 1, [ ]) ], [], [])
+ PHP_CHECK_LIBRARY(ming, SWFMovie_namedAnchor, [
AC_DEFINE(HAVE_SWFMOVIE_NAMEDANCHOR, 1, [ ]) ], [], [])
+ PHP_CHECK_LIBRARY(ming, Ming_setSWFCompression, [
AC_DEFINE(HAVE_MING_SETSWFCOMPRESSION, 1, [ ]) ], [], [])
+ PHP_CHECK_LIBRARY(ming, SWFVideoStream_seek, [
AC_DEFINE(HAVE_SWFVIDEOSTREAM_SEEK, 1, [ ]) ], [], [])
+ PHP_CHECK_LIBRARY(ming, SWFVideoStream_setFrameMode, [
AC_DEFINE(HAVE_SWFVIDEOSTREAM_SETFRAMEMODE, 1, [ ]) ], [], [])
+ PHP_CHECK_LIBRARY(ming, SWFVideoStream_nextFrame, [
AC_DEFINE(HAVE_SWFVIDEOSTREAM_NEXTFRAME, 1, [ ]) ], [], [])

old_CPPFLAGS=$CPPFLAGS
CPPFLAGS=-I$MING_INC_DIR
http://cvs.php.net/viewvc.cgi/php-src/ext/ming/ming.c?r1=1.79.2.4.2.8.2.8&r2=1.79.2.4.2.8.2.9&diff_format=u
Index: php-src/ext/ming/ming.c
diff -u php-src/ext/ming/ming.c:1.79.2.4.2.8.2.8
php-src/ext/ming/ming.c:1.79.2.4.2.8.2.9
--- php-src/ext/ming/ming.c:1.79.2.4.2.8.2.8 Thu Jul 24 18:39:41 2008
+++ php-src/ext/ming/ming.c Sun Jul 27 21:32:48 2008
@@ -19,7 +19,7 @@
+----------------------------------------------------------------------+
*/

-/* $Id: ming.c,v 1.79.2.4.2.8.2.8 2008/07/24 18:39:41 fmk Exp $ */
+/* $Id: ming.c,v 1.79.2.4.2.8.2.9 2008/07/27 21:32:48 helly Exp $ */

#ifdef HAVE_CONFIG_H
#include "config.h"
@@ -3521,6 +3521,7 @@
}
/* }}} */

+#if HAVE_SWFVIDEOSTREAM_NEXTFRAME
/* {{{ proto swfvideostream::nextFrame */
PHP_METHOD(swfvideostream, nextFrame)
{
@@ -3531,7 +3532,9 @@
RETURN_LONG(SWFVideoStream_nextFrame(getVideoStream(getThis() TSRMLS_CC)));
}
/* }}} */
-
+#endif
+
+#if HAVE_SWFVIDEOSTREAM_SETFRAMEMODE
/* {{{ proto swfvideostream::setFrameMode */
PHP_METHOD(swfvideostream, setFrameMode)
{
@@ -3547,7 +3550,9 @@
RETURN_LONG(SWFVideoStream_setFrameMode(stream, mode));
}
/* }}} */
+#endif

+#if HAVE_SWFVIDEOSTREAM_SEEK
/* {{{ proto swfvideostream::seek(frame, whence) */
PHP_METHOD(swfvideostream, seek)
{
@@ -3563,16 +3568,22 @@
RETURN_LONG(SWFVideoStream_seek(stream, frame, whence));
}
/* }}} */
-
-
+#endif
+
static zend_function_entry swfvideostream_functions[] = {
PHP_ME(swfvideostream, __construct, NULL, 0)
PHP_ME(swfvideostream, setdimension, NULL, 0)
PHP_ME(swfvideostream, getnumframes, NULL, 0)
PHP_ME(swfvideostream, hasaudio, NULL, 0)
+#if HAVE_SWFVIDEOSTREAM_SETFRAMEMODE
PHP_ME(swfvideostream, setFrameMode, NULL, 0)
+#endif
+#if HAVE_SWFVIDEOSTREAM_NEXTFRAME
PHP_ME(swfvideostream, nextFrame, NULL, 0)
+#endif
+#if HAVE_SWFVIDEOSTREAM_SEEK
PHP_ME(swfvideostream, seek, NULL, 0)
+#endif
{ NULL, NULL, NULL }
};
Best regards,
Marcus

Search Discussions

  • Antony Dovgal at Jul 28, 2008 at 10:08 am

    On 28.07.2008 02:18, Marcus Boerger wrote:
    Hello Frank,

    can you please sync HEAD which seems completely outdated beside that it
    has const designatures which are somehow missing in 5.3. Anyway, this
    commit makes ming at least compile with the latest available version
    0.4rc1. Eitherway, if 0.4 is not coming out during alpha1 and no support
    for 0.3 is available I fear we have to move ming to PECL.
    Agree, the extension is quite rarely used and it makes sense to move it to PECL.

    --
    Wbr,
    Antony Dovgal
  • Pierre Joye at Jul 28, 2008 at 10:55 am
    hi!
    On Mon, Jul 28, 2008 at 12:08 PM, Antony Dovgal wrote:
    On 28.07.2008 02:18, Marcus Boerger wrote:

    Hello Frank,

    can you please sync HEAD which seems completely outdated beside that it
    has const designatures which are somehow missing in 5.3. Anyway, this
    commit makes ming at least compile with the latest available version
    0.4rc1. Eitherway, if 0.4 is not coming out during alpha1 and no support
    for 0.3 is available I fear we have to move ming to PECL.
    Agree, the extension is quite rarely used and it makes sense to move it to
    PECL.
    I asked that already a while back and we disagreed as it works well.
    Frank's plan is to first add 0.4 support and then allows to build
    against 0.3 (before 5.3RC or alpha2). Ming 0.4 is about to be released
    (if you follow ming development list).


    Cheers,
  • Antony Dovgal at Jul 28, 2008 at 12:27 pm

    On 28.07.2008 14:55, Pierre Joye wrote:
    0.4rc1. Eitherway, if 0.4 is not coming out during alpha1 and no support
    for 0.3 is available I fear we have to move ming to PECL.
    Agree, the extension is quite rarely used and it makes sense to move it to
    PECL.
    I asked that already a while back and we disagreed as it works well.
    It's not about its quality or status (or did you mean that all PECL extensions don't work well?).
    This extension is rarely used and its release cycle depends on libming releases,
    which makes me think that moving it to PECL isn't that bad idea.
    Frank's plan is to first add 0.4 support and then allows to build
    against 0.3 (before 5.3RC or alpha2). Ming 0.4 is about to be released
    (if you follow ming development list).
    --
    Wbr,
    Antony Dovgal
  • Pierre Joye at Jul 28, 2008 at 12:31 pm
    hi,
    On Mon, Jul 28, 2008 at 2:26 PM, Antony Dovgal wrote:
    On 28.07.2008 14:55, Pierre Joye wrote:

    0.4rc1. Eitherway, if 0.4 is not coming out during alpha1 and no support
    for 0.3 is available I fear we have to move ming to PECL.
    Agree, the extension is quite rarely used and it makes sense to move it
    to
    PECL.
    I asked that already a while back and we disagreed as it works well.
    It's not about its quality or status (or did you mean that all PECL
    extensions don't work well?).
    This extension is rarely used and its release cycle depends on libming
    releases, which makes me think that moving it to PECL isn't that bad idea.
    Frank's plan is to first add 0.4 support and then allows to build
    against 0.3 (before 5.3RC or alpha2). Ming 0.4 is about to be released
    (if you follow ming development list).
    It happens once for 5.3, which is important enough to get major new features.

    I don't care if we move it or not, but as we agreed to do not move it
    out a couple of weeks ago, it would be bad to do it now that the
    changes are getting done.

    Cheers,
  • Hannes Magnusson at Jul 28, 2008 at 1:09 pm

    On Mon, Jul 28, 2008 at 14:31, Pierre Joye wrote:
    hi,
    On Mon, Jul 28, 2008 at 2:26 PM, Antony Dovgal wrote:
    On 28.07.2008 14:55, Pierre Joye wrote:

    0.4rc1. Eitherway, if 0.4 is not coming out during alpha1 and no support
    for 0.3 is available I fear we have to move ming to PECL.
    Agree, the extension is quite rarely used and it makes sense to move it
    to
    PECL.
    I asked that already a while back and we disagreed as it works well.
    It's not about its quality or status (or did you mean that all PECL
    extensions don't work well?).
    This extension is rarely used and its release cycle depends on libming
    releases, which makes me think that moving it to PECL isn't that bad idea.
    Frank's plan is to first add 0.4 support and then allows to build
    against 0.3 (before 5.3RC or alpha2). Ming 0.4 is about to be released
    (if you follow ming development list).
    It happens once for 5.3, which is important enough to get major new features.

    I don't care if we move it or not, but as we agreed to do not move it
    out a couple of weeks ago, it would be bad to do it now that the
    changes are getting done.
    As I recall the discussion then lot of people wanted it removed, but
    few did not.
    Those few however where enough to keep it core because "it works
    fine", but there was no *agreement*.

    -Hannes
  • Lukas Kahwe Smith at Jul 30, 2008 at 3:38 pm

    On 28.07.2008, at 14:31, Pierre Joye wrote:

    hi,
    On Mon, Jul 28, 2008 at 2:26 PM, Antony Dovgal wrote:
    On 28.07.2008 14:55, Pierre Joye wrote:

    0.4rc1. Eitherway, if 0.4 is not coming out during alpha1 and no
    support
    for 0.3 is available I fear we have to move ming to PECL.
    Agree, the extension is quite rarely used and it makes sense to
    move it
    to
    PECL.
    I asked that already a while back and we disagreed as it works well.
    It's not about its quality or status (or did you mean that all PECL
    extensions don't work well?).
    This extension is rarely used and its release cycle depends on
    libming
    releases, which makes me think that moving it to PECL isn't that
    bad idea.
    Frank's plan is to first add 0.4 support and then allows to build
    against 0.3 (before 5.3RC or alpha2). Ming 0.4 is about to be
    released
    (if you follow ming development list).
    It happens once for 5.3, which is important enough to get major new
    features.

    I don't care if we move it or not, but as we agreed to do not move it
    out a couple of weeks ago, it would be bad to do it now that the
    changes are getting done.

    So unless ming is fixed up today, I guess we have no other choice but
    to disable it for alpha1. This leaves alpha2 as the last chance to get
    ming fixed and reenabled. Otherwise I guess ming just has to go to
    PECL. Many people seem to already be in favor of moving ming to PECL
    and if we have maintenance issues, it would put the final nail in the
    "coffin".

    regards,
    Lukas Kahwe Smith
    mls@pooteeweet.org
  • Jani Taskinen at Jul 30, 2008 at 5:33 pm

    Lukas Kahwe Smith wrote:
    On 28.07.2008, at 14:31, Pierre Joye wrote:

    hi,

    On Mon, Jul 28, 2008 at 2:26 PM, Antony Dovgal <tony@daylessday.org>
    wrote:
    On 28.07.2008 14:55, Pierre Joye wrote:

    0.4rc1. Eitherway, if 0.4 is not coming out during alpha1 and no
    support
    for 0.3 is available I fear we have to move ming to PECL.
    Agree, the extension is quite rarely used and it makes sense to
    move it
    to
    PECL.
    I asked that already a while back and we disagreed as it works well.
    It's not about its quality or status (or did you mean that all PECL
    extensions don't work well?).
    This extension is rarely used and its release cycle depends on libming
    releases, which makes me think that moving it to PECL isn't that bad
    idea.
    Frank's plan is to first add 0.4 support and then allows to build
    against 0.3 (before 5.3RC or alpha2). Ming 0.4 is about to be released
    (if you follow ming development list).
    It happens once for 5.3, which is important enough to get major new
    features.

    I don't care if we move it or not, but as we agreed to do not move it
    out a couple of weeks ago, it would be bad to do it now that the
    changes are getting done.

    So unless ming is fixed up today, I guess we have no other choice but to
    disable it for alpha1. This leaves alpha2 as the last chance to get ming
    fixed and reenabled. Otherwise I guess ming just has to go to PECL. Many
    people seem to already be in favor of moving ming to PECL and if we have
    maintenance issues, it would put the final nail in the "coffin".
    To PECL men! I rather have this kind of extensions (rarely used, etc.)
    in PECL _until_ they prove a) being widely used b) stable c) heavy
    development has ceased.

    C) is about being able to update extension _quickly_ without having to
    wait for new PHP release / build whole thing all the time..

    --Jani

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupphp-internals @
categoriesphp
postedJul 28, '08 at 3:22a
activeJul 30, '08 at 5:33p
posts8
users6
websitephp.net

People

Translate

site design / logo © 2022 Grokbase