FAQ
9pm last night!!

-Andrei
On Aug 11, 2005, at 2:32 PM, Antony Dovgal wrote:

tony2001 Thu Aug 11 17:32:58 2005 EDT

Modified files:
/php-src NEWS
/ZendEngine2 zend_reflection_api.c
Log:
MF5.1: fix #34078 (Reflection API problems in methods with boolean
or null default values)

(andrei said to sara a few hours ago you may commit whatever you
want until 9pm) (c) helly
if there are any problems with this patch - please tell me, I'll
revert it immediately


http://cvs.php.net/diff.php/php-src/NEWS?r1=1.2037&r2=1.2038&ty=u
Index: php-src/NEWS
diff -u php-src/NEWS:1.2037 php-src/NEWS:1.2038
--- php-src/NEWS:1.2037 Wed Aug 10 09:11:52 2005
+++ php-src/NEWS Thu Aug 11 17:32:56 2005
@@ -20,6 +20,8 @@
- Fixed "make test" to work for phpized extensions. (Hartmut, Jani)
- Fixed failing queries (FALSE returned) with mysqli_query() on 64
bit systems.
(Andrey)
+- Fixed bug #34078 (Reflection API problems in methods with boolean
or null
+ default values). (Tony)
- Fixed bug #34064 (arr[] as param to function in class gives invalid
opcode).
(Dmitry)
- Fixed bug #34062 (Crash in catch block when many arguments are
used).
http://cvs.php.net/diff.php/ZendEngine2/zend_reflection_api.c?
r1=1.164&r2=1.165&ty=u
Index: ZendEngine2/zend_reflection_api.c
diff -u ZendEngine2/zend_reflection_api.c:1.164
ZendEngine2/zend_reflection_api.c:1.165
--- ZendEngine2/zend_reflection_api.c:1.164 Wed Aug 3 09:30:56 2005
+++ ZendEngine2/zend_reflection_api.c Thu Aug 11 17:32:57 2005
@@ -19,7 +19,7 @@

+----------------------------------------------------------------------
+
*/

-/* $Id: zend_reflection_api.c,v 1.164 2005/08/03 13:30:56 sniper Exp
$ */
+/* $Id: zend_reflection_api.c,v 1.165 2005/08/11 21:32:57 tony2001
Exp $ */
#include "zend.h"
#include "zend_API.h"
#include "zend_exceptions.h"
@@ -1864,7 +1864,7 @@

zv_copy = precv->op2.u.constant;
zv = &zv_copy;
- zval_update_constant(&zv, (void*)1 TSRMLS_CC);
+ zval_update_constant(&zv, (void*)0 TSRMLS_CC);
RETURN_ZVAL(zv, 1, 1);
}
/* }}} */

--
Zend Engine CVS Mailing List (http://cvs.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Search Discussions

  • Antony Dovgal at Aug 11, 2005 at 10:00 pm

    On Thu, 11 Aug 2005 14:51:58 -0700 Andrei Zmievski wrote:

    9pm last night!!
    So, you didn't say - should I revert it or it's ok.
    I don't want to memorize the entire contents of Unicode Character Set =)

    --
    Wbr,
    Antony Dovgal

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupphp-internals @
categoriesphp
postedAug 11, '05 at 9:54p
activeAug 11, '05 at 10:00p
posts2
users2
websitephp.net

2 users in discussion

Antony Dovgal: 1 post Andrei Zmievski: 1 post

People

Translate

site design / logo © 2022 Grokbase