FAQ
Hi all!

Any volunteers to review & commit patch for #29210 ?

Fresh diff against latest HEAD:
http://tony2001.phpclub.net/dev/tmp/is_callable_HEAD.diff

The patch adds support of protected/private methods to is_callable(),
taking care of the context.

test file:
http://tony2001.phpclub.net/dev/tmp/is_callable.phpt

x-posted to #php.bugs =)

--
Wbr,
Antony Dovgal aka tony2001
antony@zend.com

Search Discussions

  • Marcus Boerger at Feb 18, 2005 at 6:14 pm
    Hello Antony,

    there is no need to fetch the instance (or create a temporairy one) since
    the function table is bound to the class rather then the instance. This is
    the major difference between real object oriented (sometimes referred to as
    prototype based like java script for instance) and class based.

    regards
    marcus

    Friday, February 18, 2005, 3:05:35 PM, you wrote:
    Hi all!
    Any volunteers to review & commit patch for #29210 ?
    Fresh diff against latest HEAD:
    http://tony2001.phpclub.net/dev/tmp/is_callable_HEAD.diff
    The patch adds support of protected/private methods to is_callable(),
    taking care of the context.
    test file:
    http://tony2001.phpclub.net/dev/tmp/is_callable.phpt
    x-posted to #php.bugs =)
    --
    Wbr,
    Antony Dovgal aka tony2001
    antony@zend.com



    --
    Best regards,
    Marcus mailto:helly@php.net
  • Antony Dovgal at Feb 20, 2005 at 4:41 pm

    On Fri, 18 Feb 2005 19:14:27 +0100 Marcus Boerger wrote:

    Hello Antony,

    there is no need to fetch the instance (or create a temporairy one)
    since
    the function table is bound to the class rather then the instance.
    This is the major difference between real object oriented (sometimes
    referred to as prototype based like java script for instance) and
    class based.
    Yeah, thanks for the hint, Marcus.
    Here is new version of the patch:

    http://tony2001.phpclub.net/dev/tmp/is_callable_new.diff

    --
    Wbr,
    Antony Dovgal aka tony2001
    antony@zend.com
  • Andi Gutmans at Feb 18, 2005 at 6:15 pm
    Hi Antony,

    We have too many places that manually check access restrictions at this point.
    I would like to generalize it and use that in all places, and make it
    easier to fix problems like your patch does. Haven't had the time yet to
    dive deeply into it and see what the right way would be.
    For example, we have similar code in zend_std_get_method().

    If you have any good ideas of how we can generalize it email me.

    Thanks,
    Andi
    At 05:05 PM 2/18/2005 +0300, Antony Dovgal wrote:
    Hi all!

    Any volunteers to review & commit patch for #29210 ?

    Fresh diff against latest HEAD:
    http://tony2001.phpclub.net/dev/tmp/is_callable_HEAD.diff

    The patch adds support of protected/private methods to is_callable(),
    taking care of the context.

    test file:
    http://tony2001.phpclub.net/dev/tmp/is_callable.phpt

    x-posted to #php.bugs =)

    --
    Wbr,
    Antony Dovgal aka tony2001
    antony@zend.com

    --
    PHP Internals - PHP Runtime Development Mailing List
    To unsubscribe, visit: http://www.php.net/unsub.php
  • Antony Dovgal at Feb 18, 2005 at 6:27 pm

    On Thu, 17 Feb 2005 10:15:10 -0800 Andi Gutmans wrote:

    Hi Antony,

    We have too many places that manually check access restrictions at
    this point. I would like to generalize it and use that in all places,
    and make it easier to fix problems like your patch does. Haven't had
    the time yet to dive deeply into it and see what the right way would
    be. For example, we have similar code in zend_std_get_method().

    If you have any good ideas of how we can generalize it email me.
    Ok, I'll try to look into this on the weekend.

    --
    Wbr,
    Antony Dovgal aka tony2001
    antony@zend.com
  • Antony Dovgal at Feb 20, 2005 at 4:45 pm

    On Thu, 17 Feb 2005 10:15:10 -0800 Andi Gutmans wrote:

    Hi Antony,

    We have too many places that manually check access restrictions at
    this point. I would like to generalize it and use that in all places,
    and make it easier to fix problems like your patch does. Haven't had
    the time yet to dive deeply into it and see what the right way would
    be. For example, we have similar code in zend_std_get_method().

    If you have any good ideas of how we can generalize it email me.
    As far as I can see zend_std_get_method() uses different semantics and
    zend_is_callable() is used for more general kind of checks.

    We can of course divide zend_is_callable() into several functions, but
    it would just add more mess IMO.

    --
    Wbr,
    Antony Dovgal aka tony2001
    antony@zend.com
  • Antony Dovgal at Mar 29, 2005 at 4:49 pm

    On Tue, 22 Feb 2005 17:38:26 -0800 Andi Gutmans wrote:

    Marcus, Zeev,

    Is there a way to generalize the access restrictions on methods and use
    that general function everywhere? I realize the code is a bit different in
    all places but it might be possible.

    Asking you guys as the people who messed around most with the PPP stuff.
    Andi
    No progress here? =(

    Maybe it'd better to apply the patch and do all the optimizations later?

    --
    Wbr,
    Antony Dovgal aka tony2001
    antony@zend.com

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupphp-internals @
categoriesphp
postedFeb 18, '05 at 2:06p
activeMar 29, '05 at 4:49p
posts7
users3
websitephp.net

People

Translate

site design / logo © 2022 Grokbase