[PHP-INTERNALS] Variable fetch optimization

At 09:31 AM 10/1/2004 -0700, Andi Gutmans wrote:
Hi,

Attached is a patch to optimize variable fetches (basically it caches the
fetches so that variables aren't re-fetched every time, most noticeable in
loops with the loop control counter but also it's a general improvement).
It's similar to the patch Sterling and Thies did a year ago in their
optimization patch.
As compiling the zend_execute.c file is starting to take a long time
(minutes) due to inlining with the goto VM architecture, I suggest to
apply Zend.m4 to make the default the function handler paradigm. The
performance difference is not big and it'll make it easier to work on PHP.
For production environments one can use a configure switch to turn this on.
I'd be happy to hear of benchmarks.

In general, there might be problems with extensions which access the
active symbol table directly. It's something I still need to look into so
please report any problems.

Please try and take some time to test it.

Andi


--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Hi,

Attached is a patch to optimize variable fetches (basically it caches
the fetches so that variables aren't re-fetched every time, most
noticeable in loops with the loop control counter but also it's a
general improvement).
It's similar to the patch Sterling and Thies did a year ago in their
optimization patch.
As compiling the zend_execute.c file is starting to take a long time
(minutes) due to inlining with the goto VM architecture, I suggest to
apply Zend.m4 to make the default the function handler paradigm. The
performance difference is not big and it'll make it easier to work on
PHP. For production environments one can use a configure switch to turn
this on.
I'd be happy to hear of benchmarks.

In general, there might be problems with extensions which access the
active symbol table directly. It's something I still need to look into
so please report any problems.

Please try and take some time to test it.

Andi

At 12:44 PM 10/2/2004 +0200, Thies C. Arntzen wrote:
before: 34.430
after: 20.126

do i need to say more?

(if it really works, which i haven't tested yet)

On Sat, 02 Oct 2004, Thies C. Arntzen wrote:
PS: i really think that the vm should be generated by a script! looking
at what makes most of the patch i really think that we're making
hacking the engine more complex than needed.

I agree..

- Andrei

Wez Furlong wrote:
I'm a big fan of making the computer do the work on our behalf (that's
what it's there for, right?).

It shouldn't be a huge problem to write a php script to generate the
different executors from a source file. If you're worried about
bootstrapping, we can keep the generated files in CVS and/or bundle
them pre-generated in the distro.

At 03:15 PM 10/6/2004 -0700, Sterling Hughes wrote:
Yeah, actually Dmitry wrote a script that converted the old executor into
the new executor, so the script was already there. I think its that Andi
doesn't like the concept (I do like the concept btw), not the work
involved. Personally, I'd prefer to see the executor generated, so long
as the source format is well thought-out. Cause it will allow us to do
things like, for example, generating an x86 JIT.