FAQ
Commit: a9ba407ce16809a2a70724bcd481b64ba8bd550b
Author: Rasmus Lerdorf <rasmus@lerdorf.com> Sun, 22 Feb 2015 08:14:41 -0800
Parents: 8f6a013c972c40e923b2519226521144b347cce0
Branches: PHP-5.5

Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=a9ba407ce16809a2a70724bcd481b64ba8bd550b

Log:
Fix bug #68166
We can't always efree here
php_escape_html_entities can return an interned_empty_string

Bugs:
https://bugs.php.net/68166

Changed paths:
   M main/main.c


Diff:
diff --git a/main/main.c b/main/main.c
index 5e56400..733786e 100644
--- a/main/main.c
+++ b/main/main.c
@@ -1087,7 +1087,7 @@ static void php_error_cb(int type, const char *error_filename, const uint error_
        size_t len;
        char *buf = php_escape_html_entities(buffer, buffer_len, &len, 0, ENT_COMPAT, NULL TSRMLS_CC);
        php_printf("%s<br />\n<b>%s</b>: %s in <b>%s</b> on line <b>%d</b><br />\n%s", STR_PRINT(prepend_string), error_type_str, buf, error_filename, error_lineno, STR_PRINT(append_string));
- efree(buf);
+ str_efree(buf);
       } else {
        php_printf("%s<br />\n<b>%s</b>: %s in <b>%s</b> on line <b>%d</b><br />\n%s", STR_PRINT(prepend_string), error_type_str, buffer, error_filename, error_lineno, STR_PRINT(append_string));
       }

Search Discussions

  • Rasmus Lerdorf at Feb 22, 2015 at 4:27 pm
    Commit: e12b72d3f78cc49d33bcf73ad2d4fa09b6aeff84
    Author: Rasmus Lerdorf <rasmus@lerdorf.com> Sun, 22 Feb 2015 08:14:41 -0800
    Parents: 98959f62200f558e0cbd902265b4bae8b09aa30f
    Branches: PHP-5.6

    Link: http://git.php.net/?p=php-src.git;a=commitdiff;h=e12b72d3f78cc49d33bcf73ad2d4fa09b6aeff84

    Log:
    Fix bug #68166
    We can't always efree here
    php_escape_html_entities can return an interned_empty_string

    Bugs:
    https://bugs.php.net/68166

    Changed paths:
       M main/main.c


    Diff:
    diff --git a/main/main.c b/main/main.c
    index a98aff0..7787ac6 100644
    --- a/main/main.c
    +++ b/main/main.c
    @@ -1157,7 +1157,7 @@ static void php_error_cb(int type, const char *error_filename, const uint error_
            size_t len;
            char *buf = php_escape_html_entities(buffer, buffer_len, &len, 0, ENT_COMPAT, NULL TSRMLS_CC);
            php_printf("%s<br />\n<b>%s</b>: %s in <b>%s</b> on line <b>%d</b><br />\n%s", STR_PRINT(prepend_string), error_type_str, buf, error_filename, error_lineno, STR_PRINT(append_string));
    - efree(buf);
    + str_efree(buf);
           } else {
            php_printf("%s<br />\n<b>%s</b>: %s in <b>%s</b> on line <b>%d</b><br />\n%s", STR_PRINT(prepend_string), error_type_str, buffer, error_filename, error_lineno, STR_PRINT(append_string));
           }

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupphp-cvs @
categoriesphp
postedFeb 22, '15 at 4:27p
activeFeb 22, '15 at 4:27p
posts2
users1
websitephp.net

1 user in discussion

Rasmus Lerdorf: 2 posts

People

Translate

site design / logo © 2018 Grokbase