I appreciate your continious effort about QC process.
GPC bug in rfc1867.c is not critical one, and I agree with you
it is not preferable in the final RC process.
I will revert my GPC related patch in a couple of hours.
But, I shoudn't revert an another license related patch
as shown below because the license compatibility has priority.
+2003-10-25 Rui Hirokawa <firstname.lastname@example.org>
+ * (PHP_4_3)
+ fixed windows build.
+ * (PHP_4_3)
+ mbfilter is replaced with libmbfl to maintain the licence compatibility.
+ mbregex.[ch] is moved to mbregex/ for the same reason.
On Sun, 26 Oct 2003 00:46:29 -0400
Ilia Alshanetsky wrote:
On October 25, 2003 07:14 pm, Rasmus Lerdorf wrote:
Ah, thought it was the other patch. However, I wouldn't call the above a
new feature. That one is a bug fix as it was an oversight to not also
convert form fields in multipart posts.
Well, it is a mix of a feature & a bug fix. The bug if we decide to call it
such is by no means critical and 2 days before the release time is not a time
to make any non critical changes simply because there is no time to test
them. rfc1867.c is very sensitive code which previously had a number of
security faults at least 1 directly caused by mbstring related changes. It is
my opinion such changes have no place this late in the release cycle.
Rui Hirokawa <email@example.com>