FAQ
I have a two bugfixes for packages I have recently used,
so I have had interest in them. Do you (developer) or
anyone in pear-qa have something against committing them.

XML_DTD
http://pear.php.net/bugs/bug.php?id=168

-cut-
diff DTD.php DTD.php.new
194c194
< $children = preg_split('/([^#a-zA-Z0-9.-]+)/', $ch, -1,
PREG_SPLIT_NO_EMPTY);
---
$children = preg_split('/([^#a-zA-Z0-9_.-]+)/', $ch, -1,
PREG_SPLIT_NO_EMPTY);
205c205
< $reg = preg_replace('/([#a-zA-Z0-9.-]+)/', '(,?\\0)',
$reg);
---
$reg = preg_replace('/([#a-zA-Z0-9_.-]+)/', '(,?\\0)',
$reg);
-cut-


XML_Tree
http://pear.php.net/bugs/bug.php?id=89



-cut-
diff Node.php Node.php.new
272,273c272,273
< if (isset($this->attributes[strtolower($name)])) {
< return $this->attributes[strtolower($name)];
---
if (isset($this->attributes[$name])) {
return $this->attributes[$name];
288c288
< $this->attributes[strtolower($name)] = $value;
---
$this->attributes[$name] = $value;
300,301c300,301
< if (isset($this->attributes[strtolower($name)])) {
< unset($this->attributes[strtolower($name)]);
---
if (isset($this->attributes[$name])) {
unset($this->attributes[$name]);
-cut-

Search Discussions

  • Pierre-Alain Joye at Feb 6, 2004 at 10:45 am
    Hello,

    Thanks for the patch. However can you send them as attachment (or
    provide an url) and use diff -up?

    thanks,

    pierre
  • Mika Tuupola at Feb 6, 2004 at 10:49 am

    On Fri, 6 Feb 2004, Mika Tuupola wrote:

    XML_DTD
    http://pear.php.net/bugs/bug.php?id=168
    XML_Tree
    http://pear.php.net/bugs/bug.php?id=89
    And the same as attachments. I have these just waiting
    for commit in my checkout.
  • Lukas Smith at Feb 8, 2004 at 8:46 am

    Mika Tuupola wrote:

    On Fri, 6 Feb 2004, Mika Tuupola wrote:


    And the same as attachments. I have these just waiting
    for commit in my checkout.



    ------------------------------------------------------------------------

    --- Node.php.org 2004-02-06 12:42:38.080016000 +0200
    +++ Node.php 2004-02-06 12:42:44.980045000 +0200
    Hmm this looks like a BC break. However 2.0 seems to be in beta with no
    stable release as of yet. Anyways I am not sure why things where done
    the way they were. But it looks very deliberate. So all in all maybe an
    option would be more appropriate?
    --- DTD.php 2004-02-06 12:14:51.039983000 +0200
    +++ DTD.php.new 2004-02-06 12:14:15.979992000 +0200
    This looks like a fairly safe correction.

    I am not sure about how to go about thing now. Both bugs seem to date
    back to october. I think since both packages are still before their
    first stable release in the relevant major version cycle. So fixing the
    code in CVS seems safe to me. Dunno about firing a release though as I
    dont know how much development aside from that was done since the last
    release.

    regards,
    Lukas Smith
    smith@backendmedia.com
    _______________________________
    BackendMedia
    www.backendmedia.com
    berlin@backendmedia.com

    Linn Zwoch Smith GbR
    Pariser Str. 44
    D-10707 Berlin

    Tel +49 30 83 22 50 00
    Fax +49 30 83 22 50 07
  • Mika Tuupola at Feb 8, 2004 at 4:21 pm

    On Sun, 8 Feb 2004, Lukas Smith wrote:

    Hmm this looks like a BC break. However 2.0 seems to be in beta with no
    stable release as of yet. Anyways I am not sure why things where done
    the way they were. But it looks very deliberate. So all in all maybe an
    option would be more appropriate?
    True. It breaks BC for those scripts which depend on incorrect
    behaviour of handling XML attributes. Then again it doesn't break
    anything on those script who don't.
    --- DTD.php 2004-02-06 12:14:51.039983000 +0200
    +++ DTD.php.new 2004-02-06 12:14:15.979992000 +0200
    I still haven't heard nothing from the developers. But will wait
    for a couple of days more.
  • Lukas Smith at Feb 8, 2004 at 4:28 pm

    Mika Tuupola wrote:

    On Sun, 8 Feb 2004, Lukas Smith wrote:

    Hmm this looks like a BC break. However 2.0 seems to be in beta with no
    stable release as of yet. Anyways I am not sure why things where done
    the way they were. But it looks very deliberate. So all in all maybe an
    option would be more appropriate?

    True. It breaks BC for those scripts which depend on incorrect
    behaviour of handling XML attributes. Then again it doesn't break
    anything on those script who don't.
    the problem is that a few people will get hit that just made a little
    typo in some document.

    so i really suggest you look into making this an optional "feature"

    regards,
    Lukas Smith
    smith@backendmedia.com
    _______________________________
    BackendMedia
    www.backendmedia.com
    berlin@backendmedia.com

    Linn Zwoch Smith GbR
    Pariser Str. 44
    D-10707 Berlin

    Tel +49 30 83 22 50 00
    Fax +49 30 83 22 50 07

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
grouppear-qa @
categoriesphp
postedFeb 6, '04 at 10:40a
activeFeb 8, '04 at 4:28p
posts6
users3
websitepear.php.net

People

Translate

site design / logo © 2022 Grokbase