FAQ
Edit report at https://pear.php.net/bugs/bug.php?id=20451&edit=1

  ID: 20451
  Updated by: sasezaki@gmail.com
  Reported By: sasezaki@gmail.com
-Summary: new holiday 'mountain day'(???) is not covered yet.
+Summary: new holiday 'mountain day' is not covered yet.
  Status: Open
  Type: Bug
  Package: Date_Holidays_Japan
  Package Version: 0.1.2
  PHP Version: Irrelevant
  Roadmap Versions:
  New Comment:

-Summary: new holiday 'mountain day'(???) is not covered yet.
+Summary: new holiday 'mountain day' is not covered yet.



Previous Comments:
------------------------------------------------------------------------

[2014-11-28 12:13:58] sasezaki

Description:
------------
Along with Japanese Holiday enactment at 2014, August 11 should be
judged
as Holiday.

ref. http://en.wikipedia.org/wiki/Mountain_Day
http://www.shugiin.go.jp/internet/itdb_annai.nsf/html/statics/housei/html/h-
shuhou186.html (The House of Representatives of Japan Information)

Test script:
---------------
  $japan = Date_Holidays::factory('Japan');
  var_dump($obj->isHoliday('2016-08-11'));


Expected result:
----------------
bool(true)


Actual result:
--------------
bool(false)

------------------------------------------------------------------------

Search Discussions

  • Sasezaki at Nov 28, 2014 at 11:21 am
    Edit report at https://pear.php.net/bugs/bug.php?id=20451&edit=1

      ID: 20451
      Comment by: sasezaki@gmail.com
      Reported By: sasezaki@gmail.com
      Summary: new holiday 'mountain day' is not covered yet.
      Status: Open
      Type: Bug
      Package: Date_Holidays_Japan
      Package Version: 0.1.2
      PHP Version: Irrelevant
      Roadmap Versions:
      New Comment:

    I made a patch & pull request at github.
    https://github.com/pear/Date_Holidays/pull/5


    Previous Comments:
    ------------------------------------------------------------------------

    [2014-11-28 12:20:24] sasezaki

    -Summary: new holiday 'mountain day'(???) is not covered yet.
    +Summary: new holiday 'mountain day' is not covered yet.


    ------------------------------------------------------------------------

    [2014-11-28 12:13:58] sasezaki

    Description:
    ------------
    Along with Japanese Holiday enactment at 2014, August 11 should be
    judged
    as Holiday.

    ref. http://en.wikipedia.org/wiki/Mountain_Day
    http://www.shugiin.go.jp/internet/itdb_annai.nsf/html/statics/housei/html/h-
    shuhou186.html (The House of Representatives of Japan Information)

    Test script:
    ---------------
      $japan = Date_Holidays::factory('Japan');
      var_dump($obj->isHoliday('2016-08-11'));


    Expected result:
    ----------------
    bool(true)


    Actual result:
    --------------
    bool(false)

    ------------------------------------------------------------------------

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
grouppear-bugs @
categoriesphp
postedNov 28, '14 at 11:15a
activeNov 28, '14 at 11:21a
posts2
users2
websitepear.php.net

2 users in discussion

Sasezaki: 1 post Sasezaki: 1 post

People

Translate

site design / logo © 2022 Grokbase