FAQ
Edit report at https://pear.php.net/bugs/bug.php?id=17036&edit=1

  ID: 17036
  Updated by: tklingenberg@lastflood.net
  Reported By: lukas dot emile@gmail.com
  Summary: Problem with parsed query string
-Status: Closed
+Status: Open
  Type: Bug
  Package: Net_URL2
  Operating System: linux
  Package Version: 0.3.1
  PHP Version: 5.1.3
-Assigned To: till
+Assigned To: tkli
  Roadmap Versions:
  New Comment:

-Status: Closed
+Status: Open
-Assigned To: till
+Assigned To: tkli
This was not fixed that time despite the test result might have made it
look that way.

The problem with the test is, that it is not testing
Net_URL2::getQueryVariables().

The test only tests PHPs built-in function parse_str().

Therefore the Net_URL2Test::testQueryVariables() is bogus.

This has come to my attention while reviewing the regex patterns in
getQueryVariables() recently which made me assume a flaw due to greedy
matching.

Next release 2.0.5 will have this fixed.


Previous Comments:
------------------------------------------------------------------------

[2011-03-14 14:15:56] till

-Status: Feedback
+Status: Closed
This bug has been fixed in SVN.

If this was a documentation problem, the fix will appear on pear.php.net
by the end of next Sunday (CET).

If this was a problem with the pear.php.net website, the change should
be live shortly.

Otherwise, the fix will appear in the package's next release.

Thank you for the report and for helping us make PEAR better.

Epic win!!!11

------------------------------------------------------------------------

[2011-03-14 08:50:34] cweiske

Yes, your patch fixes the problem.

------------------------------------------------------------------------

[2011-03-13 13:39:44] till

I think this might have been fixed by another bugfix I did. Anyway, I
tried to make sense of the example code and
committed a unit test with it. The unit test runs.

http://svn.php.net/viewvc?view=revision&revision=309168

Wouldn't mind if ANYONE could take a look so this is finished and we can
move on a new release.

------------------------------------------------------------------------

[2011-03-13 02:49:36] till

-Status: Open
+Status: Feedback
-Assigned To:
+Assigned To: till
Lukas,

you mind providing some example code which I could wrap into a unit
test?

Till

------------------------------------------------------------------------

[2010-02-08 17:12:40] schmidt

The patch does not respect the various OPTION_xxx options.

------------------------------------------------------------------------

The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
     http://pear.php.net/bugs/bug.php?id=17036

Search Discussions

  • Tklingenberg at Jan 1, 2014 at 10:28 pm
    Edit report at https://pear.php.net/bugs/bug.php?id=17036&edit=1

      ID: 17036
      Updated by: tklingenberg@lastflood.net
      Reported By: lukas dot emile@gmail.com
      Summary: Problem with parsed query string
    -Status: Assigned
    +Status: Closed
      Type: Bug
      Package: Net_URL2
      Operating System: linux
      Package Version: 0.3.1
      PHP Version: 5.1.3
      Assigned To: tkli
      Roadmap Versions:
      New Comment:

    -Status: Assigned
    +Status: Closed
    Thank you for your bug report. This issue has been fixed
    in the latest released version of the package, which you can download at
    http://pear.php.net/get/

    So better late then never :)

    Now fixed in 2.0.5. https://pear.php.net/package/Net_URL2


    Previous Comments:
    ------------------------------------------------------------------------

    [2014-01-01 21:40:44] tkli

    -Status: Closed
    +Status: Open
    -Assigned To: till
    +Assigned To: tkli
    This was not fixed that time despite the test result might have made it
    look that way.

    The problem with the test is, that it is not testing
    Net_URL2::getQueryVariables().

    The test only tests PHPs built-in function parse_str().

    Therefore the Net_URL2Test::testQueryVariables() is bogus.

    This has come to my attention while reviewing the regex patterns in
    getQueryVariables() recently which made me assume a flaw due to greedy
    matching.

    Next release 2.0.5 will have this fixed.

    ------------------------------------------------------------------------

    [2011-03-14 14:15:56] till

    -Status: Feedback
    +Status: Closed
    This bug has been fixed in SVN.

    If this was a documentation problem, the fix will appear on pear.php.net
    by the end of next Sunday (CET).

    If this was a problem with the pear.php.net website, the change should
    be live shortly.

    Otherwise, the fix will appear in the package's next release.

    Thank you for the report and for helping us make PEAR better.

    Epic win!!!11

    ------------------------------------------------------------------------

    [2011-03-14 08:50:34] cweiske

    Yes, your patch fixes the problem.

    ------------------------------------------------------------------------

    [2011-03-13 13:39:44] till

    I think this might have been fixed by another bugfix I did. Anyway, I
    tried to make sense of the example code and
    committed a unit test with it. The unit test runs.

    http://svn.php.net/viewvc?view=revision&revision=309168

    Wouldn't mind if ANYONE could take a look so this is finished and we can
    move on a new release.

    ------------------------------------------------------------------------

    [2011-03-13 02:49:36] till

    -Status: Open
    +Status: Feedback
    -Assigned To:
    +Assigned To: till
    Lukas,

    you mind providing some example code which I could wrap into a unit
    test?

    Till

    ------------------------------------------------------------------------

    The remainder of the comments for this report are too long. To view
    the rest of the comments, please view the bug report online at
         http://pear.php.net/bugs/bug.php?id=17036

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
grouppear-bugs @
categoriesphp
postedJan 1, '14 at 8:31p
activeJan 1, '14 at 10:28p
posts2
users1
websitepear.php.net

1 user in discussion

Tklingenberg: 2 posts

People

Translate

site design / logo © 2022 Grokbase