Edit report at https://pear.php.net/bugs/bug.php?id=17156&edit=1

ID: 17156
Updated by: daniel.oconnor@gmail.com
Reported By: mj at php dot net
Summary: Don't call Auth::updateIdle() statically
-Status: Open
+Status: Closed
Type: Feature/Change Request
Package: Auth
Operating System: all
Package Version: SVN
PHP Version: Irrelevant
-Assigned To:
+Assigned To: doconnor
Roadmap Versions:
New Comment:

-Status: Open
+Status: Closed
-Assigned To:
+Assigned To: doconnor
This bug has been fixed in SVN.

If this was a documentation problem, the fix will appear on pear.php.net
by the end of next Sunday (CET).

If this was a problem with the pear.php.net website, the change should
be live shortly.

Otherwise, the fix will appear in the package's next release.

Thank you for the report and for helping us make PEAR better.

Previous Comments:

[2010-02-25 08:19:12] mj

Added #patch bug:17156;patch:patch;revision:1267085952;.


[2010-02-25 08:18:29] mj

The method Auth::updateIdle() is called statically from within
Auth::checkAuth(), while it would be more correct if it was called
within the object's context using $this->updateIdle(). There are two
reasons for this:

1) First of all updateIdle() modifies the state of the instance by
changing the value of $this->session.

2) The current way of calling the method makes it impossible to
overwrite it in a subclass.

A trivial patch to fix this is attached.


Search Discussions

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
grouppear-bugs @
postedJan 25, '12 at 2:01p
activeJan 25, '12 at 2:01p

1 user in discussion

Daniel Oconnor: 1 post



site design / logo © 2022 Grokbase