FAQ
Edit report at https://pear.php.net/bugs/bug.php?id=19177&edit=1

ID: 19177
Updated by: daniel.oconnor@gmail.com
Reported By: danielc at analysisandsolutions dot com
Summary: TONS of test failures
Status: Open
Type: Bug
Package: Date_Holidays_Australia
Package Version: SVN
PHP Version: 5_4 SVN-2012-01-01
Roadmap Versions:
New Comment:

So... a number of these are simply holidays which are not yet
implemented properly.

IE:
28) Date_Holidays_Driver_AustraliaSA_TestSuite::testHolidays with data
set #10
('proclamationDay', 2013, array(26, 12, 2013))
Invalid internal name: proclamationDay

... the driver doesn't yet implement it.


Previous Comments:
------------------------------------------------------------------------

[2012-01-01 15:02:04] danielc

Description:
------------
The Australia package has an astounding number of test failures
(something like 60)
http://test.pear.php.net:8080/job/Date_Holidays/13/testReport/

------------------------------------------------------------------------

Search Discussions

  • Danielc at Jan 3, 2012 at 12:29 am
    Edit report at https://pear.php.net/bugs/bug.php?id=19177&edit=1

    ID: 19177
    Updated by: danielc@analysisandsolutions.com
    Reported By: danielc at analysisandsolutions dot com
    Summary: TONS of test failures
    Status: Open
    Type: Bug
    Package: Date_Holidays_Australia
    Package Version: SVN
    PHP Version: 5_4 SVN-2012-01-01
    Roadmap Versions:
    New Comment:

    Then the Date_Holidays_Driver_Australia* test scripts need to put in
    calls to "$this->markTestIncomplete()" where appropriate.


    Previous Comments:
    ------------------------------------------------------------------------

    [2012-01-02 23:34:19] doconnor

    So... a number of these are simply holidays which are not yet
    implemented properly.

    IE:
    28) Date_Holidays_Driver_AustraliaSA_TestSuite::testHolidays with data
    set #10
    ('proclamationDay', 2013, array(26, 12, 2013))
    Invalid internal name: proclamationDay

    ... the driver doesn't yet implement it.

    ------------------------------------------------------------------------

    [2012-01-01 15:02:04] danielc

    Description:
    ------------
    The Australia package has an astounding number of test failures
    (something like 60)
    http://test.pear.php.net:8080/job/Date_Holidays/13/testReport/

    ------------------------------------------------------------------------
  • Daniel Oconnor at Jan 4, 2012 at 12:53 pm
    Edit report at https://pear.php.net/bugs/bug.php?id=19177&edit=1

    ID: 19177
    Updated by: daniel.oconnor@gmail.com
    Reported By: danielc at analysisandsolutions dot com
    Summary: TONS of test failures
    Status: Open
    Type: Bug
    Package: Date_Holidays_Australia
    Package Version: SVN
    PHP Version: 5_4 SVN-2012-01-01
    Roadmap Versions:
    New Comment:

    Somewhat improved at the moment.
    I'm not too inclined to markTestSkipped / Incomplete on these, as the
    tests are
    actually done - but the code isn't right.

    Will keep plugging away.


    Previous Comments:
    ------------------------------------------------------------------------

    [2012-01-03 01:30:15] danielc

    Then the Date_Holidays_Driver_Australia* test scripts need to put in
    calls to "$this->markTestIncomplete()" where appropriate.

    ------------------------------------------------------------------------

    [2012-01-02 23:34:19] doconnor

    So... a number of these are simply holidays which are not yet
    implemented properly.

    IE:
    28) Date_Holidays_Driver_AustraliaSA_TestSuite::testHolidays with data
    set #10
    ('proclamationDay', 2013, array(26, 12, 2013))
    Invalid internal name: proclamationDay

    ... the driver doesn't yet implement it.

    ------------------------------------------------------------------------

    [2012-01-01 15:02:04] danielc

    Description:
    ------------
    The Australia package has an astounding number of test failures
    (something like 60)
    http://test.pear.php.net:8080/job/Date_Holidays/13/testReport/

    ------------------------------------------------------------------------
  • Daniel Oconnor at Jan 4, 2012 at 2:17 pm
    Edit report at https://pear.php.net/bugs/bug.php?id=19177&edit=1

    ID: 19177
    Updated by: daniel.oconnor@gmail.com
    Reported By: danielc at analysisandsolutions dot com
    Summary: TONS of test failures
    -Status: Open
    +Status: Closed
    Type: Bug
    Package: Date_Holidays_Australia
    Package Version: SVN
    PHP Version: 5_4 SVN-2012-01-01
    -Assigned To:
    +Assigned To: doconnor
    Roadmap Versions:
    New Comment:

    -Status: Open
    +Status: Closed
    -Assigned To:
    +Assigned To: doconnor
    This bug has been fixed in SVN.

    If this was a documentation problem, the fix will appear on pear.php.net
    by the end of next Sunday (CET).

    If this was a problem with the pear.php.net website, the change should
    be live shortly.

    Otherwise, the fix will appear in the package's next release.

    Thank you for the report and for helping us make PEAR better.

    AU related tests only fixed in SVN.


    Previous Comments:
    ------------------------------------------------------------------------

    [2012-01-04 13:54:09] doconnor

    Somewhat improved at the moment.
    I'm not too inclined to markTestSkipped / Incomplete on these, as the
    tests are
    actually done - but the code isn't right.

    Will keep plugging away.

    ------------------------------------------------------------------------

    [2012-01-03 01:30:15] danielc

    Then the Date_Holidays_Driver_Australia* test scripts need to put in
    calls to "$this->markTestIncomplete()" where appropriate.

    ------------------------------------------------------------------------

    [2012-01-02 23:34:19] doconnor

    So... a number of these are simply holidays which are not yet
    implemented properly.

    IE:
    28) Date_Holidays_Driver_AustraliaSA_TestSuite::testHolidays with data
    set #10
    ('proclamationDay', 2013, array(26, 12, 2013))
    Invalid internal name: proclamationDay

    ... the driver doesn't yet implement it.

    ------------------------------------------------------------------------

    [2012-01-01 15:02:04] danielc

    Description:
    ------------
    The Australia package has an astounding number of test failures
    (something like 60)
    http://test.pear.php.net:8080/job/Date_Holidays/13/testReport/

    ------------------------------------------------------------------------

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
grouppear-bugs @
categoriesphp
postedJan 2, '12 at 10:33p
activeJan 4, '12 at 2:17p
posts4
users2
websitepear.php.net

2 users in discussion

Daniel Oconnor: 3 posts Danielc: 1 post

People

Translate

site design / logo © 2022 Grokbase