FAQ
Edit report at https://pear.php.net/bugs/bug.php?id=17532&edit=1

ID: 17532
Updated by: daniel.oconnor@gmail.com
Reported By: daniel dot oconnor at gmail dot com
Summary: Improve coding style
-Status: Open
+Status: Assigned
Type: Feature/Change Request
Package: Image_Barcode
Package Version: SVN
PHP Version: Irrelevant
Roadmap Versions:
New Comment:

-Status: Open
+Status: Assigned
Ah thanks for the patch Gemor - but this one is stable. Let's make an
Image_Barcode2 with your patch basically.


Previous Comments:
------------------------------------------------------------------------

[2010-10-10 12:46:42] gemorroj

Added #patch bug:17532;patch:diff;revision:1286714801;.

------------------------------------------------------------------------

[2010-06-29 01:03:39] doconnor

(and SVN dir structure layout)

------------------------------------------------------------------------

[2010-06-29 01:03:18] doconnor

Description:
------------
There are a number of little coding style annoyances which could be
re-visited.

1. Run phpcs
2. Avoid statement like:

if ($error) {
return $imgerror;
} else {
return $img;
}
3. Look at unit tests - there is 0% coverage
4. Consider wrappers around standard functionality to promote
testability (imagefontwidth() ImageColorAllocate(), ImageCreate() etc
can't be mocked out)
5. Evaluate old PHP4 practices which can be safely abandoned (ie: Bug
#17531)

------------------------------------------------------------------------

Search Discussions

  • Daniel Oconnor at Dec 10, 2011 at 12:05 pm
    Edit report at https://pear.php.net/bugs/bug.php?id=17532&edit=1

    ID: 17532
    Updated by: daniel.oconnor@gmail.com
    Reported By: daniel dot oconnor at gmail dot com
    Summary: Improve coding style
    -Status: Open
    +Status: Closed
    Type: Feature/Change Request
    Package: Image_Barcode
    Package Version: SVN
    PHP Version: Irrelevant
    -Assigned To:
    +Assigned To: doconnor
    Roadmap Versions:
    New Comment:

    -Status: Open
    +Status: Closed
    -Assigned To:
    +Assigned To: doconnor
    This bug has been fixed in SVN.

    If this was a documentation problem, the fix will appear on pear.php.net
    by the end of next Sunday (CET).

    If this was a problem with the pear.php.net website, the change should
    be live shortly.

    Otherwise, the fix will appear in the package's next release.

    Thank you for the report and for helping us make PEAR better.




    Previous Comments:
    ------------------------------------------------------------------------

    [2011-12-10 12:49:49] doconnor

    -Status: Open
    +Status: Assigned
    Ah thanks for the patch Gemor - but this one is stable. Let's make an
    Image_Barcode2 with your patch basically.

    ------------------------------------------------------------------------

    [2010-10-10 12:46:42] gemorroj

    Added #patch bug:17532;patch:diff;revision:1286714801;.

    ------------------------------------------------------------------------

    [2010-06-29 01:03:39] doconnor

    (and SVN dir structure layout)

    ------------------------------------------------------------------------

    [2010-06-29 01:03:18] doconnor

    Description:
    ------------
    There are a number of little coding style annoyances which could be
    re-visited.

    1. Run phpcs
    2. Avoid statement like:

    if ($error) {
    return $imgerror;
    } else {
    return $img;
    }
    3. Look at unit tests - there is 0% coverage
    4. Consider wrappers around standard functionality to promote
    testability (imagefontwidth() ImageColorAllocate(), ImageCreate() etc
    can't be mocked out)
    5. Evaluate old PHP4 practices which can be safely abandoned (ie: Bug
    #17531)

    ------------------------------------------------------------------------
  • Daniel Oconnor at Dec 10, 2011 at 12:08 pm
    Edit report at https://pear.php.net/bugs/bug.php?id=17532&edit=1

    ID: 17532
    Updated by: daniel.oconnor@gmail.com
    Reported By: daniel dot oconnor at gmail dot com
    Summary: Improve coding style
    Status: Closed
    Type: Feature/Change Request
    Package: Image_Barcode
    Package Version: SVN
    PHP Version: Irrelevant
    Assigned To: doconnor
    Roadmap Versions:
    New Comment:

    See https://github.com/pear/Image_Barcode2/


    Previous Comments:
    ------------------------------------------------------------------------

    [2011-12-10 13:05:37] doconnor

    -Status: Open
    +Status: Closed
    -Assigned To:
    +Assigned To: doconnor
    This bug has been fixed in SVN.

    If this was a documentation problem, the fix will appear on pear.php.net
    by the end of next Sunday (CET).

    If this was a problem with the pear.php.net website, the change should
    be live shortly.

    Otherwise, the fix will appear in the package's next release.

    Thank you for the report and for helping us make PEAR better.

    ------------------------------------------------------------------------

    [2011-12-10 12:49:49] doconnor

    -Status: Open
    +Status: Assigned
    Ah thanks for the patch Gemor - but this one is stable. Let's make an
    Image_Barcode2 with your patch basically.

    ------------------------------------------------------------------------

    [2010-10-10 12:46:42] gemorroj

    Added #patch bug:17532;patch:diff;revision:1286714801;.

    ------------------------------------------------------------------------

    [2010-06-29 01:03:39] doconnor

    (and SVN dir structure layout)

    ------------------------------------------------------------------------

    [2010-06-29 01:03:18] doconnor

    Description:
    ------------
    There are a number of little coding style annoyances which could be
    re-visited.

    1. Run phpcs
    2. Avoid statement like:

    if ($error) {
    return $imgerror;
    } else {
    return $img;
    }
    3. Look at unit tests - there is 0% coverage
    4. Consider wrappers around standard functionality to promote
    testability (imagefontwidth() ImageColorAllocate(), ImageCreate() etc
    can't be mocked out)
    5. Evaluate old PHP4 practices which can be safely abandoned (ie: Bug
    #17531)

    ------------------------------------------------------------------------
  • Wapinet at Dec 10, 2011 at 12:40 pm
    Edit report at https://pear.php.net/bugs/bug.php?id=17532&edit=1

    ID: 17532
    Comment by: wapinet@mail.ru
    Reported By: daniel dot oconnor at gmail dot com
    Summary: Improve coding style
    Status: Closed
    Type: Feature/Change Request
    Package: Image_Barcode
    Package Version: SVN
    PHP Version: Irrelevant
    Assigned To: doconnor
    Roadmap Versions:
    New Comment:

    Thanks! ;)


    Previous Comments:
    ------------------------------------------------------------------------

    [2011-12-10 13:08:15] doconnor

    See https://github.com/pear/Image_Barcode2/

    ------------------------------------------------------------------------

    [2011-12-10 13:05:37] doconnor

    -Status: Open
    +Status: Closed
    -Assigned To:
    +Assigned To: doconnor
    This bug has been fixed in SVN.

    If this was a documentation problem, the fix will appear on pear.php.net
    by the end of next Sunday (CET).

    If this was a problem with the pear.php.net website, the change should
    be live shortly.

    Otherwise, the fix will appear in the package's next release.

    Thank you for the report and for helping us make PEAR better.

    ------------------------------------------------------------------------

    [2011-12-10 12:49:49] doconnor

    -Status: Open
    +Status: Assigned
    Ah thanks for the patch Gemor - but this one is stable. Let's make an
    Image_Barcode2 with your patch basically.

    ------------------------------------------------------------------------

    [2010-10-10 12:46:42] gemorroj

    Added #patch bug:17532;patch:diff;revision:1286714801;.

    ------------------------------------------------------------------------

    [2010-06-29 01:03:39] doconnor

    (and SVN dir structure layout)

    ------------------------------------------------------------------------

    The remainder of the comments for this report are too long. To view
    the rest of the comments, please view the bug report online at
    http://pear.php.net/bugs/bug.php?id=17532

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
grouppear-bugs @
categoriesphp
postedDec 10, '11 at 11:50a
activeDec 10, '11 at 12:40p
posts4
users2
websitepear.php.net

2 users in discussion

Daniel Oconnor: 3 posts Wapinet: 1 post

People

Translate

site design / logo © 2022 Grokbase