FAQ
Edit report at http://pear.php.net/bugs/bug.php?id=19061&edit=1

ID: 19061
Updated by: daniel.oconnor@gmail.com
Reported By: kukulich at kukulich dot cz
Summary: Tests don't work with PHPUnit 3.6
Status: Open
Type: Bug
Package: PHP_CodeSniffer
Package Version: SVN
PHP Version: Irrelevant
Roadmap Versions:
New Comment:

How so?
http://test.pear.php.net:8080/job/PHP_CodeSniffer/8/console


Previous Comments:
------------------------------------------------------------------------

[2011-11-20 10:16:34] kukulich

Description:
------------
It only looks as it does tests but in fact it doesn't test anything.

------------------------------------------------------------------------

Search Discussions

  • Daniel Oconnor at Nov 20, 2011 at 9:04 pm
    Edit report at http://pear.php.net/bugs/bug.php?id=19061&edit=1

    ID: 19061
    Updated by: daniel.oconnor@gmail.com
    Reported By: kukulich at kukulich dot cz
    Summary: Tests don't work with PHPUnit 3.6
    -Status: Open
    +Status: Feedback
    Type: Bug
    Package: PHP_CodeSniffer
    Package Version: SVN
    PHP Version: Irrelevant
    Roadmap Versions:
    New Comment:

    -Status: Open
    +Status: Feedback



    Previous Comments:
    ------------------------------------------------------------------------

    [2011-11-20 22:03:41] doconnor

    How so?
    http://test.pear.php.net:8080/job/PHP_CodeSniffer/8/console

    ------------------------------------------------------------------------

    [2011-11-20 10:16:34] kukulich

    Description:
    ------------
    It only looks as it does tests but in fact it doesn't test anything.

    ------------------------------------------------------------------------
  • Kukulich at Nov 20, 2011 at 9:22 pm
    Edit report at http://pear.php.net/bugs/bug.php?id=19061&edit=1

    ID: 19061
    Updated by: kukulich@kukulich.cz
    Reported By: kukulich at kukulich dot cz
    Summary: Tests don't work with PHPUnit 3.6
    Status: Feedback
    Type: Bug
    Package: PHP_CodeSniffer
    -Operating System:
    +Operating System: Windows
    Package Version: SVN
    PHP Version: Irrelevant
    Roadmap Versions:
    New Comment:

    -Operating System:
    +Operating System: Windows
    I'm sorry, I switched to wrong branch on my clone. The problem should be
    fixed with my pull request
    https://github.com/squizlabs/PHP_CodeSniffer/pull/3

    However it's strange that I see 2 results. It looks that it runs the
    tests twice on Windows:

    p:\Git\php-codesniffer>phpunit tests\AllTests.php

    PHPUnit 3.6.3 by Sebastian Bergmann.

    ............................................................... 63 /
    209 ( 30%)
    ............................................................... 126 /
    209 ( 60%)
    .........................SS.................................... 189 /
    209 ( 90%)
    .................S..

    Time: 32 seconds, Memory: 25.75Mb

    OK, but incomplete or skipped tests!
    Tests: 209, Assertions: 150, Skipped: 3.
    PHPUnit 3.6.3 by Sebastian Bergmann.

    ............................................................... 63 /
    209 ( 30%)
    ............................................................... 126 /
    209 ( 60%)
    .........................SS.................................... 189 /
    209 ( 90%)
    .................S..

    Time: 01:04, Memory: 28.00Mb

    OK, but incomplete or skipped tests!
    Tests: 209, Assertions: 150, Skipped: 3.


    Previous Comments:
    ------------------------------------------------------------------------

    [2011-11-20 22:03:58] doconnor

    -Status: Open
    +Status: Feedback


    ------------------------------------------------------------------------

    [2011-11-20 22:03:41] doconnor

    How so?
    http://test.pear.php.net:8080/job/PHP_CodeSniffer/8/console

    ------------------------------------------------------------------------

    [2011-11-20 10:16:34] kukulich

    Description:
    ------------
    It only looks as it does tests but in fact it doesn't test anything.

    ------------------------------------------------------------------------
  • Gsherwood at Nov 20, 2011 at 9:28 pm
    Edit report at http://pear.php.net/bugs/bug.php?id=19061&edit=1

    ID: 19061
    Updated by: gsherwood@squiz.net
    Reported By: kukulich at kukulich dot cz
    Summary: Tests don't work with PHPUnit 3.6
    Status: Feedback
    Type: Bug
    Package: PHP_CodeSniffer
    Operating System: Windows
    Package Version: SVN
    PHP Version: Irrelevant
    -Assigned To:
    +Assigned To: squiz
    Roadmap Versions:
    New Comment:

    -Assigned To:
    +Assigned To: squiz
    Testing with PHPUnit 3.6.3, it certainly does test the files (I can
    generate failures
    pretty easily) but it also runs the whole test suite twice and generates
    the error list
    twice.

    That's not ideal and I'll have to look into it. Although I still don't
    understand the
    original report. How do you know the tests aren't testing anything?


    Previous Comments:
    ------------------------------------------------------------------------

    [2011-11-20 22:21:29] kukulich

    -Operating System:
    +Operating System: Windows
    I'm sorry, I switched to wrong branch on my clone. The problem should be
    fixed with my pull request
    https://github.com/squizlabs/PHP_CodeSniffer/pull/3

    However it's strange that I see 2 results. It looks that it runs the
    tests twice on Windows:

    p:\Git\php-codesniffer>phpunit tests\AllTests.php

    PHPUnit 3.6.3 by Sebastian Bergmann.

    ............................................................... 63 /
    209 ( 30%)
    ............................................................... 126 /
    209 ( 60%)
    .........................SS.................................... 189 /
    209 ( 90%)
    .................S..

    Time: 32 seconds, Memory: 25.75Mb

    OK, but incomplete or skipped tests!
    Tests: 209, Assertions: 150, Skipped: 3.
    PHPUnit 3.6.3 by Sebastian Bergmann.

    ............................................................... 63 /
    209 ( 30%)
    ............................................................... 126 /
    209 ( 60%)
    .........................SS.................................... 189 /
    209 ( 90%)
    .................S..

    Time: 01:04, Memory: 28.00Mb

    OK, but incomplete or skipped tests!
    Tests: 209, Assertions: 150, Skipped: 3.

    ------------------------------------------------------------------------

    [2011-11-20 22:03:58] doconnor

    -Status: Open
    +Status: Feedback


    ------------------------------------------------------------------------

    [2011-11-20 22:03:41] doconnor

    How so?
    http://test.pear.php.net:8080/job/PHP_CodeSniffer/8/console

    ------------------------------------------------------------------------

    [2011-11-20 10:16:34] kukulich

    Description:
    ------------
    It only looks as it does tests but in fact it doesn't test anything.

    ------------------------------------------------------------------------
  • Gsherwood at Nov 20, 2011 at 9:29 pm
    Edit report at http://pear.php.net/bugs/bug.php?id=19061&edit=1

    ID: 19061
    Updated by: gsherwood@squiz.net
    Reported By: kukulich at kukulich dot cz
    Summary: Tests don't work with PHPUnit 3.6
    Status: Feedback
    Type: Bug
    Package: PHP_CodeSniffer
    Package Version: SVN
    PHP Version: Irrelevant
    Assigned To: squiz
    Roadmap Versions:
    New Comment:

    Missed your reply by a few mins :) Thanks for the follow-up.


    Previous Comments:
    ------------------------------------------------------------------------

    [2011-11-20 22:27:59] squiz

    -Assigned To:
    +Assigned To: squiz
    Testing with PHPUnit 3.6.3, it certainly does test the files (I can
    generate failures
    pretty easily) but it also runs the whole test suite twice and generates
    the error list
    twice.

    That's not ideal and I'll have to look into it. Although I still don't
    understand the
    original report. How do you know the tests aren't testing anything?

    ------------------------------------------------------------------------

    [2011-11-20 22:21:29] kukulich

    -Operating System:
    +Operating System: Windows
    I'm sorry, I switched to wrong branch on my clone. The problem should be
    fixed with my pull request
    https://github.com/squizlabs/PHP_CodeSniffer/pull/3

    However it's strange that I see 2 results. It looks that it runs the
    tests twice on Windows:

    p:\Git\php-codesniffer>phpunit tests\AllTests.php

    PHPUnit 3.6.3 by Sebastian Bergmann.

    ............................................................... 63 /
    209 ( 30%)
    ............................................................... 126 /
    209 ( 60%)
    .........................SS.................................... 189 /
    209 ( 90%)
    .................S..

    Time: 32 seconds, Memory: 25.75Mb

    OK, but incomplete or skipped tests!
    Tests: 209, Assertions: 150, Skipped: 3.
    PHPUnit 3.6.3 by Sebastian Bergmann.

    ............................................................... 63 /
    209 ( 30%)
    ............................................................... 126 /
    209 ( 60%)
    .........................SS.................................... 189 /
    209 ( 90%)
    .................S..

    Time: 01:04, Memory: 28.00Mb

    OK, but incomplete or skipped tests!
    Tests: 209, Assertions: 150, Skipped: 3.

    ------------------------------------------------------------------------

    [2011-11-20 22:03:58] doconnor

    -Status: Open
    +Status: Feedback


    ------------------------------------------------------------------------

    [2011-11-20 22:03:41] doconnor

    How so?
    http://test.pear.php.net:8080/job/PHP_CodeSniffer/8/console

    ------------------------------------------------------------------------

    [2011-11-20 10:16:34] kukulich

    Description:
    ------------
    It only looks as it does tests but in fact it doesn't test anything.

    ------------------------------------------------------------------------
  • Gsherwood at Nov 21, 2011 at 2:56 am
    Edit report at http://pear.php.net/bugs/bug.php?id=19061&edit=1

    ID: 19061
    Updated by: gsherwood@squiz.net
    Reported By: kukulich at kukulich dot cz
    Summary: Tests don't work with PHPUnit 3.6
    -Status: Feedback
    +Status: Closed
    Type: Bug
    Package: PHP_CodeSniffer
    Package Version: SVN
    PHP Version: Irrelevant
    Assigned To: squiz
    Roadmap Versions:
    New Comment:

    -Status: Feedback
    +Status: Closed
    I pushed out a change to the AllTests.php file to stop it running twice.
    This means it
    will, presumable, not work with PHPUnit < 3.6, but I dont have another
    install to try it
    and I'm not too fussed. As long as it works on the latest.


    Previous Comments:
    ------------------------------------------------------------------------

    [2011-11-20 22:29:00] squiz

    Missed your reply by a few mins :) Thanks for the follow-up.

    ------------------------------------------------------------------------

    [2011-11-20 22:27:59] squiz

    -Assigned To:
    +Assigned To: squiz
    Testing with PHPUnit 3.6.3, it certainly does test the files (I can
    generate failures
    pretty easily) but it also runs the whole test suite twice and generates
    the error list
    twice.

    That's not ideal and I'll have to look into it. Although I still don't
    understand the
    original report. How do you know the tests aren't testing anything?

    ------------------------------------------------------------------------

    [2011-11-20 22:21:29] kukulich

    -Operating System:
    +Operating System: Windows
    I'm sorry, I switched to wrong branch on my clone. The problem should be
    fixed with my pull request
    https://github.com/squizlabs/PHP_CodeSniffer/pull/3

    However it's strange that I see 2 results. It looks that it runs the
    tests twice on Windows:

    p:\Git\php-codesniffer>phpunit tests\AllTests.php

    PHPUnit 3.6.3 by Sebastian Bergmann.

    ............................................................... 63 /
    209 ( 30%)
    ............................................................... 126 /
    209 ( 60%)
    .........................SS.................................... 189 /
    209 ( 90%)
    .................S..

    Time: 32 seconds, Memory: 25.75Mb

    OK, but incomplete or skipped tests!
    Tests: 209, Assertions: 150, Skipped: 3.
    PHPUnit 3.6.3 by Sebastian Bergmann.

    ............................................................... 63 /
    209 ( 30%)
    ............................................................... 126 /
    209 ( 60%)
    .........................SS.................................... 189 /
    209 ( 90%)
    .................S..

    Time: 01:04, Memory: 28.00Mb

    OK, but incomplete or skipped tests!
    Tests: 209, Assertions: 150, Skipped: 3.

    ------------------------------------------------------------------------

    [2011-11-20 22:03:58] doconnor

    -Status: Open
    +Status: Feedback


    ------------------------------------------------------------------------

    [2011-11-20 22:03:41] doconnor

    How so?
    http://test.pear.php.net:8080/job/PHP_CodeSniffer/8/console

    ------------------------------------------------------------------------

    The remainder of the comments for this report are too long. To view
    the rest of the comments, please view the bug report online at
    http://pear.php.net/bugs/bug.php?id=19061

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
grouppear-bugs @
categoriesphp
postedNov 20, '11 at 9:04p
activeNov 21, '11 at 2:56a
posts6
users3
websitepear.php.net

People

Translate

site design / logo © 2021 Grokbase