[PEAR-BUG] Bug #18782 [Opn->Ver]: class tree generation mistake

Edit report at http://pear.php.net/bugs/bug.php?id=18782&edit=1

ID: 18782
Updated by: demon.gene@gmail.com
Reported By: drunkenstranger at gmail dot com
Summary: class tree generation mistake
Status: Verified
Type: Bug
Package: PhpDocumentor
Package Version: SVN
PHP Version: 5.2.12
Assigned To: ashnazg
Roadmap Versions:
New Comment:

Verified bug behavior on phpDocumentor 1.4.3 using PHP 5.3.8, 5.2.17,
and 4.4.9. Interestingly, it's only visible in MyPackage2's Class List
view... the Class List for Package1 shows the correct hierarchy layout
of "MyClass5 is child of MyClass2".


Previous Comments:
------------------------------------------------------------------------

[2011-09-23 22:26:32] ashnazg

-Status: Open
+Status: Verified
-Assigned To:
+Assigned To: ashnazg
-Roadmap Versions:
+Roadmap Versions: 1.4.4


------------------------------------------------------------------------

[2011-09-03 02:20:12] drunkenstranger

Added #patch bug:18782;patch:classtree-fix.patch;revision:1315012812;.

------------------------------------------------------------------------

[2011-09-03 02:10:26] drunkenstranger

Description:
------------
When class tree generated if one of #root child have her own childs,
class tree list losts inheritance level.

Test script:
---------------
<?php

/** Test file for MyPackage2 class tree
* @package MyPackage2
*/

/** @package MyPackage1
*/
class MyClass1 {}

/** @package MyPackage2
*/
class MyClass2 extends MyClass1 {}

/** @package MyPackage2
*/
class MyClass3 extends MyClass2 {}

/** @package MyPackage2
*/
class MyClass4 extends MyClass3 {}

/** @package MyPackage2
*/
class MyClass5 extends MyClass2 {}

?>

Expected result:
----------------
MyClass1 (Different package)
MyClass2
MyClass3
MyClass4
MyClass5

Actual result:
--------------
MyClass1 (Different package)
MyClass2
MyClass3
MyClass4
MyClass5

------------------------------------------------------------------------

Edit report at http://pear.php.net/bugs/bug.php?id=18782&edit=1

ID: 18782
Updated by: demon.gene@gmail.com
Reported By: drunkenstranger at gmail dot com
Summary: class tree generation mistake
Status: Verified
Type: Bug
Package: PhpDocumentor
Package Version: SVN
PHP Version: 5.2.12
Assigned To: ashnazg
Roadmap Versions:
New Comment:

Verified bug exists in current SVN version of phpDocumentor too, on PHPs
5.3.8, 5.2.17, and 4.4.9.


Previous Comments:
------------------------------------------------------------------------

[2011-09-23 22:57:26] ashnazg

Verified bug behavior on phpDocumentor 1.4.3 using PHP 5.3.8, 5.2.17,
and 4.4.9. Interestingly, it's only visible in MyPackage2's Class List
view... the Class List for Package1 shows the correct hierarchy layout
of "MyClass5 is child of MyClass2".

------------------------------------------------------------------------

[2011-09-23 22:26:32] ashnazg

-Status: Open
+Status: Verified
-Assigned To:
+Assigned To: ashnazg
-Roadmap Versions:
+Roadmap Versions: 1.4.4


------------------------------------------------------------------------

[2011-09-03 02:20:12] drunkenstranger

Added #patch bug:18782;patch:classtree-fix.patch;revision:1315012812;.

------------------------------------------------------------------------

[2011-09-03 02:10:26] drunkenstranger

Description:
------------
When class tree generated if one of #root child have her own childs,
class tree list losts inheritance level.

Test script:
---------------
<?php

/** Test file for MyPackage2 class tree
* @package MyPackage2
*/

/** @package MyPackage1
*/
class MyClass1 {}

/** @package MyPackage2
*/
class MyClass2 extends MyClass1 {}

/** @package MyPackage2
*/
class MyClass3 extends MyClass2 {}

/** @package MyPackage2
*/
class MyClass4 extends MyClass3 {}

/** @package MyPackage2
*/
class MyClass5 extends MyClass2 {}

?>

Expected result:
----------------
MyClass1 (Different package)
MyClass2
MyClass3
MyClass4
MyClass5

Actual result:
--------------
MyClass1 (Different package)
MyClass2
MyClass3
MyClass4
MyClass5

------------------------------------------------------------------------

Edit report at http://pear.php.net/bugs/bug.php?id=18782&edit=1

ID: 18782
Updated by: demon.gene@gmail.com
Reported By: drunkenstranger at gmail dot com
Summary: class tree generation mistake
Status: Verified
Type: Bug
Package: PhpDocumentor
Package Version: SVN
PHP Version: 5.2.12
Assigned To: ashnazg
Roadmap Versions:
New Comment:

Patch does seem to fix test case across all three PHP versions (just
looking at HTML:frames:default converter at this point). Need to run
some larger regression tests to verify no unintended side effects.


Previous Comments:
------------------------------------------------------------------------

[2011-09-24 00:24:40] ashnazg

Verified bug exists in current SVN version of phpDocumentor too, on PHPs
5.3.8, 5.2.17, and 4.4.9.

------------------------------------------------------------------------

[2011-09-23 22:57:26] ashnazg

Verified bug behavior on phpDocumentor 1.4.3 using PHP 5.3.8, 5.2.17,
and 4.4.9. Interestingly, it's only visible in MyPackage2's Class List
view... the Class List for Package1 shows the correct hierarchy layout
of "MyClass5 is child of MyClass2".

------------------------------------------------------------------------

[2011-09-23 22:26:32] ashnazg

-Status: Open
+Status: Verified
-Assigned To:
+Assigned To: ashnazg
-Roadmap Versions:
+Roadmap Versions: 1.4.4


------------------------------------------------------------------------

[2011-09-03 02:20:12] drunkenstranger

Added #patch bug:18782;patch:classtree-fix.patch;revision:1315012812;.

------------------------------------------------------------------------

[2011-09-03 02:10:26] drunkenstranger

Description:
------------
When class tree generated if one of #root child have her own childs,
class tree list losts inheritance level.

Test script:
---------------
<?php

/** Test file for MyPackage2 class tree
* @package MyPackage2
*/

/** @package MyPackage1
*/
class MyClass1 {}

/** @package MyPackage2
*/
class MyClass2 extends MyClass1 {}

/** @package MyPackage2
*/
class MyClass3 extends MyClass2 {}

/** @package MyPackage2
*/
class MyClass4 extends MyClass3 {}

/** @package MyPackage2
*/
class MyClass5 extends MyClass2 {}

?>

Expected result:
----------------
MyClass1 (Different package)
MyClass2
MyClass3
MyClass4
MyClass5

Actual result:
--------------
MyClass1 (Different package)
MyClass2
MyClass3
MyClass4
MyClass5

------------------------------------------------------------------------

Edit report at http://pear.php.net/bugs/bug.php?id=18782&edit=1

ID: 18782
Updated by: demon.gene@gmail.com
Reported By: drunkenstranger at gmail dot com
Summary: class tree generation mistake
Status: Verified
Type: Bug
Package: PhpDocumentor
Package Version: SVN
PHP Version: 5.2.12
Assigned To: ashnazg
Roadmap Versions:
New Comment:

I see no regressions when running the patched phpDocumentor (just
HTML:frames:default converter) against the PhpDocumentor codebase
itself, compared with svn version of phpDocumentor against the same
target codebase.

Next step is to apply patches against all converter files, build a
larger test case (with many packages and many class levels), and run the
patched code using all output converters.


Previous Comments:
------------------------------------------------------------------------

[2011-09-24 00:42:03] ashnazg

Patch does seem to fix test case across all three PHP versions (just
looking at HTML:frames:default converter at this point). Need to run
some larger regression tests to verify no unintended side effects.

------------------------------------------------------------------------

[2011-09-24 00:24:40] ashnazg

Verified bug exists in current SVN version of phpDocumentor too, on PHPs
5.3.8, 5.2.17, and 4.4.9.

------------------------------------------------------------------------

[2011-09-23 22:57:26] ashnazg

Verified bug behavior on phpDocumentor 1.4.3 using PHP 5.3.8, 5.2.17,
and 4.4.9. Interestingly, it's only visible in MyPackage2's Class List
view... the Class List for Package1 shows the correct hierarchy layout
of "MyClass5 is child of MyClass2".

------------------------------------------------------------------------

[2011-09-23 22:26:32] ashnazg

-Status: Open
+Status: Verified
-Assigned To:
+Assigned To: ashnazg
-Roadmap Versions:
+Roadmap Versions: 1.4.4


------------------------------------------------------------------------

[2011-09-03 02:20:12] drunkenstranger

Added #patch bug:18782;patch:classtree-fix.patch;revision:1315012812;.

------------------------------------------------------------------------

The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
http://pear.php.net/bugs/bug.php?id=18782

Edit report at http://pear.php.net/bugs/bug.php?id=18782&edit=1

ID: 18782
Updated by: demon.gene@gmail.com
Reported By: drunkenstranger at gmail dot com
Summary: class tree generation mistake
Status: Verified
Type: Bug
Package: PhpDocumentor
Package Version: SVN
PHP Version: 5.2.12
Assigned To: ashnazg
Roadmap Versions:
New Comment:

Built a more complicated test case, implemented patches in all converter
files, ran all output converters. Bug behavior fixed in all cases.

Fix committed to SVN.


Previous Comments:
------------------------------------------------------------------------

[2011-09-24 03:25:21] ashnazg

I see no regressions when running the patched phpDocumentor (just
HTML:frames:default converter) against the PhpDocumentor codebase
itself, compared with svn version of phpDocumentor against the same
target codebase.

Next step is to apply patches against all converter files, build a
larger test case (with many packages and many class levels), and run the
patched code using all output converters.

------------------------------------------------------------------------

[2011-09-24 00:42:03] ashnazg

Patch does seem to fix test case across all three PHP versions (just
looking at HTML:frames:default converter at this point). Need to run
some larger regression tests to verify no unintended side effects.

------------------------------------------------------------------------

[2011-09-24 00:24:40] ashnazg

Verified bug exists in current SVN version of phpDocumentor too, on PHPs
5.3.8, 5.2.17, and 4.4.9.

------------------------------------------------------------------------

[2011-09-23 22:57:26] ashnazg

Verified bug behavior on phpDocumentor 1.4.3 using PHP 5.3.8, 5.2.17,
and 4.4.9. Interestingly, it's only visible in MyPackage2's Class List
view... the Class List for Package1 shows the correct hierarchy layout
of "MyClass5 is child of MyClass2".

------------------------------------------------------------------------

[2011-09-23 22:26:32] ashnazg

-Status: Open
+Status: Verified
-Assigned To:
+Assigned To: ashnazg
-Roadmap Versions:
+Roadmap Versions: 1.4.4


------------------------------------------------------------------------

The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
http://pear.php.net/bugs/bug.php?id=18782

Edit report at http://pear.php.net/bugs/bug.php?id=18782&edit=1

ID: 18782
Updated by: demon.gene@gmail.com
Reported By: drunkenstranger at gmail dot com
Summary: class tree generation mistake
-Status: Verified
+Status: Closed
Type: Bug
Package: PhpDocumentor
Package Version: SVN
PHP Version: 5.2.12
Assigned To: ashnazg
Roadmap Versions:
New Comment:

-Status: Verified
+Status: Closed



Previous Comments:
------------------------------------------------------------------------

[2011-09-24 06:32:11] ashnazg

Built a more complicated test case, implemented patches in all converter
files, ran all output converters. Bug behavior fixed in all cases.

Fix committed to SVN.

------------------------------------------------------------------------

[2011-09-24 03:25:21] ashnazg

I see no regressions when running the patched phpDocumentor (just
HTML:frames:default converter) against the PhpDocumentor codebase
itself, compared with svn version of phpDocumentor against the same
target codebase.

Next step is to apply patches against all converter files, build a
larger test case (with many packages and many class levels), and run the
patched code using all output converters.

------------------------------------------------------------------------

[2011-09-24 00:42:03] ashnazg

Patch does seem to fix test case across all three PHP versions (just
looking at HTML:frames:default converter at this point). Need to run
some larger regression tests to verify no unintended side effects.

------------------------------------------------------------------------

[2011-09-24 00:24:40] ashnazg

Verified bug exists in current SVN version of phpDocumentor too, on PHPs
5.3.8, 5.2.17, and 4.4.9.

------------------------------------------------------------------------

[2011-09-23 22:57:26] ashnazg

Verified bug behavior on phpDocumentor 1.4.3 using PHP 5.3.8, 5.2.17,
and 4.4.9. Interestingly, it's only visible in MyPackage2's Class List
view... the Class List for Package1 shows the correct hierarchy layout
of "MyClass5 is child of MyClass2".

------------------------------------------------------------------------

The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
http://pear.php.net/bugs/bug.php?id=18782