FAQ
Edit report at http://pear.php.net/bugs/bug.php?id=18844&edit=1

ID: 18844
Updated by: gsherwood@squiz.net
Reported By: dv at allyoucanthink dot de
Summary: Generic_Sniffs_CodeAnalysis_UnusedFunctionParameterSniff
with empty body
-Status: Open
+Status: Closed
Type: Bug
Package: PHP_CodeSniffer
Operating System: Irrelevant
Package Version: 1.3.0
PHP Version: Irrelevant
-Assigned To:
+Assigned To: squiz
Roadmap Versions:
New Comment:

-Status: Open
+Status: Closed
-Assigned To:
+Assigned To: squiz
This bug has been fixed in SVN.

If this was a documentation problem, the fix will appear on pear.php.net
by the end of next Sunday (CET).

If this was a problem with the pear.php.net website, the change should
be live shortly.

Otherwise, the fix will appear in the package's next release.

Thank you for the report and for helping us make PEAR better.

Thanks for the patch.


Previous Comments:
------------------------------------------------------------------------

[2011-09-19 12:55:33] dvino

Description:
------------
methods with empty body and return throws an UnusedParameters errors.
The problem is in the condition check on lines 97 and 104 in file
PHP_CodeSniffer/CodeSniffer/Standards/Generic/Sniffs/CodeAnalysis/UnusedFunctionParameterSniff.php:
$tokens[$tmp] === T_SEMICOLON, $tokens[$tmp] is an array so this
condition check is always false. Change to $tokens[$tmp]['code'] ===
T_SEMICOLON solves the problem

------------------------------------------------------------------------

Search Discussions

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
grouppear-bugs @
categoriesphp
postedSep 22, '11 at 1:25a
activeSep 22, '11 at 1:25a
posts1
users1
websitepear.php.net

1 user in discussion

Gsherwood: 1 post

People

Translate

site design / logo © 2022 Grokbase