Edit report at http://pear.php.net/bugs/bug.php?id=18828&edit=1

ID: 18828
Updated by: pear.php.net@illusori.co.uk
Reported By: pear dot php dot net at illusori dot co dot uk
Summary: [Patch] AbstractVariableSniff HEREDOC support and
regexp fix
-Status: Open
+Status: Duplicate
Type: Bug
Package: PHP_CodeSniffer
Operating System: Irrelevant
Package Version: SVN
PHP Version: Irrelevant
Roadmap Versions:
New Comment:

-Status: Open
+Status: Duplicate
Sorry, tracker got confused while I was registering and opened a
duplicate, other ticket has the patch.

Previous Comments:

[2011-09-12 22:08:08] illusori

Patch to add support for:
* spotting variables in HEREDOC strings to AbstractVariableSniff
* fixes the "variable in string" regexp so it will correctly detect
variables at the start of the string and corrects the backslash escaping
detection to be complete
* use same "am I a string?" detection for outside-scope as inside-scope
so it doesn't pass in function and class declarations to
* swap names of $listen and $scopes variables in constructor to match
their use and those in parent class.

Test script:
No tests since it's an abstract class, but these changes are backported
from a working class with test-suite in


Search Discussions

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
grouppear-bugs @
postedSep 12, '11 at 8:14p
activeSep 12, '11 at 8:14p

1 user in discussion

Pear Php Net: 1 post



site design / logo © 2022 Grokbase