Edit report at http://pear.php.net/bugs/bug.php?id=18403&edit=1

ID: 18403
Comment by: garrettw87@gmail.com
Reported By: garrettw87 at gmail dot com
Summary: Bug fixes, code formatting, added features
Status: Assigned
Type: Feature/Change Request
Package: Net_SmartIRC
Package Version: 1.0.2
PHP Version: Irrelevant
Assigned To: till
Roadmap Versions:
New Comment:

Original patch links have been updated with new unified diffs.

Previous Comments:

[2011-03-30 14:40:14] garrettw

Sorry -- I used WinMerge to create those. I'll have to look into using
diff on Windows or something.

And yes, I'd love to help out -- that's actually why I did this. meebey
told me to submit a patch as a coding sample for his evaluation before
he'd add me to it.


[2011-03-30 11:12:24] till

-Assigned To:
+Assigned To: till


[2011-03-30 00:15:02] till

Hey Garrett,

do you mind creating a unified diffs? They are more readable and easier
for me to apply.

Otherwise, patches look fine to me. Great job! Would you be interested
in helping out on this package?



[2011-03-28 11:59:10] garrettw

Well, I can't submit patches for some reason, so I'll just link to them



[2011-03-28 11:55:05] garrettw

The attached patch files fix bugs 13079, 16531, 16755, 17729, and

I also took the liberty of reformatting some of the code and comments to
comply with PEAR Coding Standards. It will still need more work though,
as this is only a partial fix. Also, all patches must be applied at the
same time due to some changes in the class names.

Lastly, I've added support for PHP's newer __construct()/__destruct()
methods which can now be used in place of module_init()/module_exit().
The latter methods are still supported for backward-compatibility.

I *think* that's everything, and I hope this patch works! :)


Search Discussions

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
grouppear-bugs @
postedMay 5, '11 at 5:34a
activeMay 5, '11 at 5:34a

1 user in discussion

Garrettw87: 1 post



site design / logo © 2022 Grokbase