Edit report at http://pear.php.net/bugs/bug.php?id=17729&edit=1
ID: 17729
Updated by: [email protected]
Reported By: olle dot jonsson at gmail dot com
Summary: patch: Removed define_syslog_variables and avoided
warning for socket blocking
Status: Assigned
Type: Bug
Package: Net_SmartIRC
Package Version: SVN
PHP Version: 5.3.1
Assigned To: olleolleolle
Roadmap Versions:
New Comment:
The alternative simply being to support only 5.3+ in the next major
release
Previous Comments:
------------------------------------------------------------------------
[2010-08-24 02:48:17] doconnor
-Assigned To:
+Assigned To: olleolleolle
------------------------------------------------------------------------
[2010-08-24 01:19:30] doconnor
r302734 applies the stream_set_blocking bit.
If memory serves, removing define_syslog_variables() will... well, leave
the syslog variables undefined in old php versions.
I don't suppose you can do some kind of ...
if (!defined()) {
// raise an error, pester user to ini_set define_syslog_variables ?
}
------------------------------------------------------------------------
[2010-08-17 22:23:30] olleolleolle
Added #patch
bug:17729;patch:avoid_deprecated.patch;revision:1282083810;.
------------------------------------------------------------------------
[2010-08-17 22:23:07] olleolleolle
Description:
------------
Removed the define_syslog_variables() call, which is not
needed to use the syslog constants. This avoids a deprecation
warning.
A new syntax has been invented for socket_set_blocking(), too.
The attached patch takes care of these two warnings.
------------------------------------------------------------------------
