Edit report at http://pear.php.net/bugs/bug.php?id=17437&edit=1
ID: 17437
Comment by: [email protected]
Reported By: pear at pascal dot corpet dot net
Summary: Deprecated: Assigning the return value of new by
reference
Status: Bogus
Type: Bug
Package: Text_Wiki
Operating System: Irrelevant
Package Version: SVN
PHP Version: 5.3.0
Assigned To: justinpatrin
Roadmap Versions:
New Comment:
Why not simply drop PHP4 compatibility as every else is doing /
suggesting ?
Previous Comments:
------------------------------------------------------------------------
[2010-06-04 19:19:15] caribou
@justinpatrin: I totally agree and find it quite annoying that there is
no way to make it work in both PHP4 and PHP5.3 without any warning.
There are few things that could be done:
- create a new branch that breaks PHP4 compatibility
- advertize that this package is not fully compatible with PHP5.3 and
later so that projects that want to be don't use it or accept to turn
off warnings
- explore more precisely the code to see what would be lost by taking of
the & (in most case it is a matter of copy time and memory allocation
for nothing but the code still works)
------------------------------------------------------------------------
[2010-06-04 18:07:48] justinpatrin
-Status: Feedback
+Status: Bogus
Unfortunately, unless I've missed a change in the rules, we can't make
this change since it would break BC with PHP4, which this package was
targeted at.
------------------------------------------------------------------------
[2010-06-03 22:10:34] caribou
@doconnor: search for "=& new" in Wiki.php
lines: 477, 1328, 1364, 1397
------------------------------------------------------------------------
[2010-06-03 01:12:59] doconnor
-Status: Assigned
+Status: Feedback
Pascal, got any specific line numbers?
------------------------------------------------------------------------
[2010-06-03 01:12:43] doconnor
-Assigned To:
+Assigned To: justinpatrin
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
http://pear.php.net/bugs/bug.php?id=17437
