FAQ
Edit report at http://pear.php.net/bugs/bug.php?id=18403&edit=1

ID: 18403
Comment by: garrettw87@gmail.com
Reported By: garrettw87 at gmail dot com
Summary: Bug fixes, code formatting, added features
Status: Open
Type: Feature/Change Request
Package: Net_SmartIRC
Package Version: 1.0.2
PHP Version: Irrelevant
Roadmap Versions:
New Comment:

Well, I can't submit patches for some reason, so I'll just link to them
here.

http://garrettw.net/smartirc/SmartIRC.patch.txt
http://garrettw.net/smartirc/defines.patch.txt
http://garrettw.net/smartirc/irccommands.patch.txt
http://garrettw.net/smartirc/messagehandler.patch.txt


Previous Comments:
------------------------------------------------------------------------

[2011-03-28 11:55:05] garrettw

Description:
------------
The attached patch files fix bugs 13079, 16531, 16755, 17729, and
17769.

I also took the liberty of reformatting some of the code and comments to
comply with PEAR Coding Standards. It will still need more work though,
as this is only a partial fix. Also, all patches must be applied at the
same time due to some changes in the class names.

Lastly, I've added support for PHP's newer __construct()/__destruct()
methods which can now be used in place of module_init()/module_exit().
The latter methods are still supported for backward-compatibility.

I *think* that's everything, and I hope this patch works! :)

------------------------------------------------------------------------

Search Discussions

  • Till at Mar 29, 2011 at 11:12 pm
    Edit report at http://pear.php.net/bugs/bug.php?id=18403&edit=1

    ID: 18403
    Updated by: till@php.net
    Reported By: garrettw87 at gmail dot com
    Summary: Bug fixes, code formatting, added features
    Status: Open
    Type: Feature/Change Request
    Package: Net_SmartIRC
    Package Version: 1.0.2
    PHP Version: Irrelevant
    Roadmap Versions:
    New Comment:

    Hey Garrett,

    do you mind creating a unified diffs? They are more readable and easier
    for me to apply.

    Otherwise, patches look fine to me. Great job! Would you be interested
    in helping out on this package?

    Till


    Previous Comments:
    ------------------------------------------------------------------------

    [2011-03-28 11:59:10] garrettw

    Well, I can't submit patches for some reason, so I'll just link to them
    here.

    http://garrettw.net/smartirc/SmartIRC.patch.txt
    http://garrettw.net/smartirc/defines.patch.txt
    http://garrettw.net/smartirc/irccommands.patch.txt
    http://garrettw.net/smartirc/messagehandler.patch.txt

    ------------------------------------------------------------------------

    [2011-03-28 11:55:05] garrettw

    Description:
    ------------
    The attached patch files fix bugs 13079, 16531, 16755, 17729, and
    17769.

    I also took the liberty of reformatting some of the code and comments to
    comply with PEAR Coding Standards. It will still need more work though,
    as this is only a partial fix. Also, all patches must be applied at the
    same time due to some changes in the class names.

    Lastly, I've added support for PHP's newer __construct()/__destruct()
    methods which can now be used in place of module_init()/module_exit().
    The latter methods are still supported for backward-compatibility.

    I *think* that's everything, and I hope this patch works! :)

    ------------------------------------------------------------------------
  • Till at Mar 30, 2011 at 10:10 am
    Edit report at http://pear.php.net/bugs/bug.php?id=18403&edit=1

    ID: 18403
    Updated by: till@php.net
    Reported By: garrettw87 at gmail dot com
    Summary: Bug fixes, code formatting, added features
    Status: Open
    Type: Feature/Change Request
    Package: Net_SmartIRC
    Package Version: 1.0.2
    PHP Version: Irrelevant
    -Assigned To:
    +Assigned To: till
    Roadmap Versions:
    New Comment:

    -Assigned To:
    +Assigned To: till



    Previous Comments:
    ------------------------------------------------------------------------

    [2011-03-30 00:15:02] till

    Hey Garrett,

    do you mind creating a unified diffs? They are more readable and easier
    for me to apply.

    Otherwise, patches look fine to me. Great job! Would you be interested
    in helping out on this package?

    Till

    ------------------------------------------------------------------------

    [2011-03-28 11:59:10] garrettw

    Well, I can't submit patches for some reason, so I'll just link to them
    here.

    http://garrettw.net/smartirc/SmartIRC.patch.txt
    http://garrettw.net/smartirc/defines.patch.txt
    http://garrettw.net/smartirc/irccommands.patch.txt
    http://garrettw.net/smartirc/messagehandler.patch.txt

    ------------------------------------------------------------------------

    [2011-03-28 11:55:05] garrettw

    Description:
    ------------
    The attached patch files fix bugs 13079, 16531, 16755, 17729, and
    17769.

    I also took the liberty of reformatting some of the code and comments to
    comply with PEAR Coding Standards. It will still need more work though,
    as this is only a partial fix. Also, all patches must be applied at the
    same time due to some changes in the class names.

    Lastly, I've added support for PHP's newer __construct()/__destruct()
    methods which can now be used in place of module_init()/module_exit().
    The latter methods are still supported for backward-compatibility.

    I *think* that's everything, and I hope this patch works! :)

    ------------------------------------------------------------------------
  • Garrettw87 at Mar 30, 2011 at 1:38 pm
    Edit report at http://pear.php.net/bugs/bug.php?id=18403&edit=1

    ID: 18403
    Comment by: garrettw87@gmail.com
    Reported By: garrettw87 at gmail dot com
    Summary: Bug fixes, code formatting, added features
    Status: Assigned
    Type: Feature/Change Request
    Package: Net_SmartIRC
    Package Version: 1.0.2
    PHP Version: Irrelevant
    Assigned To: till
    Roadmap Versions:
    New Comment:

    Sorry -- I used WinMerge to create those. I'll have to look into using
    diff on Windows or something.

    And yes, I'd love to help out -- that's actually why I did this. meebey
    told me to submit a patch as a coding sample for his evaluation before
    he'd add me to it.


    Previous Comments:
    ------------------------------------------------------------------------

    [2011-03-30 11:12:24] till

    -Assigned To:
    +Assigned To: till


    ------------------------------------------------------------------------

    [2011-03-30 00:15:02] till

    Hey Garrett,

    do you mind creating a unified diffs? They are more readable and easier
    for me to apply.

    Otherwise, patches look fine to me. Great job! Would you be interested
    in helping out on this package?

    Till

    ------------------------------------------------------------------------

    [2011-03-28 11:59:10] garrettw

    Well, I can't submit patches for some reason, so I'll just link to them
    here.

    http://garrettw.net/smartirc/SmartIRC.patch.txt
    http://garrettw.net/smartirc/defines.patch.txt
    http://garrettw.net/smartirc/irccommands.patch.txt
    http://garrettw.net/smartirc/messagehandler.patch.txt

    ------------------------------------------------------------------------

    [2011-03-28 11:55:05] garrettw

    Description:
    ------------
    The attached patch files fix bugs 13079, 16531, 16755, 17729, and
    17769.

    I also took the liberty of reformatting some of the code and comments to
    comply with PEAR Coding Standards. It will still need more work though,
    as this is only a partial fix. Also, all patches must be applied at the
    same time due to some changes in the class names.

    Lastly, I've added support for PHP's newer __construct()/__destruct()
    methods which can now be used in place of module_init()/module_exit().
    The latter methods are still supported for backward-compatibility.

    I *think* that's everything, and I hope this patch works! :)

    ------------------------------------------------------------------------

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
grouppear-bugs @
categoriesphp
postedMar 28, '11 at 10:56a
activeMar 30, '11 at 1:38p
posts4
users2
websitepear.php.net

2 users in discussion

Garrettw87: 2 posts Till: 2 posts

People

Translate

site design / logo © 2022 Grokbase