FAQ
Edit report at http://pear.php.net/bugs/bug.php?id=18251&edit=1

ID: 18251
Updated by: denials@gmail.com
Reported By: christian at rishoj dot net
Summary: A fix for checking the record length
Status: Open
Type: Feature/Change Request
Package: File_MARC
Operating System: Ubuntu
Package Version: 0.6.1
PHP Version: 5.3.5
Roadmap Versions:
New Comment:

The patch looks good on the face of it, but could you add a sample
record (or even better, a unit test with a sample record) that triggers
the current bug?


Previous Comments:
------------------------------------------------------------------------

[2011-02-08 01:49:38] crishoj

Added #patch bug:18251;patch:fix;revision:1297129778;.

------------------------------------------------------------------------

[2011-02-08 01:49:21] crishoj

Description:
------------
In version 0.6.1, the code would rely on the match data from the
regular expression matching, even if it didn't match.

Expected result:
----------------
No warnings.

Actual result:
--------------
Warnings on accessing $matches[1]

------------------------------------------------------------------------

Search Discussions

  • Denials at Feb 8, 2011 at 8:30 pm
    Edit report at http://pear.php.net/bugs/bug.php?id=18251&edit=1

    ID: 18251
    Updated by: denials@gmail.com
    Reported By: christian at rishoj dot net
    Summary: A fix for checking the record length
    -Status: Open
    +Status: Closed
    Type: Feature/Change Request
    Package: File_MARC
    Operating System: Ubuntu
    Package Version: 0.6.1
    PHP Version: 5.3.5
    -Assigned To:
    +Assigned To: dbs
    Roadmap Versions:
    New Comment:

    -Status: Open
    +Status: Closed
    -Assigned To:
    +Assigned To: dbs
    This bug has been fixed in SVN.

    If this was a documentation problem, the fix will appear on pear.php.net
    by the end of next Sunday (CET).

    If this was a problem with the pear.php.net website, the change should
    be live shortly.

    Otherwise, the fix will appear in the package's next release.

    Thank you for the report and for helping us make PEAR better.

    Committed your patch as 308144 and added a further piece to prefer the
    actual length of the data to the length declared in the leader, if they
    don't match. Thanks!


    Previous Comments:
    ------------------------------------------------------------------------

    [2011-02-08 04:00:43] dbs

    The patch looks good on the face of it, but could you add a sample
    record (or even better, a unit test with a sample record) that triggers
    the current bug?

    ------------------------------------------------------------------------

    [2011-02-08 01:49:38] crishoj

    Added #patch bug:18251;patch:fix;revision:1297129778;.

    ------------------------------------------------------------------------

    [2011-02-08 01:49:21] crishoj

    Description:
    ------------
    In version 0.6.1, the code would rely on the match data from the
    regular expression matching, even if it didn't match.

    Expected result:
    ----------------
    No warnings.

    Actual result:
    --------------
    Warnings on accessing $matches[1]

    ------------------------------------------------------------------------
  • Christian at Feb 8, 2011 at 10:30 pm
    Edit report at http://pear.php.net/bugs/bug.php?id=18251&edit=1

    ID: 18251
    Comment by: christian@rishoj.net
    Reported By: christian at rishoj dot net
    Summary: A fix for checking the record length
    Status: Closed
    Type: Feature/Change Request
    Package: File_MARC
    Operating System: Ubuntu
    Package Version: 0.6.1
    PHP Version: 5.3.5
    Assigned To: dbs
    Roadmap Versions:
    New Comment:

    I can attach a sample MARC file which will cause the error upon calling
    next() when the last record has been reached.

    I can't see any way to attach files in this bug tracker, so I am placing
    it here instead:

    https://public.me.com/ix/crishoj/UGE1052S.S00


    Previous Comments:
    ------------------------------------------------------------------------

    [2011-02-08 21:33:18] dbs

    -Status: Open
    +Status: Closed
    -Assigned To:
    +Assigned To: dbs
    This bug has been fixed in SVN.

    If this was a documentation problem, the fix will appear on pear.php.net
    by the end of next Sunday (CET).

    If this was a problem with the pear.php.net website, the change should
    be live shortly.

    Otherwise, the fix will appear in the package's next release.

    Thank you for the report and for helping us make PEAR better.

    Committed your patch as 308144 and added a further piece to prefer the
    actual length of the data to the length declared in the leader, if they
    don't match. Thanks!

    ------------------------------------------------------------------------

    [2011-02-08 04:00:43] dbs

    The patch looks good on the face of it, but could you add a sample
    record (or even better, a unit test with a sample record) that triggers
    the current bug?

    ------------------------------------------------------------------------

    [2011-02-08 01:49:38] crishoj

    Added #patch bug:18251;patch:fix;revision:1297129778;.

    ------------------------------------------------------------------------

    [2011-02-08 01:49:21] crishoj

    Description:
    ------------
    In version 0.6.1, the code would rely on the match data from the
    regular expression matching, even if it didn't match.

    Expected result:
    ----------------
    No warnings.

    Actual result:
    --------------
    Warnings on accessing $matches[1]

    ------------------------------------------------------------------------
  • Denials at Feb 9, 2011 at 4:57 am
    Edit report at http://pear.php.net/bugs/bug.php?id=18251&edit=1

    ID: 18251
    Updated by: denials@gmail.com
    Reported By: christian at rishoj dot net
    Summary: A fix for checking the record length
    Status: Closed
    Type: Feature/Change Request
    Package: File_MARC
    Operating System: Ubuntu
    Package Version: 0.6.1
    PHP Version: 5.3.5
    Assigned To: dbs
    Roadmap Versions:
    New Comment:

    Great -thanks! I have confirmed that the 0.6.2 release resolves this
    problem.


    Previous Comments:
    ------------------------------------------------------------------------

    [2011-02-08 23:32:31] crishoj

    I can attach a sample MARC file which will cause the error upon calling
    next() when the last record has been reached.

    I can't see any way to attach files in this bug tracker, so I am placing
    it here instead:

    https://public.me.com/ix/crishoj/UGE1052S.S00

    ------------------------------------------------------------------------

    [2011-02-08 21:33:18] dbs

    -Status: Open
    +Status: Closed
    -Assigned To:
    +Assigned To: dbs
    This bug has been fixed in SVN.

    If this was a documentation problem, the fix will appear on pear.php.net
    by the end of next Sunday (CET).

    If this was a problem with the pear.php.net website, the change should
    be live shortly.

    Otherwise, the fix will appear in the package's next release.

    Thank you for the report and for helping us make PEAR better.

    Committed your patch as 308144 and added a further piece to prefer the
    actual length of the data to the length declared in the leader, if they
    don't match. Thanks!

    ------------------------------------------------------------------------

    [2011-02-08 04:00:43] dbs

    The patch looks good on the face of it, but could you add a sample
    record (or even better, a unit test with a sample record) that triggers
    the current bug?

    ------------------------------------------------------------------------

    [2011-02-08 01:49:38] crishoj

    Added #patch bug:18251;patch:fix;revision:1297129778;.

    ------------------------------------------------------------------------

    [2011-02-08 01:49:21] crishoj

    Description:
    ------------
    In version 0.6.1, the code would rely on the match data from the
    regular expression matching, even if it didn't match.

    Expected result:
    ----------------
    No warnings.

    Actual result:
    --------------
    Warnings on accessing $matches[1]

    ------------------------------------------------------------------------
  • Denials at Feb 9, 2011 at 4:58 am
    Edit report at http://pear.php.net/bugs/bug.php?id=18251&edit=1

    ID: 18251
    Updated by: denials@gmail.com
    Reported By: christian at rishoj dot net
    Summary: A fix for checking the record length
    Status: Closed
    Type: Feature/Change Request
    Package: File_MARC
    Operating System: Ubuntu
    Package Version: 0.6.1
    PHP Version: 5.3.5
    Assigned To: dbs
    Roadmap Versions:
    New Comment:

    Thank you for your bug report. This issue has been fixed
    in the latest released version of the package, which you can download at
    http://pear.php.net/get/

    Release 0.6.2 earlier today to address this problem and several other
    similar ones.


    Previous Comments:
    ------------------------------------------------------------------------

    [2011-02-09 06:00:12] dbs

    Great -thanks! I have confirmed that the 0.6.2 release resolves this
    problem.

    ------------------------------------------------------------------------

    [2011-02-08 23:32:31] crishoj

    I can attach a sample MARC file which will cause the error upon calling
    next() when the last record has been reached.

    I can't see any way to attach files in this bug tracker, so I am placing
    it here instead:

    https://public.me.com/ix/crishoj/UGE1052S.S00

    ------------------------------------------------------------------------

    [2011-02-08 21:33:18] dbs

    -Status: Open
    +Status: Closed
    -Assigned To:
    +Assigned To: dbs
    This bug has been fixed in SVN.

    If this was a documentation problem, the fix will appear on pear.php.net
    by the end of next Sunday (CET).

    If this was a problem with the pear.php.net website, the change should
    be live shortly.

    Otherwise, the fix will appear in the package's next release.

    Thank you for the report and for helping us make PEAR better.

    Committed your patch as 308144 and added a further piece to prefer the
    actual length of the data to the length declared in the leader, if they
    don't match. Thanks!

    ------------------------------------------------------------------------

    [2011-02-08 04:00:43] dbs

    The patch looks good on the face of it, but could you add a sample
    record (or even better, a unit test with a sample record) that triggers
    the current bug?

    ------------------------------------------------------------------------

    [2011-02-08 01:49:38] crishoj

    Added #patch bug:18251;patch:fix;revision:1297129778;.

    ------------------------------------------------------------------------

    The remainder of the comments for this report are too long. To view
    the rest of the comments, please view the bug report online at
    http://pear.php.net/bugs/bug.php?id=18251

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
grouppear-bugs @
categoriesphp
postedFeb 8, '11 at 2:58a
activeFeb 9, '11 at 4:58a
posts5
users2
websitepear.php.net

2 users in discussion

Denials: 4 posts Christian: 1 post

People

Translate

site design / logo © 2022 Grokbase