FAQ
Edit report at http://pear.php.net/bugs/bug.php?id=17910&edit=1

ID: 17910
Updated by: kousuke@co3k.org
Reported By: kousuke at co3k dot org
Summary: VersionControl_Git_Util_Command::createCommandString()
must be public
-Status: Open
+Status: Closed
Type: Bug
Package: VersionControl_Git
Package Version: 0.4.2
PHP Version: 5.3.3
-Assigned To:
+Assigned To: ebihara
Roadmap Versions:
New Comment:

-Status: Open
+Status: Closed
-Assigned To:
+Assigned To: ebihara
This bug has been fixed in Git repository.

http://github.com/ebihara/VersionControl_Git/commit/8df728b448ca11c84845855713e8abec77f4c1cf


Previous Comments:
------------------------------------------------------------------------

[2010-09-29 16:42:16] ebihara

Description:
------------
VersionControl_Git_Util_Command::createCommandString() must be public.

I've written this method as protected because this is used by only
VersionControl_Git_Util_Command::execute() now. But my judgment was not
good.

Because,

* This class' role is similar to objective of "utility class". So I
should make an effort to make many methods public.
* Arguments and prerequisites for running (::$subCommand must be
specified) of ::createCommandString() are equal to ::execute()'s one. It
is able to be called individually. There is nothing to do for calling
this method from ::execute().
* ::createCommandString() doesn't change any properties.

------------------------------------------------------------------------

Search Discussions

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
grouppear-bugs @
categoriesphp
postedSep 29, '10 at 4:49p
activeSep 29, '10 at 4:49p
posts1
users1
websitepear.php.net

1 user in discussion

Kousuke: 1 post

People

Translate

site design / logo © 2022 Grokbase