Edit report at http://pear.php.net/bugs/bug.php?id=17467&edit=1
ID: 17467
Updated by: [email protected]
Reported By: public at svenpoeche dot de
Summary: Do not ouput report, if argument report-file is given
-Status: Assigned
+Status: Closed
Type: Feature/Change Request
Package: PHP_CodeSniffer
Package Version: 1.2.2
PHP Version: Irrelevant
Assigned To: squiz
Roadmap Versions:
New Comment:
-Status: Assigned
+Status: Closed
I decided to do this in a different way as I didn't want another command
line argument for something that may be rarely used.
So what I did is change the default behaviour to NOT print the report to
screen. If you specify the -v command line argument, the report will be
printed to screen as well.
Sven, I think you are right that users would expect it to not print to
screen, but if you use -v, you are expecting more output to come to the
screen, so it's probably not a massive surprise that it gets printed.
And when used in CI environments, adding -v to the end actually gives
you some additional useful output about registered sniffs and is easy to
do.
Previous Comments:
------------------------------------------------------------------------
[2010-07-26 16:11:20] benmatselby
Updated as -m (mute) so we can use -d for #17244..
------------------------------------------------------------------------
[2010-07-26 16:09:53] benmatselby
Added #patch bug:17467;patch:mute-report-file;revision:1280160593;.
------------------------------------------------------------------------
[2010-07-23 18:35:48] benmatselby
After thinking about this I think the option should be called -m for
mute rather than -d as that seems like obvious choice if you wanted an
option to override php settings such as memory_limit.
If you think you can use this patch and would rather use -m let me know
and I will update
------------------------------------------------------------------------
[2010-07-20 21:24:47] benmatselby
Greg,
I've added a -d flag that turns off the output if you use it with
--report-file..
I've also now started to create some phpt tests to cover off the UI
aspect of the application - hope you can use these and agree with the
structure. If not let me know as I am happy to change if need be, but
they help out with these kinds of unit tests.
------------------------------------------------------------------------
[2010-07-20 21:22:45] benmatselby
Added #patch
bug:17467;patch:discrete-option-with-report-file;revision:1279660965;.
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
http://pear.php.net/bugs/bug.php?id=17467
