[PEAR-BUG] Req #17467 [Com]: Do not ouput report, if argument report-file is given

Edit report at http://pear.php.net/bugs/bug.php?id=17467&edit=1

ID: 17467
Comment by: benmatselby@gmail.com
Reported By: public at svenpoeche dot de
Summary: Do not ouput report, if argument report-file is given
Status: Assigned
Type: Feature/Change Request
Package: PHP_CodeSniffer
Package Version: 1.2.2
PHP Version: Irrelevant
Assigned To: squiz
Roadmap Versions:
New Comment:

After thinking about this I think the option should be called -m for
mute rather than -d as that seems like obvious choice if you wanted an
option to override php settings such as memory_limit.

If you think you can use this patch and would rather use -m let me know
and I will update


Previous Comments:
------------------------------------------------------------------------

[2010-07-20 21:24:47] benmatselby

Greg,

I've added a -d flag that turns off the output if you use it with
--report-file..

I've also now started to create some phpt tests to cover off the UI
aspect of the application - hope you can use these and agree with the
structure. If not let me know as I am happy to change if need be, but
they help out with these kinds of unit tests.

------------------------------------------------------------------------

[2010-07-20 21:22:45] benmatselby

Added #patch
bug:17467;patch:discrete-option-with-report-file;revision:1279660965;.

------------------------------------------------------------------------

[2010-06-05 00:09:21] squiz

-Assigned To:
+Assigned To: squiz
This is by design and useful in some continuous integration environments
so you can
see errors and notices raised by PHP_CodeSniffer.

I'll leave it as a feature if I ever decide to make a command line
switch for it.

------------------------------------------------------------------------

[2010-06-04 18:37:01] valgard

Description:
------------
CodeSniffer should not ouput the report, if the command line argument
report-file is given.

Change line 99 of Reporting.php from

ob_end_flush();

to

ob_end_clean();

------------------------------------------------------------------------

Edit report at http://pear.php.net/bugs/bug.php?id=17467&edit=1

ID: 17467
Comment by: benmatselby@gmail.com
Reported By: public at svenpoeche dot de
Summary: Do not ouput report, if argument report-file is given
Status: Assigned
Type: Feature/Change Request
Package: PHP_CodeSniffer
Package Version: 1.2.2
PHP Version: Irrelevant
Assigned To: squiz
Roadmap Versions:
New Comment:

Updated as -m (mute) so we can use -d for #17244..


Previous Comments:
------------------------------------------------------------------------

[2010-07-26 16:09:53] benmatselby

Added #patch bug:17467;patch:mute-report-file;revision:1280160593;.

------------------------------------------------------------------------

[2010-07-23 18:35:48] benmatselby

After thinking about this I think the option should be called -m for
mute rather than -d as that seems like obvious choice if you wanted an
option to override php settings such as memory_limit.

If you think you can use this patch and would rather use -m let me know
and I will update

------------------------------------------------------------------------

[2010-07-20 21:24:47] benmatselby

Greg,

I've added a -d flag that turns off the output if you use it with
--report-file..

I've also now started to create some phpt tests to cover off the UI
aspect of the application - hope you can use these and agree with the
structure. If not let me know as I am happy to change if need be, but
they help out with these kinds of unit tests.

------------------------------------------------------------------------

[2010-07-20 21:22:45] benmatselby

Added #patch
bug:17467;patch:discrete-option-with-report-file;revision:1279660965;.

------------------------------------------------------------------------

[2010-06-05 00:09:21] squiz

-Assigned To:
+Assigned To: squiz
This is by design and useful in some continuous integration environments
so you can
see errors and notices raised by PHP_CodeSniffer.

I'll leave it as a feature if I ever decide to make a command line
switch for it.

------------------------------------------------------------------------

The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
http://pear.php.net/bugs/bug.php?id=17467