[PEAR-BUG] Req #16730 [Opn]: Spin off Log related code in System_Daemon

Edit report at http://pear.php.net/bugs/bug.php?id=16730&edit=1

ID: 16730
Updated by: [email protected]
Reported By: till at php dot net
Summary: Spin off Log related code in System_Daemon
-Status: Open
+Status: Feedback
Type: Feature/Change Request
Package: System_Daemon
Operating System: n/a
Package Version: 0.9.2
PHP Version: 5.2.5
Roadmap Versions:
New Comment:

-Status: Open
+Status: Feedback



Previous Comments:
------------------------------------------------------------------------

[2009-10-23 14:12:24] kvz

Agreed.

I've actually been thinking of doing a complete rewrite of
System_Daemon, I've learned a trick or two since I made this code.
Aim is to keep the API the same, but revamp all other code. My guess is
it can be done in 30% of the lines.

Now to find me some time... ; )

------------------------------------------------------------------------

[2009-10-23 13:53:11] till

Description:
------------
IMHO, the System_Daemon::log() function and all related methods and
constants, should be pushed into a System_Daemon_Log class.

Of course there's nothing particulary "wrong" with this code, but I
feel like the System_Daemon class itself is too monolithic. It does too
many things at the same time, in order to work with that, I'd suggest
you spin off the log code into System_Daemon_Log. :-)

------------------------------------------------------------------------

Edit report at http://pear.php.net/bugs/bug.php?id=16730&edit=1

ID: 16730
Updated by: [email protected]
Reported By: till at php dot net
Summary: Spin off Log related code in System_Daemon
Status: Feedback
Type: Feature/Change Request
Package: System_Daemon
Operating System: n/a
Package Version: 0.9.2
PHP Version: 5.2.5
Roadmap Versions:
New Comment:

Heh, I wasn't calling for so drastic measures. ;-)

I mean, since you are pre-1.0, you can technically break the API as
well.


Previous Comments:
------------------------------------------------------------------------

[2009-10-23 14:12:38] kvz

-Status: Open
+Status: Feedback


------------------------------------------------------------------------

[2009-10-23 14:12:24] kvz

Agreed.

I've actually been thinking of doing a complete rewrite of
System_Daemon, I've learned a trick or two since I made this code.
Aim is to keep the API the same, but revamp all other code. My guess is
it can be done in 30% of the lines.

Now to find me some time... ; )

------------------------------------------------------------------------

[2009-10-23 13:53:11] till

Description:
------------
IMHO, the System_Daemon::log() function and all related methods and
constants, should be pushed into a System_Daemon_Log class.

Of course there's nothing particulary "wrong" with this code, but I
feel like the System_Daemon class itself is too monolithic. It does too
many things at the same time, in order to work with that, I'd suggest
you spin off the log code into System_Daemon_Log. :-)

------------------------------------------------------------------------

Edit report at http://pear.php.net/bugs/bug.php?id=16730&edit=1

ID: 16730
Updated by: [email protected]
Reported By: till at php dot net
Summary: Spin off Log related code in System_Daemon
Status: Feedback
Type: Feature/Change Request
Package: System_Daemon
Operating System: n/a
Package Version: 0.9.2
PHP Version: 5.2.5
Roadmap Versions:
New Comment:

yeah i know, but i don't think (hope) i need to : )


Previous Comments:
------------------------------------------------------------------------

[2009-10-23 14:37:02] till

Heh, I wasn't calling for so drastic measures. ;-)

I mean, since you are pre-1.0, you can technically break the API as
well.

------------------------------------------------------------------------

[2009-10-23 14:12:38] kvz

-Status: Open
+Status: Feedback


------------------------------------------------------------------------

[2009-10-23 14:12:24] kvz

Agreed.

I've actually been thinking of doing a complete rewrite of
System_Daemon, I've learned a trick or two since I made this code.
Aim is to keep the API the same, but revamp all other code. My guess is
it can be done in 30% of the lines.

Now to find me some time... ; )

------------------------------------------------------------------------

[2009-10-23 13:53:11] till

Description:
------------
IMHO, the System_Daemon::log() function and all related methods and
constants, should be pushed into a System_Daemon_Log class.

Of course there's nothing particulary "wrong" with this code, but I
feel like the System_Daemon class itself is too monolithic. It does too
many things at the same time, in order to work with that, I'd suggest
you spin off the log code into System_Daemon_Log. :-)

------------------------------------------------------------------------