FAQ
Edit report at http://pear.php.net/bugs/bug.php?id=16510&edit=1

ID: 16510
Updated by: demrit@php.net
Reported By: demrit at mx dot gnu dot org
Summary: HTML_Safe for PHP 5.3 strict
-Status: Assigned
+Status: Closed
Type: Feature/Change Request
Package: HTML_Safe
Operating System: Any
-Package Version: CVS
+Package Version: SVN
PHP Version: 5.3.0
Assigned To: demrit
Roadmap Versions:
New Comment:

-Status: Assigned
+Status: Closed
-Package Version: CVS
+Package Version: SVN
This bug has been fixed in SVN.

If this was a documentation problem, the fix will appear on
pear.php.net by the end of next Sunday (CET).

If this was a problem with the pear.php.net website, the change should
be live shortly.

Otherwise, the fix will appear in the package's next release.

Thank you for the report and for helping us make PEAR better.

Patch has been added.


Previous Comments:
------------------------------------------------------------------------

[2009-08-24 08:37:42] demrit

-Assigned To:
+Assigned To: demrit


------------------------------------------------------------------------

[2009-08-11 09:18:16] demrit

The following patch has been added/updated:

Patch Name: 53support
Revision: 1249978696
URL:
http://pear.php.net/bugs/patch-display.php?bug=16510&patch=53support&revision=1249978696&display=1

------------------------------------------------------------------------

[2009-08-11 09:17:11] demrit

1) Avoid the use of private (protected is your friend) - it's harder to
extend, test, etc.

Agree and changed. Everything private has been moved to protected.

2) Since things now have scope, we can lose the _ prefixes Ie, var

done

3) Some of the things used to be public, ie:

hmm, i think it must be access by get/set methods, but for now it is
ok. Everything handle has been changed from private to public because
third party package requires (HTMLSax3).

4) Oh dear, no one has put this in SVN.

Ah, well I have a patch again for the source that you provides.

5) I don't suppose there's any chance of unit test coverage *before*
you refactor, to catch any mistakes?

I will do it with my new code for stable version before. First it and
use the current unit.

------------------------------------------------------------------------

[2009-08-11 03:00:15] doconnor

[287069] adds a stub of the allow tags method - test coverage too, but
no actual implementation.

------------------------------------------------------------------------

[2009-08-11 02:39:41] doconnor

Alrighty Miguel, I've added a copy of the last release to SVN.

svn checkout
http://svn.php.net/repository/pear/packages/HTML_Safe/trunk

should work

------------------------------------------------------------------------

The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
http://pear.php.net/bugs/bug.php?id=16510

Search Discussions

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
grouppear-bugs @
categoriesphp
postedOct 22, '09 at 10:55p
activeOct 22, '09 at 10:55p
posts1
users1
websitepear.php.net

1 user in discussion

Demrit: 1 post

People

Translate

site design / logo © 2022 Grokbase