FAQ
Edit report at http://pear.php.net/bugs/bug.php?id=16563&edit=1

ID: 16563
Updated by: gsherwood@squiz.net
Reported By: et3w503 at yahoo dot com
Summary: Check file extensions problem in phpcs-svn-pre-commit
-Status: Open
+Status: Closed
Type: Bug
Package: PHP_CodeSniffer
Operating System: linux
Package Version: 1.2.0
PHP Version: 5.1.6
-Assigned To:
+Assigned To: squiz
Roadmap Versions:
New Comment:

-Status: Open
+Status: Closed
-Assigned To:
+Assigned To: squiz
This bug has been fixed in CVS.

If this was a documentation problem, the fix will appear on
pear.php.net by the end of next Sunday (CET).

If this was a problem with the pear.php.net website, the change should
be live shortly.

Otherwise, the fix will appear in the package's next release.

Thank you for the report and for helping us make PEAR better.

I can't replicate a file path with spaces, but the change doesn't break
anything so I made it anyway. Thanks for the patch.


Previous Comments:
------------------------------------------------------------------------

[2009-09-02 12:31:51] et3w503

Description:
------------
phpcs-svn-pre-commit
http://svn.php.net/viewvc/pear/packages/PHP_CodeSniffer/trunk/scripts/phpcs-svn-pre-commit?revision=287629&view=markup
line 144
$extension = array_pop($fileParts);

If there are spaces in $extension, script will skip the processFile
step.

For example, extension could be "php ".

It's better , if script could trim $extension.

$extension = trim(array_pop($fileParts));

------------------------------------------------------------------------

Search Discussions

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
grouppear-bugs @
categoriesphp
postedSep 8, '09 at 2:03a
activeSep 8, '09 at 2:03a
posts1
users1
websitepear.php.net

1 user in discussion

Gsherwood: 1 post

People

Translate

site design / logo © 2022 Grokbase