[PEAR-BUG] Bug #16423 [Opn]: Path to php binary should not be hardcoded

Edit report at http://pear.php.net/bugs/bug.php?id=16423&edit=1

ID: 16423
Updated by: [email protected]
Reported By: p at rdus dot de
Summary: Path to php binary should not be hardcoded
Status: Assigned
Type: Bug
Package: Date_Holidays
Operating System: Linux
Package Version: 0.21.2
PHP Version: 5.2.5
Assigned To: kguest
Roadmap Versions:
New Comment:

Instead of hard-coding php_bin, use "/usr/bin/env php"


Previous Comments:
------------------------------------------------------------------------

[2009-07-10 14:47:14] kguest

-Assigned To:
+Assigned To: kguest


------------------------------------------------------------------------

[2009-07-10 09:14:32] wrobel

The following patch has been added/updated:

Patch Name: script_parser_path
Revision: 1247213672
URL:
http://pear.php.net/bugs/patch-display.php?bug=16423&patch=script_parser_path&revision=1247213672&display=1

------------------------------------------------------------------------

[2009-07-10 09:13:47] wrobel

Description:
------------
Currently the two scripts offered by PEAR-Date_Holidays start with
"#!/usr/bin/php". This needs to be fixed on platforms where this is not
the patch to the php binary.

Suggested patch attached.

------------------------------------------------------------------------

Edit report at http://pear.php.net/bugs/bug.php?id=16423&edit=1

ID: 16423
Updated by: [email protected]
Reported By: p at rdus dot de
Summary: Path to php binary should not be hardcoded
Status: Assigned
Type: Bug
Package: Date_Holidays
Operating System: Linux
Package Version: 0.21.2
PHP Version: 5.2.5
Assigned To: kguest
Roadmap Versions:
New Comment:

@Christian: I don't see how that would work for Windows or some
platform where /usr/bin/env does not exist. @php_bin@ is not hard coded
but a variable that is being replaced by the path to php as configured
within PEAR.


Previous Comments:
------------------------------------------------------------------------

[2009-07-27 16:43:13] cweiske

Instead of hard-coding php_bin, use "/usr/bin/env php"

------------------------------------------------------------------------

[2009-07-10 14:47:14] kguest

-Assigned To:
+Assigned To: kguest


------------------------------------------------------------------------

[2009-07-10 09:14:32] wrobel

The following patch has been added/updated:

Patch Name: script_parser_path
Revision: 1247213672
URL:
http://pear.php.net/bugs/patch-display.php?bug=16423&patch=script_parser_path&revision=1247213672&display=1

------------------------------------------------------------------------

[2009-07-10 09:13:47] wrobel

Description:
------------
Currently the two scripts offered by PEAR-Date_Holidays start with
"#!/usr/bin/php". This needs to be fixed on platforms where this is not
the patch to the php binary.

Suggested patch attached.

------------------------------------------------------------------------