FAQ
Patch 8715 complains

1 out of 1 hunk FAILED -- saving rejects to perl.c.rej

and leaves this reject behind:

***************
*** 698,705 ****
}
SvREFCNT_dec(PL_strtab);

/* free the pointer table used for cloning */
ptr_table_free(PL_ptr_table);

/* free special SVs */

--- 698,707 ----
}
SvREFCNT_dec(PL_strtab);

+ #ifdef USE_THREADS
/* free the pointer table used for cloning */
ptr_table_free(PL_ptr_table);
+ #endif

/* free special SVs */


perl.c.orig looks like this:

695 hent = array[riter];
696 }
697 }
698 }
699 SvREFCNT_dec(PL_strtab);
700
701 /* free special SVs */
702
703 SvREFCNT(&PL_sv_yes) = 0;
704 sv_clear(&PL_sv_yes);
705 SvANY(&PL_sv_yes) = NULL;
706 SvFLAGS(&PL_sv_yes) = 0;
707

So there seems to be a previous patch missing.

--
andreas

Search Discussions

  • Nick Ing-Simmons at Feb 9, 2001 at 12:14 pm

    Andreas J . Koenig writes:
    Patch 8715 complains

    1 out of 1 hunk FAILED -- saving rejects to perl.c.rej

    and leaves this reject behind:

    So there seems to be a previous patch missing. I said:
    <nick@ing-simmons.net> writes:
    Doug Maceachern <dougm@covalent.net> writes:
    It might be useful to split that into ptr_table_clear() and
    ptr_table_free().
    ok, patch below should take care of both...
    In as Change 8713 - but note it needs 8715/8716 as well on non-ithreaded perl.
    That is the original change was 8713
    and 8715/8716 and then 8721 were needed to make it work
    (not one of my best efforts).

    For some reason 8713 has not shown up in

    http://public.activestate.com/gsar/APC/5.7.1/diffs/


    --
    Nick Ing-Simmons <nik@tiuk.ti.com>
    Via, but not speaking for: Texas Instruments Ltd.
  • Gurusamy Sarathy at Feb 9, 2001 at 3:52 pm

    On Fri, 09 Feb 2001 12:14:18 GMT, Nick Ing-Simmons wrote:
    Andreas J . Koenig <andreas.koenig@anima.de> writes:
    Patch 8715 complains

    1 out of 1 hunk FAILED -- saving rejects to perl.c.rej

    and leaves this reject behind:

    So there seems to be a previous patch missing. I said:
    <nick@ing-simmons.net> writes:
    Doug Maceachern <dougm@covalent.net> writes:
    It might be useful to split that into ptr_table_clear() and
    ptr_table_free().
    ok, patch below should take care of both...
    In as Change 8713 - but note it needs 8715/8716 as well on non-ithreaded perl
    .

    That is the original change was 8713
    and 8715/8716 and then 8721 were needed to make it work
    (not one of my best efforts).

    For some reason 8713 has not shown up in

    http://public.activestate.com/gsar/APC/5.7.1/diffs/
    It's because the APC syncer ass_u_mes that all changes will be
    checked in sequentially in change number order. It isn't smart
    enough to go back and fetch 8713 after it has fetched 8714 already,
    and in this case 8714 might have been checked in before 8713 (perhaps
    8713 was scheduled first, but checked it in after 8714). 8688 was
    missing due to the same problem.

    I've manually added the diffs (for the time being).


    Sarathy
    gsar@ActiveState.com

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupperl5-porters @
categoriesperl
postedFeb 9, '01 at 11:10a
activeFeb 9, '01 at 3:52p
posts3
users3
websiteperl.org

People

Translate

site design / logo © 2022 Grokbase