Grokbase › Groups › Perl › cpan-workers › October 2008
FAQ
Hi,

so after splitting CPAN::Shell I created a branch and in that branch a
moved all the code of the other packages to the respective files.
Every module was moved in a separate commit and before the commit
(sorry David I got your e-mail only when I was already in the middle)
I made any changes that were required for the separation.

I tried to make sure everything works every time by running the test suit but
I still found a couple issues I had to deal with in later commits.
Most notably in several cases the tests passed on 5.8.8 on Ubuntu and
failed on Portable Strawberry beta 1. I fixed those.

Unfortunately I mistakenly changed the file format from UNIX to DOS in
two cases.
Once I noticed the mistake I reverted the changes using inverse merge and then
applied the small change of adding use Carp. I hope this will not render my
work unusable for you.

So right now (r3499) all test pass on both platforms I checked.
I am also going to try to use the new version by typing:

perl -Ilib -MCPAN -eshell

so far one module installed well (at least according to CPAN.pm)
but one had really strange warnings. I am sending it in a separate
e-mail. I am not sure at all if the problem is CPAN.pm related.

Anyway, I think I am going to stop my big changes now and I'd
like to understand what need to be done to check if it works
and when can it be merged to trunk if at all.

I think I'll continue to the next set of changes once I know these
changes can be merged back to trunk. Then I guess I'll create
another branch to work on.

Gabor

Search Discussions

  • Gabor Szabo at Nov 11, 2008 at 6:08 am ⇧
    I know this is not the most urgent thing in the project but I'd appreciate some
    kind of a comment.

    Gabor
    On Fri, Oct 24, 2008 at 3:05 PM, Gabor Szabo wrote:
    Hi,

    so after splitting CPAN::Shell I created a branch and in that branch a
    moved all the code of the other packages to the respective files.
    Every module was moved in a separate commit and before the commit
    (sorry David I got your e-mail only when I was already in the middle)
    I made any changes that were required for the separation.

    I tried to make sure everything works every time by running the test suit but
    I still found a couple issues I had to deal with in later commits.
    Most notably in several cases the tests passed on 5.8.8 on Ubuntu and
    failed on Portable Strawberry beta 1. I fixed those.

    Unfortunately I mistakenly changed the file format from UNIX to DOS in
    two cases.
    Once I noticed the mistake I reverted the changes using inverse merge and then
    applied the small change of adding use Carp. I hope this will not render my
    work unusable for you.

    So right now (r3499) all test pass on both platforms I checked.
    I am also going to try to use the new version by typing:

    perl -Ilib -MCPAN -eshell

    so far one module installed well (at least according to CPAN.pm)
    but one had really strange warnings. I am sending it in a separate
    e-mail. I am not sure at all if the problem is CPAN.pm related.

    Anyway, I think I am going to stop my big changes now and I'd
    like to understand what need to be done to check if it works
    and when can it be merged to trunk if at all.

    I think I'll continue to the next set of changes once I know these
    changes can be merged back to trunk. Then I guess I'll create
    another branch to work on.

    Gabor
  • Andreas J. Koenig at Nov 11, 2008 at 7:09 am ⇧

    On Tue, 11 Nov 2008 08:08:39 +0200, "Gabor Szabo" <szabgab@gmail.com> said:
    I know this is not the most urgent thing in the project but I'd appreciate some
    kind of a comment.
    I apologize. I thought my git-fu would probably allow me to repair the
    major breakage you describe yourself in an easy manner but it did not
    happen.
    Unfortunately I mistakenly changed the file format from UNIX to DOS in
    two cases.
    Once I noticed the mistake I reverted the changes using inverse merge and then
    applied the small change of adding use Carp. I hope this will not render my
    work unusable for you.
    This is indeed the sort of things I was talking about when I said that
    SVN is unusable. You really should have used a frontend like git that
    allows to to amend mistakes before committing a branch. Somebody must
    now amend these mistakes manually. Or you could probably redo the
    whole branch into another branch that makes it easier to review?


    --
    andreas
  • David Golden at Nov 11, 2008 at 3:54 pm ⇧

    On Tue, Nov 11, 2008 at 2:09 AM, Andreas J. Koenig wrote:
    On Tue, 11 Nov 2008 08:08:39 +0200, "Gabor Szabo" <szabgab@gmail.com> said:
    I know this is not the most urgent thing in the project but I'd appreciate some
    kind of a comment.
    I apologize. I thought my git-fu would probably allow me to repair the
    major breakage you describe yourself in an easy manner but it did not
    happen.
    Gabor -- Sorry. I've been a little distracted with the new kid. Hard
    to focus on programming for more than a couple minutes at a time.
    I'll see if I can carve out some time this week -- I'd like to see
    this happen as it will help other refactoring.

    Andreas -- I'm 100% supportive of migrating to git. I've done so with
    all my old googlecode subversion projects and love it. I think I
    followed Sam Vilain's "import your SVK mirrors" approach described
    here:

    http://utsl.gen.nz/talks/git-svn/intro.html#howto-fetch-convert

    Also, github.com seems to be a pretty good host and has some nice eye
    candy statistics. I've started using them as an additional public
    mirror of some of my code. For example:

    http://github.com/dagolden/cpan-reporter/tree/master

    (I keep meaning to set up a cron job to push from my
    echo.dagolden.com/git/ repo to github so it's still a little out of
    date, I think.)

    -- David
  • Andreas J. Koenig at Dec 21, 2008 at 12:44 pm ⇧

    On Tue, 11 Nov 2008 08:08:39 +0200, "Gabor Szabo" <szabgab@gmail.com> said:
    I know this is not the most urgent thing in the project but I'd appreciate some
    kind of a comment.
    Finally, the merge is done. Thanks, Gabor.

    git://github.com/andk/cpanpm.git

    All tests pass, and I've been using the code for several days
    successfully. I could probably have made the merge a bit smarter but
    "perfection is not of this world"[1]

    Thanks again, Enjoy,
    --
    andreas
    [1] rgs in <b77c1dce0812210014y6ca051ael231d4e51b7c33f34@mail.gmail.com>
  • Gabor Szabo at Dec 21, 2008 at 12:48 pm ⇧
    Oh thanks!

    Gabor

    On Sun, Dec 21, 2008 at 2:44 PM, Andreas J. Koenig
    wrote:
    On Tue, 11 Nov 2008 08:08:39 +0200, "Gabor Szabo" <szabgab@gmail.com> said:
    I know this is not the most urgent thing in the project but I'd appreciate some
    kind of a comment.
    Finally, the merge is done. Thanks, Gabor.

    git://github.com/andk/cpanpm.git

    All tests pass, and I've been using the code for several days
    successfully. I could probably have made the merge a bit smarter but
    "perfection is not of this world"[1]

    Thanks again, Enjoy,
    --
    andreas
    [1] rgs in <b77c1dce0812210014y6ca051ael231d4e51b7c33f34@mail.gmail.com>
  • Brian d foy at Dec 23, 2008 at 3:08 am ⇧
    In article (Andreas J. Koenig)
    wrote:
    On Tue, 11 Nov 2008 08:08:39 +0200, "Gabor Szabo" <szabgab@gmail.com>
    said:
    I know this is not the most urgent thing in the project but I'd
    appreciate some
    kind of a comment.
    Finally, the merge is done. Thanks, Gabor.

    git://github.com/andk/cpanpm.git
    Fantastic.

    When I have a new cpan version, I'll send someone a pull request.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupcpan-workers @
categoriesperl
postedOct 24, '08 at 1:05p
activeDec 23, '08 at 3:08a
posts7
users4
websitecpan.org

4 users in discussion

Gabor Szabo: 3 posts Andreas J. Koenig: 2 posts Brian d foy: 1 post David Golden: 1 post

Content

People

Support

Translate

site design / logo © 2021 Grokbase