Grokbase › Groups › Maven › dev › November 2005
FAQ

-----Original Message-----
From: jdcasey@apache.org
Sent: mardi 1 novembre 2005 16:56
To: commits@maven.apache.org
Subject: svn commit: r330080 - in /maven/components/trunk: maven-
artifact/src/main/java/org/apache/maven/artifact/factory/ maven-
artifact/src/main/java/org/apache/maven/artifact/versioning/ maven-
project/src/main/java/org/apache/maven/project/

Author: jdcasey
Date: Tue Nov 1 07:55:45 2005
New Revision: 330080

URL: http://svn.apache.org/viewcvs?rev=330080&view=rev
Log:
PR: MNG-1335

Added ArtifactFactory.cloneArtifact(..) +implementation, and made
MavenProject(MavenProject) use that to create a copy of the project's
artifact.
Very cool! Thanks John. I've just rebuilt m2 from scratch and I've tried the
clover samples in components/trunk/examples ... and it worked!

This means I'm now ready to release the clover plugin (after I write some
docs for it). However, it also means Maven 2.0 users will not be able to run
it as it will require Maven 2.0.1...

Thanks
-Vincent


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

Search Discussions

  • John Casey at Nov 1, 2005 at 7:10 pm ⇧
    The real problem is that the clover plugin depends on resolution of a
    bug in the 2.0 release...there's not a way around that, unless you want
    to get an instance of the ArtifactFactory inside the clover mojo and
    clone the project artifact by force. Otherwise, we'll have to make the
    clover plugin depend on some sort of beyond-2.0 version of maven-project
    (and maybe maven-artifact, depending on how we approach it).

    I can roll back the changes I made to maven-artifact, and do a more
    hackish solution inside MavenProject for the time being. This would keep
    that copy of MavenProject compatible with 2.0, but it still means
    releasing a 2.0-1 or something for maven-project. I'm not opposed to
    this, but I'm not sure whether this fix warrants it or not.

    What do you all think?

    - -john

    Vincent Massol wrote:
    -----Original Message-----
    From: jdcasey@apache.org
    Sent: mardi 1 novembre 2005 16:56
    To: commits@maven.apache.org
    Subject: svn commit: r330080 - in /maven/components/trunk: maven-
    artifact/src/main/java/org/apache/maven/artifact/factory/ maven-
    artifact/src/main/java/org/apache/maven/artifact/versioning/ maven-
    project/src/main/java/org/apache/maven/project/

    Author: jdcasey
    Date: Tue Nov 1 07:55:45 2005
    New Revision: 330080

    URL: http://svn.apache.org/viewcvs?rev=330080&view=rev
    Log:
    PR: MNG-1335

    Added ArtifactFactory.cloneArtifact(..) +implementation, and made
    MavenProject(MavenProject) use that to create a copy of the project's
    artifact.

    Very cool! Thanks John. I've just rebuilt m2 from scratch and I've tried the
    clover samples in components/trunk/examples ... and it worked!

    This means I'm now ready to release the clover plugin (after I write some
    docs for it). However, it also means Maven 2.0 users will not be able to run
    it as it will require Maven 2.0.1...

    Thanks
    -Vincent


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
    For additional commands, e-mail: dev-help@maven.apache.org


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
    For additional commands, e-mail: dev-help@maven.apache.org
  • John Casey at Nov 1, 2005 at 7:16 pm ⇧
    Another thing to think about: unless we're talking about releasing 2.0-1
    for all of the Maven application, upgrading maven-project in
    ${maven.home}/lib will be a problem. These projects really don't stand
    on their own, and we don't have an upgrader/auto-update feature to the
    maven CLI yet.

    - -j

    John Casey wrote:
    The real problem is that the clover plugin depends on resolution of a
    bug in the 2.0 release...there's not a way around that, unless you want
    to get an instance of the ArtifactFactory inside the clover mojo and
    clone the project artifact by force. Otherwise, we'll have to make the
    clover plugin depend on some sort of beyond-2.0 version of maven-project
    (and maybe maven-artifact, depending on how we approach it).

    I can roll back the changes I made to maven-artifact, and do a more
    hackish solution inside MavenProject for the time being. This would keep
    that copy of MavenProject compatible with 2.0, but it still means
    releasing a 2.0-1 or something for maven-project. I'm not opposed to
    this, but I'm not sure whether this fix warrants it or not.

    What do you all think?

    -john

    Vincent Massol wrote:
    -----Original Message-----
    From: jdcasey@apache.org
    Sent: mardi 1 novembre 2005 16:56
    To: commits@maven.apache.org
    Subject: svn commit: r330080 - in /maven/components/trunk: maven-
    artifact/src/main/java/org/apache/maven/artifact/factory/ maven-
    artifact/src/main/java/org/apache/maven/artifact/versioning/ maven-
    project/src/main/java/org/apache/maven/project/

    Author: jdcasey
    Date: Tue Nov 1 07:55:45 2005
    New Revision: 330080

    URL: http://svn.apache.org/viewcvs?rev=330080&view=rev
    Log:
    PR: MNG-1335

    Added ArtifactFactory.cloneArtifact(..) +implementation, and made
    MavenProject(MavenProject) use that to create a copy of the project's
    artifact.

    Very cool! Thanks John. I've just rebuilt m2 from scratch and I've tried the
    clover samples in components/trunk/examples ... and it worked!

    This means I'm now ready to release the clover plugin (after I write
    some
    docs for it). However, it also means Maven 2.0 users will not be able to run
    it as it will require Maven 2.0.1...

    Thanks
    -Vincent


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
    For additional commands, e-mail: dev-help@maven.apache.org

    - ---------------------------------------------------------------------
    To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
    For additional commands, e-mail: dev-help@maven.apache.org





    ---------------------------------------------------------------------
    To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
    For additional commands, e-mail: dev-help@maven.apache.org
  • Brett Porter at Nov 1, 2005 at 7:53 pm ⇧
    This would be pointless - the version in /lib is used, so depending on a
    newer version of maven-project won't help the clover plugin on 2.0.

    I'd say do it properly in maven-artifact/project, and put the hackish
    solution in clover plugin.

    - Brett

    John Casey wrote:
    -----BEGIN PGP SIGNED MESSAGE-----
    Hash: SHA1

    The real problem is that the clover plugin depends on resolution of a
    bug in the 2.0 release...there's not a way around that, unless you want
    to get an instance of the ArtifactFactory inside the clover mojo and
    clone the project artifact by force. Otherwise, we'll have to make the
    clover plugin depend on some sort of beyond-2.0 version of maven-project
    (and maybe maven-artifact, depending on how we approach it).

    I can roll back the changes I made to maven-artifact, and do a more
    hackish solution inside MavenProject for the time being. This would keep
    that copy of MavenProject compatible with 2.0, but it still means
    releasing a 2.0-1 or something for maven-project. I'm not opposed to
    this, but I'm not sure whether this fix warrants it or not.

    What do you all think?

    - -john
    ---------------------------------------------------------------------
    To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
    For additional commands, e-mail: dev-help@maven.apache.org
  • John Casey at Nov 1, 2005 at 8:09 pm ⇧
    +1

    Brett Porter wrote:
    This would be pointless - the version in /lib is used, so depending on a
    newer version of maven-project won't help the clover plugin on 2.0.

    I'd say do it properly in maven-artifact/project, and put the hackish
    solution in clover plugin.

    - Brett

    John Casey wrote:
    -----BEGIN PGP SIGNED MESSAGE-----
    Hash: SHA1

    The real problem is that the clover plugin depends on resolution of a
    bug in the 2.0 release...there's not a way around that, unless you want
    to get an instance of the ArtifactFactory inside the clover mojo and
    clone the project artifact by force. Otherwise, we'll have to make the
    clover plugin depend on some sort of beyond-2.0 version of maven-project
    (and maybe maven-artifact, depending on how we approach it).

    I can roll back the changes I made to maven-artifact, and do a more
    hackish solution inside MavenProject for the time being. This would keep
    that copy of MavenProject compatible with 2.0, but it still means
    releasing a 2.0-1 or something for maven-project. I'm not opposed to
    this, but I'm not sure whether this fix warrants it or not.

    What do you all think?

    - -john
    ---------------------------------------------------------------------
    To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
    For additional commands, e-mail: dev-help@maven.apache.org


    ---------------------------------------------------------------------
    To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
    For additional commands, e-mail: dev-help@maven.apache.org
  • Brett Porter at Nov 1, 2005 at 9:56 pm ⇧

    jdcasey@apache.org wrote:
    + this.artifact = new DefaultArtifactFactory().cloneArtifact( project.artifact );
    This doesn't seem very component-oriented :)

    Maybe clone should be a method of artifact (not using the standard Java
    one, but createCopy() or something). The clone method doesn't seem to
    have any relationship to the factory.

    - Brett

    ---------------------------------------------------------------------
    To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
    For additional commands, e-mail: dev-help@maven.apache.org

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupdev @
categoriesmaven
postedNov 1, '05 at 4:54p
activeNov 1, '05 at 9:56p
posts6
users3
websitemaven.apache.org
irc#maven

3 users in discussion

John Casey: 3 posts Brett Porter: 2 posts Vincent Massol: 1 post

Content

People

Support

Translate

site design / logo © 2021 Grokbase