FAQ
improve analysis tests, cut over to new API
-------------------------------------------

Key: SOLR-1674
URL: https://issues.apache.org/jira/browse/SOLR-1674
Project: Solr
Issue Type: Test
Components: Schema and Analysis
Reporter: Robert Muir


This patch
* converts all analysis tests to use the new tokenstream api
* converts most tests to use the more stringent assertion mechanisms from lucene
* adds new tests to improve coverage

Most bugs found by more stringent testing have been fixed, with the exception of SynonymFilter.
The problems with this filter are more serious, the previous tests were essentially a no-op.
The new tests for SynonymFilter test the current behavior, but have FIXMEs with what I think the old test wanted to expect in the comments.



--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Search Discussions

  • Robert Muir (JIRA) at Dec 18, 2009 at 2:47 pm
    [ https://issues.apache.org/jira/browse/SOLR-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Robert Muir updated SOLR-1674:
    ------------------------------

    Attachment: SOLR-1674.patch
    improve analysis tests, cut over to new API
    -------------------------------------------

    Key: SOLR-1674
    URL: https://issues.apache.org/jira/browse/SOLR-1674
    Project: Solr
    Issue Type: Test
    Components: Schema and Analysis
    Reporter: Robert Muir
    Attachments: SOLR-1674.patch


    This patch
    * converts all analysis tests to use the new tokenstream api
    * converts most tests to use the more stringent assertion mechanisms from lucene
    * adds new tests to improve coverage
    Most bugs found by more stringent testing have been fixed, with the exception of SynonymFilter.
    The problems with this filter are more serious, the previous tests were essentially a no-op.
    The new tests for SynonymFilter test the current behavior, but have FIXMEs with what I think the old test wanted to expect in the comments.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Robert Muir (JIRA) at Dec 20, 2009 at 11:38 am
    [ https://issues.apache.org/jira/browse/SOLR-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Robert Muir updated SOLR-1674:
    ------------------------------

    Attachment: SOLR-1674.patch

    here is an updated patch.
    I think I managed to resolve some problems with synonymfilter, especially the recursion tests (I believe they were simply typos and there isnt a bug), and the position increments (this was a problem in the tests)

    so in my opinion, the only problem left is SOLR-1670, the repeat problem.
    improve analysis tests, cut over to new API
    -------------------------------------------

    Key: SOLR-1674
    URL: https://issues.apache.org/jira/browse/SOLR-1674
    Project: Solr
    Issue Type: Test
    Components: Schema and Analysis
    Reporter: Robert Muir
    Attachments: SOLR-1674.patch, SOLR-1674.patch


    This patch
    * converts all analysis tests to use the new tokenstream api
    * converts most tests to use the more stringent assertion mechanisms from lucene
    * adds new tests to improve coverage
    Most bugs found by more stringent testing have been fixed, with the exception of SynonymFilter.
    The problems with this filter are more serious, the previous tests were essentially a no-op.
    The new tests for SynonymFilter test the current behavior, but have FIXMEs with what I think the old test wanted to expect in the comments.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Robert Muir (JIRA) at Dec 20, 2009 at 4:40 pm
    [ https://issues.apache.org/jira/browse/SOLR-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12793001#action_12793001 ]

    Robert Muir edited comment on SOLR-1674 at 12/20/09 4:39 PM:
    -------------------------------------------------------------

    Hello, I see Uwe has commented on SOLR-1657 that he would help convert tokenstreams to the new api, but he needs this patch (the tests) applied first.

    Is it possible for someone to take a look at this patch to get things moving along? its only tests, no source code changes.

    was (Author: rcmuir):
    Hello, I see Uwe has commented on SOLR-1657 that he would help convert tokenstreams to Solr's api, but he needs this patch (the tests) applied first.

    Is it possible for someone to take a look at this patch to get things moving along? its only tests, no source code changes.
    improve analysis tests, cut over to new API
    -------------------------------------------

    Key: SOLR-1674
    URL: https://issues.apache.org/jira/browse/SOLR-1674
    Project: Solr
    Issue Type: Test
    Components: Schema and Analysis
    Reporter: Robert Muir
    Attachments: SOLR-1674.patch, SOLR-1674.patch


    This patch
    * converts all analysis tests to use the new tokenstream api
    * converts most tests to use the more stringent assertion mechanisms from lucene
    * adds new tests to improve coverage
    Most bugs found by more stringent testing have been fixed, with the exception of SynonymFilter.
    The problems with this filter are more serious, the previous tests were essentially a no-op.
    The new tests for SynonymFilter test the current behavior, but have FIXMEs with what I think the old test wanted to expect in the comments.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Robert Muir (JIRA) at Dec 20, 2009 at 4:40 pm
    [ https://issues.apache.org/jira/browse/SOLR-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12793001#action_12793001 ]

    Robert Muir commented on SOLR-1674:
    -----------------------------------

    Hello, I see Uwe has commented on SOLR-1657 that he would help convert tokenstreams to Solr's api, but he needs this patch (the tests) applied first.

    Is it possible for someone to take a look at this patch to get things moving along? its only tests, no source code changes.
    improve analysis tests, cut over to new API
    -------------------------------------------

    Key: SOLR-1674
    URL: https://issues.apache.org/jira/browse/SOLR-1674
    Project: Solr
    Issue Type: Test
    Components: Schema and Analysis
    Reporter: Robert Muir
    Attachments: SOLR-1674.patch, SOLR-1674.patch


    This patch
    * converts all analysis tests to use the new tokenstream api
    * converts most tests to use the more stringent assertion mechanisms from lucene
    * adds new tests to improve coverage
    Most bugs found by more stringent testing have been fixed, with the exception of SynonymFilter.
    The problems with this filter are more serious, the previous tests were essentially a no-op.
    The new tests for SynonymFilter test the current behavior, but have FIXMEs with what I think the old test wanted to expect in the comments.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Mark Miller (JIRA) at Dec 20, 2009 at 4:56 pm
    [ https://issues.apache.org/jira/browse/SOLR-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12793003#action_12793003 ]

    Mark Miller commented on SOLR-1674:
    -----------------------------------

    I think TestCapitalizationFilter and TestMultiWordSynonyms need to be brought back up to trunk? A quick patch attempt is giving me problems.
    improve analysis tests, cut over to new API
    -------------------------------------------

    Key: SOLR-1674
    URL: https://issues.apache.org/jira/browse/SOLR-1674
    Project: Solr
    Issue Type: Test
    Components: Schema and Analysis
    Reporter: Robert Muir
    Attachments: SOLR-1674.patch, SOLR-1674.patch


    This patch
    * converts all analysis tests to use the new tokenstream api
    * converts most tests to use the more stringent assertion mechanisms from lucene
    * adds new tests to improve coverage
    Most bugs found by more stringent testing have been fixed, with the exception of SynonymFilter.
    The problems with this filter are more serious, the previous tests were essentially a no-op.
    The new tests for SynonymFilter test the current behavior, but have FIXMEs with what I think the old test wanted to expect in the comments.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Robert Muir (JIRA) at Dec 20, 2009 at 4:58 pm
    [ https://issues.apache.org/jira/browse/SOLR-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12793004#action_12793004 ]

    Robert Muir commented on SOLR-1674:
    -----------------------------------

    this is because you use $Id$. its not my fault...
    improve analysis tests, cut over to new API
    -------------------------------------------

    Key: SOLR-1674
    URL: https://issues.apache.org/jira/browse/SOLR-1674
    Project: Solr
    Issue Type: Test
    Components: Schema and Analysis
    Reporter: Robert Muir
    Attachments: SOLR-1674.patch, SOLR-1674.patch


    This patch
    * converts all analysis tests to use the new tokenstream api
    * converts most tests to use the more stringent assertion mechanisms from lucene
    * adds new tests to improve coverage
    Most bugs found by more stringent testing have been fixed, with the exception of SynonymFilter.
    The problems with this filter are more serious, the previous tests were essentially a no-op.
    The new tests for SynonymFilter test the current behavior, but have FIXMEs with what I think the old test wanted to expect in the comments.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Mark Miller (JIRA) at Dec 20, 2009 at 5:08 pm
    [ https://issues.apache.org/jira/browse/SOLR-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12793005#action_12793005 ]

    Mark Miller commented on SOLR-1674:
    -----------------------------------

    Thats BS - they are fixable in the patch ;)

    I had those damn $id tags - every time ... I'll fix them.
    improve analysis tests, cut over to new API
    -------------------------------------------

    Key: SOLR-1674
    URL: https://issues.apache.org/jira/browse/SOLR-1674
    Project: Solr
    Issue Type: Test
    Components: Schema and Analysis
    Reporter: Robert Muir
    Attachments: SOLR-1674.patch, SOLR-1674.patch


    This patch
    * converts all analysis tests to use the new tokenstream api
    * converts most tests to use the more stringent assertion mechanisms from lucene
    * adds new tests to improve coverage
    Most bugs found by more stringent testing have been fixed, with the exception of SynonymFilter.
    The problems with this filter are more serious, the previous tests were essentially a no-op.
    The new tests for SynonymFilter test the current behavior, but have FIXMEs with what I think the old test wanted to expect in the comments.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Robert Muir (JIRA) at Dec 20, 2009 at 5:10 pm
    [ https://issues.apache.org/jira/browse/SOLR-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12793006#action_12793006 ]

    Robert Muir commented on SOLR-1674:
    -----------------------------------

    I sent an email... if no one cares about these $id$ tags then when i get back from vacation i will gladly volunteer to submit a patch to remove them :)

    A quick workaround is to change them back to $Id$ in your local, then apply the patch...
    improve analysis tests, cut over to new API
    -------------------------------------------

    Key: SOLR-1674
    URL: https://issues.apache.org/jira/browse/SOLR-1674
    Project: Solr
    Issue Type: Test
    Components: Schema and Analysis
    Reporter: Robert Muir
    Attachments: SOLR-1674.patch, SOLR-1674.patch


    This patch
    * converts all analysis tests to use the new tokenstream api
    * converts most tests to use the more stringent assertion mechanisms from lucene
    * adds new tests to improve coverage
    Most bugs found by more stringent testing have been fixed, with the exception of SynonymFilter.
    The problems with this filter are more serious, the previous tests were essentially a no-op.
    The new tests for SynonymFilter test the current behavior, but have FIXMEs with what I think the old test wanted to expect in the comments.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Mark Miller (JIRA) at Dec 20, 2009 at 5:14 pm
    [ https://issues.apache.org/jira/browse/SOLR-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12793005#action_12793005 ]

    Mark Miller edited comment on SOLR-1674 at 12/20/09 5:13 PM:
    -------------------------------------------------------------

    Thats BS - they are fixable in the patch ;)

    I hate those damn $id tags - every time ... I'll fix them.

    was (Author: markrmiller@gmail.com):
    Thats BS - they are fixable in the patch ;)

    I had those damn $id tags - every time ... I'll fix them.
    improve analysis tests, cut over to new API
    -------------------------------------------

    Key: SOLR-1674
    URL: https://issues.apache.org/jira/browse/SOLR-1674
    Project: Solr
    Issue Type: Test
    Components: Schema and Analysis
    Reporter: Robert Muir
    Attachments: SOLR-1674.patch, SOLR-1674.patch


    This patch
    * converts all analysis tests to use the new tokenstream api
    * converts most tests to use the more stringent assertion mechanisms from lucene
    * adds new tests to improve coverage
    Most bugs found by more stringent testing have been fixed, with the exception of SynonymFilter.
    The problems with this filter are more serious, the previous tests were essentially a no-op.
    The new tests for SynonymFilter test the current behavior, but have FIXMEs with what I think the old test wanted to expect in the comments.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Mark Miller (JIRA) at Dec 20, 2009 at 5:30 pm
    [ https://issues.apache.org/jira/browse/SOLR-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12793008#action_12793008 ]

    Mark Miller commented on SOLR-1674:
    -----------------------------------

    Fixed a small issue with protWords.txt not matching prowrods.txt on unix systems.

    If there are no objections I will commit this beautiful addition to our analysis tests soon.
    improve analysis tests, cut over to new API
    -------------------------------------------

    Key: SOLR-1674
    URL: https://issues.apache.org/jira/browse/SOLR-1674
    Project: Solr
    Issue Type: Test
    Components: Schema and Analysis
    Reporter: Robert Muir
    Attachments: SOLR-1674.patch, SOLR-1674.patch


    This patch
    * converts all analysis tests to use the new tokenstream api
    * converts most tests to use the more stringent assertion mechanisms from lucene
    * adds new tests to improve coverage
    Most bugs found by more stringent testing have been fixed, with the exception of SynonymFilter.
    The problems with this filter are more serious, the previous tests were essentially a no-op.
    The new tests for SynonymFilter test the current behavior, but have FIXMEs with what I think the old test wanted to expect in the comments.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Shalin Shekhar Mangar (JIRA) at Dec 21, 2009 at 12:23 pm
    [ https://issues.apache.org/jira/browse/SOLR-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12793174#action_12793174 ]

    Shalin Shekhar Mangar commented on SOLR-1674:
    ---------------------------------------------

    All tests pass after renaming protWords.txt to protwords.txt. Unfortunately, this is too big to review in detail right now but I trust Robert to do the right thing :)

    bq. If there are no objections I will commit this beautiful addition to our analysis tests soon.

    +1
    improve analysis tests, cut over to new API
    -------------------------------------------

    Key: SOLR-1674
    URL: https://issues.apache.org/jira/browse/SOLR-1674
    Project: Solr
    Issue Type: Test
    Components: Schema and Analysis
    Reporter: Robert Muir
    Attachments: SOLR-1674.patch, SOLR-1674.patch


    This patch
    * converts all analysis tests to use the new tokenstream api
    * converts most tests to use the more stringent assertion mechanisms from lucene
    * adds new tests to improve coverage
    Most bugs found by more stringent testing have been fixed, with the exception of SynonymFilter.
    The problems with this filter are more serious, the previous tests were essentially a no-op.
    The new tests for SynonymFilter test the current behavior, but have FIXMEs with what I think the old test wanted to expect in the comments.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Mark Miller (JIRA) at Dec 21, 2009 at 1:40 pm
    [ https://issues.apache.org/jira/browse/SOLR-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Mark Miller reassigned SOLR-1674:
    ---------------------------------

    Assignee: Mark Miller
    improve analysis tests, cut over to new API
    -------------------------------------------

    Key: SOLR-1674
    URL: https://issues.apache.org/jira/browse/SOLR-1674
    Project: Solr
    Issue Type: Test
    Components: Schema and Analysis
    Reporter: Robert Muir
    Assignee: Mark Miller
    Attachments: SOLR-1674.patch, SOLR-1674.patch


    This patch
    * converts all analysis tests to use the new tokenstream api
    * converts most tests to use the more stringent assertion mechanisms from lucene
    * adds new tests to improve coverage
    Most bugs found by more stringent testing have been fixed, with the exception of SynonymFilter.
    The problems with this filter are more serious, the previous tests were essentially a no-op.
    The new tests for SynonymFilter test the current behavior, but have FIXMEs with what I think the old test wanted to expect in the comments.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Mark Miller (JIRA) at Dec 21, 2009 at 1:58 pm
    [ https://issues.apache.org/jira/browse/SOLR-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Mark Miller resolved SOLR-1674.
    -------------------------------

    Resolution: Fixed

    Thanks a lot Robert! Test contributions are rare and exciting!
    improve analysis tests, cut over to new API
    -------------------------------------------

    Key: SOLR-1674
    URL: https://issues.apache.org/jira/browse/SOLR-1674
    Project: Solr
    Issue Type: Test
    Components: Schema and Analysis
    Reporter: Robert Muir
    Assignee: Mark Miller
    Attachments: SOLR-1674.patch, SOLR-1674.patch


    This patch
    * converts all analysis tests to use the new tokenstream api
    * converts most tests to use the more stringent assertion mechanisms from lucene
    * adds new tests to improve coverage
    Most bugs found by more stringent testing have been fixed, with the exception of SynonymFilter.
    The problems with this filter are more serious, the previous tests were essentially a no-op.
    The new tests for SynonymFilter test the current behavior, but have FIXMEs with what I think the old test wanted to expect in the comments.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Robert Muir (JIRA) at Dec 22, 2009 at 6:15 am
    [ https://issues.apache.org/jira/browse/SOLR-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Robert Muir updated SOLR-1674:
    ------------------------------

    Attachment: SOLR-1674_speedup.patch

    hmm it appears i may have slowed down the junit tests with the previous patch, unfortunately.

    attached is a patch to speed them up... (maybe not necessary, but they were very very slow on my laptop)

    improve analysis tests, cut over to new API
    -------------------------------------------

    Key: SOLR-1674
    URL: https://issues.apache.org/jira/browse/SOLR-1674
    Project: Solr
    Issue Type: Test
    Components: Schema and Analysis
    Reporter: Robert Muir
    Assignee: Mark Miller
    Attachments: SOLR-1674.patch, SOLR-1674.patch, SOLR-1674_speedup.patch


    This patch
    * converts all analysis tests to use the new tokenstream api
    * converts most tests to use the more stringent assertion mechanisms from lucene
    * adds new tests to improve coverage
    Most bugs found by more stringent testing have been fixed, with the exception of SynonymFilter.
    The problems with this filter are more serious, the previous tests were essentially a no-op.
    The new tests for SynonymFilter test the current behavior, but have FIXMEs with what I think the old test wanted to expect in the comments.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Yonik Seeley (JIRA) at Dec 22, 2009 at 3:52 pm
    [ https://issues.apache.org/jira/browse/SOLR-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12793646#action_12793646 ]

    Yonik Seeley commented on SOLR-1674:
    ------------------------------------

    Hmmm, isn't it a bug that this passes?
    assertTokenizesTo(map, "a b", new String[] { "ab", "ab", "ab" });

    w/o the 1670 fix, we get "ab/ab/ab" (repeated tokens all at the same position). That's not the same as three "ab" tokens in a row.

    Also, we seem to have lost matching flexibility with overlapping tokens. "a/aa" should be the same as "aa/a", but if you change the order of overlapping tokens now, the tests fail.

    Didn't ya guys like my a/aa syntax to indicate overlapping tokens? It certainly made it faster for me to write the original testcases :-)
    improve analysis tests, cut over to new API
    -------------------------------------------

    Key: SOLR-1674
    URL: https://issues.apache.org/jira/browse/SOLR-1674
    Project: Solr
    Issue Type: Test
    Components: Schema and Analysis
    Reporter: Robert Muir
    Assignee: Mark Miller
    Attachments: SOLR-1674.patch, SOLR-1674.patch, SOLR-1674_speedup.patch


    This patch
    * converts all analysis tests to use the new tokenstream api
    * converts most tests to use the more stringent assertion mechanisms from lucene
    * adds new tests to improve coverage
    Most bugs found by more stringent testing have been fixed, with the exception of SynonymFilter.
    The problems with this filter are more serious, the previous tests were essentially a no-op.
    The new tests for SynonymFilter test the current behavior, but have FIXMEs with what I think the old test wanted to expect in the comments.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Mark Miller (JIRA) at Dec 22, 2009 at 4:02 pm
    [ https://issues.apache.org/jira/browse/SOLR-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Mark Miller reopened SOLR-1674:
    -------------------------------


    Robert is on holiday I think - will reopen for now.
    improve analysis tests, cut over to new API
    -------------------------------------------

    Key: SOLR-1674
    URL: https://issues.apache.org/jira/browse/SOLR-1674
    Project: Solr
    Issue Type: Test
    Components: Schema and Analysis
    Reporter: Robert Muir
    Assignee: Mark Miller
    Attachments: SOLR-1674.patch, SOLR-1674.patch, SOLR-1674_speedup.patch


    This patch
    * converts all analysis tests to use the new tokenstream api
    * converts most tests to use the more stringent assertion mechanisms from lucene
    * adds new tests to improve coverage
    Most bugs found by more stringent testing have been fixed, with the exception of SynonymFilter.
    The problems with this filter are more serious, the previous tests were essentially a no-op.
    The new tests for SynonymFilter test the current behavior, but have FIXMEs with what I think the old test wanted to expect in the comments.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Robert Muir (JIRA) at Dec 22, 2009 at 4:04 pm
    [ https://issues.apache.org/jira/browse/SOLR-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12793653#action_12793653 ]

    Robert Muir commented on SOLR-1674:
    -----------------------------------

    {quote}
    Hmmm, isn't it a bug that this passes?

    w/o the 1670 fix, we get "ab/ab/ab" (repeated tokens all at the same position). That's not the same as three "ab" tokens in a row.
    {quote}

    The tests pass because it "ab", "ab", "ab". If we want to validate pos incs, we should change the test to:

    {code}
    assertTokenizesTo(map, "a b",
    new String[] { "ab", "ab", "ab" },
    new int [] { 1, 0, 0 });
    {code}

    this way the posIncs are tested too.

    {quote}
    Also, we seem to have lost matching flexibility with overlapping tokens. "a/aa" should be the same as "aa/a", but if you change the order of overlapping tokens now, the tests fail.
    {quote}

    This "flexibility" caused things such as SOLR-1670, SOLR-1667, SOLR-1662, and SOLR-1660. When I switched to less "flexible" tests, these bugs were found. So sorry to see it go.

    improve analysis tests, cut over to new API
    -------------------------------------------

    Key: SOLR-1674
    URL: https://issues.apache.org/jira/browse/SOLR-1674
    Project: Solr
    Issue Type: Test
    Components: Schema and Analysis
    Reporter: Robert Muir
    Assignee: Mark Miller
    Attachments: SOLR-1674.patch, SOLR-1674.patch, SOLR-1674_speedup.patch


    This patch
    * converts all analysis tests to use the new tokenstream api
    * converts most tests to use the more stringent assertion mechanisms from lucene
    * adds new tests to improve coverage
    Most bugs found by more stringent testing have been fixed, with the exception of SynonymFilter.
    The problems with this filter are more serious, the previous tests were essentially a no-op.
    The new tests for SynonymFilter test the current behavior, but have FIXMEs with what I think the old test wanted to expect in the comments.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Mark Miller (JIRA) at Mar 10, 2010 at 4:22 pm
    [ https://issues.apache.org/jira/browse/SOLR-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12843611#action_12843611 ]

    Mark Miller commented on SOLR-1674:
    -----------------------------------

    I've committed the speed up patch, thanks Robert!

    Leaving open for posInc tests
    improve analysis tests, cut over to new API
    -------------------------------------------

    Key: SOLR-1674
    URL: https://issues.apache.org/jira/browse/SOLR-1674
    Project: Solr
    Issue Type: Test
    Components: Schema and Analysis
    Reporter: Robert Muir
    Assignee: Mark Miller
    Attachments: SOLR-1674.patch, SOLR-1674.patch, SOLR-1674_speedup.patch


    This patch
    * converts all analysis tests to use the new tokenstream api
    * converts most tests to use the more stringent assertion mechanisms from lucene
    * adds new tests to improve coverage
    Most bugs found by more stringent testing have been fixed, with the exception of SynonymFilter.
    The problems with this filter are more serious, the previous tests were essentially a no-op.
    The new tests for SynonymFilter test the current behavior, but have FIXMEs with what I think the old test wanted to expect in the comments.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupsolr-dev @
categorieslucene
postedDec 18, '09 at 2:45p
activeMar 10, '10 at 4:22p
posts19
users1
websitelucene.apache.org...

1 user in discussion

Mark Miller (JIRA): 19 posts

People

Translate

site design / logo © 2019 Grokbase