FAQ
Upgrade custom Solr Highlighter classes to new Lucene Highlighter API
---------------------------------------------------------------------

Key: SOLR-1319
URL: https://issues.apache.org/jira/browse/SOLR-1319
Project: Solr
Issue Type: Task
Components: highlighter
Reporter: Mark Miller
Assignee: Mark Miller
Fix For: 1.4




--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Search Discussions

  • Mark Miller (JIRA) at Aug 4, 2009 at 2:01 pm
    [ https://issues.apache.org/jira/browse/SOLR-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12738978#action_12738978 ]

    Mark Miller commented on SOLR-1319:
    -----------------------------------

    the regex fragementer has to be updated (got a patch for that) and some work has to be done now that SpanScorer is gone, and the semantics/syntax for it is a bit different.

    Prob makes sense to do SOLR-1221 with this one.
    Upgrade custom Solr Highlighter classes to new Lucene Highlighter API
    ---------------------------------------------------------------------

    Key: SOLR-1319
    URL: https://issues.apache.org/jira/browse/SOLR-1319
    Project: Solr
    Issue Type: Task
    Components: highlighter
    Reporter: Mark Miller
    Assignee: Mark Miller
    Fix For: 1.4

    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Mark Miller (JIRA) at Aug 6, 2009 at 6:06 pm
    [ https://issues.apache.org/jira/browse/SOLR-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740177#action_12740177 ]

    Mark Miller commented on SOLR-1319:
    -----------------------------------

    Bah - I really gave myself a headache here. Lucene Highlighter broke back compat - which ripples here a bit. I think the impact can be mitigated if we switch to using the PhraseHighlighter by default (SOLR-1221) though.
    Upgrade custom Solr Highlighter classes to new Lucene Highlighter API
    ---------------------------------------------------------------------

    Key: SOLR-1319
    URL: https://issues.apache.org/jira/browse/SOLR-1319
    Project: Solr
    Issue Type: Task
    Components: highlighter
    Reporter: Mark Miller
    Assignee: Mark Miller
    Fix For: 1.4

    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Mark Miller (JIRA) at Aug 6, 2009 at 7:03 pm
    [ https://issues.apache.org/jira/browse/SOLR-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740204#action_12740204 ]

    Mark Miller commented on SOLR-1319:
    -----------------------------------

    We should probably be careful here in the future, and document anything thats based on code in Lucene without a backcompat policy to have similar looseness in Solr - or hide the Lucene implementation from the Solr public API's.
    Upgrade custom Solr Highlighter classes to new Lucene Highlighter API
    ---------------------------------------------------------------------

    Key: SOLR-1319
    URL: https://issues.apache.org/jira/browse/SOLR-1319
    Project: Solr
    Issue Type: Task
    Components: highlighter
    Reporter: Mark Miller
    Assignee: Mark Miller
    Fix For: 1.4

    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Mark Miller (JIRA) at Aug 29, 2009 at 4:39 pm
    [ https://issues.apache.org/jira/browse/SOLR-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12749163#action_12749163 ]

    Mark Miller commented on SOLR-1319:
    -----------------------------------

    The break is that {code}protected QueryTermScorer getQueryScorer(Query query, String fieldName, SolrQueryRequest request) {code} now has a different return type. Its too bad it wasnt done the same way as the SpanScorer - there you can just override the getSpanHighlighter call, but getting the Scorer is private.

    So its a break, though no one was overriding it likely - we should almost make it private - you can anything you need to overriding the getHighlighter call. At least, I should have changed it to just Scorer rather than QueryTermScorer.
    Upgrade custom Solr Highlighter classes to new Lucene Highlighter API
    ---------------------------------------------------------------------

    Key: SOLR-1319
    URL: https://issues.apache.org/jira/browse/SOLR-1319
    Project: Solr
    Issue Type: Task
    Components: highlighter
    Reporter: Mark Miller
    Assignee: Mark Miller
    Fix For: 1.4

    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Grant Ingersoll (JIRA) at Sep 10, 2009 at 4:54 pm
    [ https://issues.apache.org/jira/browse/SOLR-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753701#action_12753701 ]

    Grant Ingersoll commented on SOLR-1319:
    ---------------------------------------

    Given there is no patch, should this be pushed to 1.5?
    Upgrade custom Solr Highlighter classes to new Lucene Highlighter API
    ---------------------------------------------------------------------

    Key: SOLR-1319
    URL: https://issues.apache.org/jira/browse/SOLR-1319
    Project: Solr
    Issue Type: Task
    Components: highlighter
    Reporter: Mark Miller
    Assignee: Mark Miller
    Fix For: 1.4

    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Mark Miller (JIRA) at Sep 27, 2009 at 4:57 am
    [ https://issues.apache.org/jira/browse/SOLR-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12759988#action_12759988 ]

    Mark Miller commented on SOLR-1319:
    -----------------------------------

    bq. Given there is no patch, should this be pushed to 1.5?

    Nope, the actual work was part of another issue - the only reason this is still open was because there was a back compat break (due to a back compat break in Lucene's Highlighter, which doesn't promise back compat). So this is open as a marker to somehow deal with the break in Solr -

    Our options are fairly limited - basically, I think it means adding a notice in Changes about the whole affair. I'll try and work something up.
    Upgrade custom Solr Highlighter classes to new Lucene Highlighter API
    ---------------------------------------------------------------------

    Key: SOLR-1319
    URL: https://issues.apache.org/jira/browse/SOLR-1319
    Project: Solr
    Issue Type: Task
    Components: highlighter
    Reporter: Mark Miller
    Assignee: Mark Miller
    Fix For: 1.4

    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Yonik Seeley (JIRA) at Oct 3, 2009 at 7:37 pm
    [ https://issues.apache.org/jira/browse/SOLR-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761946#action_12761946 ]

    Yonik Seeley commented on SOLR-1319:
    ------------------------------------

    if I'm reading this correctly, the back compat break is for those providing their own custom highlighter? That's gotta be almost no one... doesn't seem like a big deal as it seems more like internal implementation than interface.
    Upgrade custom Solr Highlighter classes to new Lucene Highlighter API
    ---------------------------------------------------------------------

    Key: SOLR-1319
    URL: https://issues.apache.org/jira/browse/SOLR-1319
    Project: Solr
    Issue Type: Task
    Components: highlighter
    Reporter: Mark Miller
    Assignee: Mark Miller
    Fix For: 1.4

    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Mark Miller (JIRA) at Oct 3, 2009 at 8:01 pm
    [ https://issues.apache.org/jira/browse/SOLR-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761949#action_12761949 ]

    Mark Miller commented on SOLR-1319:
    -----------------------------------

    Right - I don't think its a big deal either. But the Highlighter framework has things like protected methods that are not overridden internally - seems to suggest that users could/might override them - whether we know they do or not, I think thats worth a mention in Changes on the break. Certainly easy enough to do anyway.

    The break itself is even less likely to be an issue than a custom highlighter in general - I like the completeness myself though. Its an extendable public class and Solr allows for plugins.
    Upgrade custom Solr Highlighter classes to new Lucene Highlighter API
    ---------------------------------------------------------------------

    Key: SOLR-1319
    URL: https://issues.apache.org/jira/browse/SOLR-1319
    Project: Solr
    Issue Type: Task
    Components: highlighter
    Reporter: Mark Miller
    Assignee: Mark Miller
    Fix For: 1.4

    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Mark Miller (JIRA) at Oct 4, 2009 at 4:19 pm
    [ https://issues.apache.org/jira/browse/SOLR-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Mark Miller updated SOLR-1319:
    ------------------------------

    Attachment: SOLR-1319.patch
    Upgrade custom Solr Highlighter classes to new Lucene Highlighter API
    ---------------------------------------------------------------------

    Key: SOLR-1319
    URL: https://issues.apache.org/jira/browse/SOLR-1319
    Project: Solr
    Issue Type: Task
    Components: highlighter
    Reporter: Mark Miller
    Assignee: Mark Miller
    Fix For: 1.4

    Attachments: SOLR-1319.patch

    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Mark Miller (JIRA) at Oct 4, 2009 at 4:27 pm
    [ https://issues.apache.org/jira/browse/SOLR-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Mark Miller resolved SOLR-1319.
    -------------------------------

    Resolution: Fixed
    Upgrade custom Solr Highlighter classes to new Lucene Highlighter API
    ---------------------------------------------------------------------

    Key: SOLR-1319
    URL: https://issues.apache.org/jira/browse/SOLR-1319
    Project: Solr
    Issue Type: Task
    Components: highlighter
    Reporter: Mark Miller
    Assignee: Mark Miller
    Fix For: 1.4

    Attachments: SOLR-1319.patch

    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupsolr-dev @
categorieslucene
postedJul 31, '09 at 2:28p
activeOct 4, '09 at 4:27p
posts11
users1
websitelucene.apache.org...

1 user in discussion

Mark Miller (JIRA): 11 posts

People

Translate

site design / logo © 2019 Grokbase