FAQ
Change SolrIndexSearcher to use inheritence rather than delegation
------------------------------------------------------------------

Key: SOLR-1012
URL: https://issues.apache.org/jira/browse/SOLR-1012
Project: Solr
Issue Type: Improvement
Reporter: Mark Miller
Priority: Trivial


cleans out some unnecessary delegation methods.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Search Discussions

  • Mark Miller (JIRA) at Feb 8, 2009 at 7:33 pm
    [ https://issues.apache.org/jira/browse/SOLR-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Mark Miller updated SOLR-1012:
    ------------------------------

    Attachment: SOLR-1012.patch
    Change SolrIndexSearcher to use inheritence rather than delegation
    ------------------------------------------------------------------

    Key: SOLR-1012
    URL: https://issues.apache.org/jira/browse/SOLR-1012
    Project: Solr
    Issue Type: Improvement
    Reporter: Mark Miller
    Priority: Trivial
    Attachments: SOLR-1012.patch


    cleans out some unnecessary delegation methods.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Yonik Seeley (JIRA) at May 3, 2009 at 2:39 pm
    [ https://issues.apache.org/jira/browse/SOLR-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705422#action_12705422 ]

    Yonik Seeley commented on SOLR-1012:
    ------------------------------------

    Seems fine, no reason we shouldn't use inheritance I think.
    Change SolrIndexSearcher to use inheritence rather than delegation
    ------------------------------------------------------------------

    Key: SOLR-1012
    URL: https://issues.apache.org/jira/browse/SOLR-1012
    Project: Solr
    Issue Type: Improvement
    Reporter: Mark Miller
    Priority: Trivial
    Attachments: SOLR-1012.patch


    cleans out some unnecessary delegation methods.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Mark Miller (JIRA) at May 12, 2009 at 2:54 pm
    [ https://issues.apache.org/jira/browse/SOLR-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Mark Miller reassigned SOLR-1012:
    ---------------------------------

    Assignee: Mark Miller
    Change SolrIndexSearcher to use inheritence rather than delegation
    ------------------------------------------------------------------

    Key: SOLR-1012
    URL: https://issues.apache.org/jira/browse/SOLR-1012
    Project: Solr
    Issue Type: Improvement
    Reporter: Mark Miller
    Assignee: Mark Miller
    Priority: Trivial
    Attachments: SOLR-1012.patch


    cleans out some unnecessary delegation methods.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Mark Miller (JIRA) at May 12, 2009 at 5:54 pm
    [ https://issues.apache.org/jira/browse/SOLR-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Mark Miller resolved SOLR-1012.
    -------------------------------

    Resolution: Fixed
    Fix Version/s: 1.4
    Change SolrIndexSearcher to use inheritence rather than delegation
    ------------------------------------------------------------------

    Key: SOLR-1012
    URL: https://issues.apache.org/jira/browse/SOLR-1012
    Project: Solr
    Issue Type: Improvement
    Reporter: Mark Miller
    Assignee: Mark Miller
    Priority: Trivial
    Fix For: 1.4

    Attachments: SOLR-1012.patch


    cleans out some unnecessary delegation methods.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Mark Miller (JIRA) at May 25, 2009 at 8:54 pm
    [ https://issues.apache.org/jira/browse/SOLR-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Mark Miller reopened SOLR-1012:
    -------------------------------


    I'm about to revert this. Its original conception made sense, but then SolrIndexReader was introduced and this change made it so that the Lucene IndexSearcher was init'd with a regular IndexReader rather than a SolrIndexReader. The new Lucene filter stuff just committed casts to a SolrIndexReader, and so expects the Lucene IndexSearcher to hand it a SolrIndexReader. Thats a pain to accomplish with inheritance, so moving back to delegation. It wasn't much of a win to begin with (minor code elimination), so no use fighting for it.
    Change SolrIndexSearcher to use inheritence rather than delegation
    ------------------------------------------------------------------

    Key: SOLR-1012
    URL: https://issues.apache.org/jira/browse/SOLR-1012
    Project: Solr
    Issue Type: Improvement
    Reporter: Mark Miller
    Assignee: Mark Miller
    Priority: Trivial
    Fix For: 1.4

    Attachments: SOLR-1012.patch


    cleans out some unnecessary delegation methods.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Mark Miller (JIRA) at Jun 4, 2009 at 12:21 pm
    [ https://issues.apache.org/jira/browse/SOLR-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Mark Miller resolved SOLR-1012.
    -------------------------------

    Resolution: Fixed

    yonik fixed nicely without the revert
    Change SolrIndexSearcher to use inheritence rather than delegation
    ------------------------------------------------------------------

    Key: SOLR-1012
    URL: https://issues.apache.org/jira/browse/SOLR-1012
    Project: Solr
    Issue Type: Improvement
    Reporter: Mark Miller
    Assignee: Mark Miller
    Priority: Trivial
    Fix For: 1.4

    Attachments: SOLR-1012.patch


    cleans out some unnecessary delegation methods.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupsolr-dev @
categorieslucene
postedFeb 8, '09 at 7:15p
activeJun 4, '09 at 12:21p
posts7
users1
websitelucene.apache.org...

1 user in discussion

Mark Miller (JIRA): 7 posts

People

Translate

site design / logo © 2019 Grokbase