FAQ
Move facet tests into own class
-------------------------------

Key: SOLR-645
URL: https://issues.apache.org/jira/browse/SOLR-645
Project: Solr
Issue Type: Task
Affects Versions: 1.3
Reporter: Lars Kotthoff
Priority: Minor


The tests for faceting currently reside in BasicFunctionalityTest (line count 1339). They should be moved to their own class in o.a.s.request to make them easier to find and to reduce the size of BasicFunctionalityTest.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Search Discussions

  • Lars Kotthoff (JIRA) at Jul 22, 2008 at 5:02 am
    [ https://issues.apache.org/jira/browse/SOLR-645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Lars Kotthoff updated SOLR-645:
    -------------------------------

    Attachment: SOLR-645.patch

    Patch moving the tests to o.a.s.request.SimpleFacetsTest.
    Move facet tests into own class
    -------------------------------

    Key: SOLR-645
    URL: https://issues.apache.org/jira/browse/SOLR-645
    Project: Solr
    Issue Type: Task
    Affects Versions: 1.3
    Reporter: Lars Kotthoff
    Priority: Minor
    Attachments: SOLR-645.patch


    The tests for faceting currently reside in BasicFunctionalityTest (line count 1339). They should be moved to their own class in o.a.s.request to make them easier to find and to reduce the size of BasicFunctionalityTest.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Hoss Man (JIRA) at Jul 24, 2008 at 7:04 pm
    [ https://issues.apache.org/jira/browse/SOLR-645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Hoss Man resolved SOLR-645.
    ---------------------------

    Resolution: Fixed
    Fix Version/s: 1.3
    Assignee: Hoss Man

    Committed revision 679490.

    Thanks Lars
    Move facet tests into own class
    -------------------------------

    Key: SOLR-645
    URL: https://issues.apache.org/jira/browse/SOLR-645
    Project: Solr
    Issue Type: Task
    Affects Versions: 1.3
    Reporter: Lars Kotthoff
    Assignee: Hoss Man
    Priority: Minor
    Fix For: 1.3

    Attachments: SOLR-645.patch


    The tests for faceting currently reside in BasicFunctionalityTest (line count 1339). They should be moved to their own class in o.a.s.request to make them easier to find and to reduce the size of BasicFunctionalityTest.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Lars Kotthoff (JIRA) at Jul 25, 2008 at 2:02 am
    [ https://issues.apache.org/jira/browse/SOLR-645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Lars Kotthoff closed SOLR-645.
    ------------------------------

    Move facet tests into own class
    -------------------------------

    Key: SOLR-645
    URL: https://issues.apache.org/jira/browse/SOLR-645
    Project: Solr
    Issue Type: Task
    Affects Versions: 1.3
    Reporter: Lars Kotthoff
    Assignee: Hoss Man
    Priority: Minor
    Fix For: 1.3

    Attachments: SOLR-645.patch


    The tests for faceting currently reside in BasicFunctionalityTest (line count 1339). They should be moved to their own class in o.a.s.request to make them easier to find and to reduce the size of BasicFunctionalityTest.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Ryan McKinley at Jul 25, 2008 at 2:52 am
    FYI, I don't think we tend to "Close" issues. Typically we leave the
    status as "Resolved"

    not that it is a big deal....

    On Jul 24, 2008, at 10:01 PM, Lars Kotthoff (JIRA) wrote:


    [ https://issues.apache.org/jira/browse/SOLR-645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
    ]

    Lars Kotthoff closed SOLR-645.
    ------------------------------

    Move facet tests into own class
    -------------------------------

    Key: SOLR-645
    URL: https://issues.apache.org/jira/browse/SOLR-645
    Project: Solr
    Issue Type: Task
    Affects Versions: 1.3
    Reporter: Lars Kotthoff
    Assignee: Hoss Man
    Priority: Minor
    Fix For: 1.3

    Attachments: SOLR-645.patch


    The tests for faceting currently reside in BasicFunctionalityTest
    (line count 1339). They should be moved to their own class in
    o.a.s.request to make them easier to find and to reduce the size of
    BasicFunctionalityTest.
    --
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
  • Chris Hostetter at Jul 25, 2008 at 2:58 am
    :
    : FYI, I don't think we tend to "Close" issues. Typically we leave the status
    : as "Resolved"
    :
    : not that it is a big deal....

    yeah ... Lucene-Java sort of established a precident of leaving issues
    RESOLVED until there was a formal release containing the fix (ie: once hte
    "Fix Version" is released) and then bulk CLOSEing ... but i honeslty don't
    rememebr if we ever did that when 1.1 or 1.2 came out.



    -Hoss
  • Lars Kotthoff at Jul 25, 2008 at 10:47 am
    I'm sorry about the excess email traffic -- I thought/hoped that JIRA would
    suppress sending the notifications if I bulk modified the issues.

    I just closed them because I accidentially hovered over the "resolved" icon and
    it said something like "pending verification until closed", so I thought closing
    them would be the proper way to do it.

    Lars
  • Chris Hostetter at Jul 25, 2008 at 6:00 pm
    : I'm sorry about the excess email traffic -- I thought/hoped that JIRA would
    : suppress sending the notifications if I bulk modified the issues.

    It's not big deal ... i think there is a "don't send mail" option
    that you have to explicitly look for & check in order to get that behavior
    when bulk modifing.

    : I just closed them because I accidentially hovered over the "resolved" icon and
    : it said something like "pending verification until closed", so I thought closing
    : them would be the proper way to do it.

    Like i said ... no biggee ... Jira has a lot of quirks.


    -Hoss

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupsolr-dev @
categorieslucene
postedJul 22, '08 at 5:00a
activeJul 25, '08 at 6:00p
posts8
users4
websitelucene.apache.org...

People

Translate

site design / logo © 2019 Grokbase